Page MenuHomePhabricator
Feed Advanced Search

Dec 16 2021

epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Fix a strlen() in query construction.
Dec 16 2021, 11:09 PM
epriestley updated the diff for D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
  • Add annotations for interfaces implemented by PhabricatorHandleList.
Dec 16 2021, 11:08 PM
epriestley requested review of D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:08 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21744: Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration.
Dec 16 2021, 11:07 PM · Infrastructure
epriestley added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 changed semantics of static variables in methods. See:

Dec 16 2021, 10:42 PM · Infrastructure
epriestley added a comment to T13492: Upgrade Support Infrastructure to Minimum PHP Version 5.5.

See also T13588. Using static::class to work around changes to the scope of static in PHP 8.1 is also possible now that PHP 5.5 is the minimum version, and some uses of get_class($this) might be replaceable. There's no strong motivator for this, it's just a little cleaner.

Dec 16 2021, 10:40 PM · Infrastructure
epriestley added a comment to T13637: PHP Static Method Variable Scope.

See also T13588.

Dec 16 2021, 10:37 PM · Lint, Guides
epriestley lowered the priority of T13655: Provide a formal "destroyed" status for Phacility instances from Normal to Wishlist.

It would still be nice to have this from a completeness/correctness perspective, but other changes have made it less valuable:

Dec 16 2021, 2:58 PM · Phacility

Dec 14 2021

epriestley added a comment to T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way.

...possibly, but not conclusively, a result of an SSH version upgrade...

Dec 14 2021, 8:02 PM · Passphrase, Diffusion
epriestley triaged T13670: When a repository remote URI has a username in the URI and a different credential username, fail in an obvious way as Wishlist priority.
Dec 14 2021, 5:58 PM · Passphrase, Diffusion

Dec 11 2021

epriestley requested review of D21743: Fix a PHP 8.1 issue in lint rendering.
Dec 11 2021, 7:18 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21743: Fix a PHP 8.1 issue in lint rendering.
Dec 11 2021, 7:17 PM · Infrastructure
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I put all the database migration stuff everywhere and it appears stable. I'm hooking up Postmark as an outbound pathway now. If I get that working, I'll let it sit for a while and start migrating databases.

Dec 11 2021, 5:43 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 11 2021, 3:48 PM
epriestley committed rARC3f08a11b10a3: (stable) Promote 2021 Week 50 (authored by epriestley).
(stable) Promote 2021 Week 50
Dec 11 2021, 3:48 PM
epriestley committed rP5c5b7daaeba3: (stable) Promote 2021 Week 50 (authored by epriestley).
(stable) Promote 2021 Week 50
Dec 11 2021, 3:48 PM
epriestley created an object: 2021 Week 50 (Mid December).
Dec 11 2021, 3:47 PM

Dec 10 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Finally, there are other some MySQL version issues which can be avoided with:

Dec 10 2021, 6:22 PM · Almanac, Infrastructure, Phacility
epriestley closed D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:42 AM
epriestley committed rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes (authored by epriestley).
Provide additional Arcanist PHP 8.1 fixes
Dec 10 2021, 12:42 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
  • Also fix service profiler test case.
Dec 10 2021, 12:41 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
  • Fix unit tests and a handful of other errors.
Dec 10 2021, 12:38 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:37 AM
epriestley updated the diff for D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:36 AM
epriestley requested review of D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:21 AM
epriestley added a revision to T13588: PHP 8 Compatibility: D21742: Provide additional Arcanist PHP 8.1 fixes.
Dec 10 2021, 12:21 AM · Infrastructure

Dec 9 2021

epriestley closed D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 11:59 PM
epriestley committed rARC488f13a60e88: Add a lint rule forbidding use of "each()" (authored by epriestley).
Add a lint rule forbidding use of "each()"
Dec 9 2021, 11:59 PM
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The new core/ support for the API is partially deployed; the new services/ support isn't anywhere yet.

Dec 9 2021, 11:13 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to D21741: Add a lint rule forbidding use of "each()".

Ah, yep, should be 7.2 -- thanks!

Dec 9 2021, 10:10 PM
epriestley updated the summary of D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 10:10 PM
epriestley requested review of D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 9:55 PM
epriestley added a revision to T13588: PHP 8 Compatibility: D21741: Add a lint rule forbidding use of "each()".
Dec 9 2021, 9:55 PM · Infrastructure
epriestley closed D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 9:44 PM
epriestley committed rARC3626582354e4: Correct some Arcanist behaviors under PHP8.1 (authored by epriestley).
Correct some Arcanist behaviors under PHP8.1
Dec 9 2021, 9:44 PM
epriestley requested review of D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 8:46 PM
epriestley added a comment to T13588: PHP 8 Compatibility.

See also T13232. Here's a possible build strategy for PHP 8.1 under macOS Mojave. Anyone reasonable should probably give up and use brew instead.

Dec 9 2021, 8:46 PM · Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: D21740: Correct some Arcanist behaviors under PHP8.1.
Dec 9 2021, 8:46 PM · Infrastructure

Dec 8 2021

epriestley edited the content of Migrating Repository Shards.
Dec 8 2021, 9:39 PM · Phacility

Dec 4 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The latest version of Phabricator itself is everywhere.

Dec 4 2021, 11:46 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I'm going to hold it until the weekend and try deploying then if things look calm on my end.

Dec 4 2021, 9:23 PM · Almanac, Infrastructure, Phacility

Dec 2 2021

epriestley committed rPdc705cea7fec: Document Mailgun as discouraged, and update Postmark remote address blocks (authored by epriestley).
Document Mailgun as discouraged, and update Postmark remote address blocks
Dec 2 2021, 10:56 PM
epriestley closed D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:56 PM
epriestley closed D21739: Update the extracted cURL SSL CA bundle.
Dec 2 2021, 10:56 PM
epriestley committed rARC13d3a3c3b100: Update the extracted cURL SSL CA bundle (authored by epriestley).
Update the extracted cURL SSL CA bundle
Dec 2 2021, 10:56 PM
epriestley requested review of D21739: Update the extracted cURL SSL CA bundle.
Dec 2 2021, 10:56 PM
epriestley requested review of D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:50 PM
epriestley added a revision to T13669: Discourage use of Mailgun as a mail provider: D21738: Document Mailgun as discouraged, and update Postmark remote address blocks.
Dec 2 2021, 10:48 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:42 PM · Guides, Mail
epriestley updated the task description for T13669: Discourage use of Mailgun as a mail provider.
Dec 2 2021, 10:39 PM · Guides, Mail
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

I'm satisfied that we aren't violating our commitment to our customers by continuing to use Mailgun as a service provider...

Dec 2 2021, 10:39 PM · Phacility, Security, Mail
epriestley created U49 Mailgun Discouraged.
Dec 2 2021, 10:34 PM
epriestley added a comment to T13669: Discourage use of Mailgun as a mail provider.

Purely venting, but the advanced version of "click here to schedule a mysterious meeting" is to outright lie -- pretending that you deeply respect the recipient's achievements -- before asking them to schedule a mysterious meeting.

Dec 2 2021, 10:30 PM · Guides, Mail
epriestley triaged T13669: Discourage use of Mailgun as a mail provider as Normal priority.
Dec 2 2021, 10:12 PM · Guides, Mail

Dec 1 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

While waiting to deploy db stuff, I was planning to look at pruning dead data out of S3 -- but, on closer examination, the total S3 bill is something like $1/day, so no priority on that whatsoever.

Dec 1 2021, 11:57 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 11:47 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.
  • Make InstancesStateQuery use a dictionary when building the database ref information internally.
Dec 1 2021, 11:06 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 11:03 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 10:44 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 9:34 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Dec 1 2021, 9:25 PM · Almanac, Infrastructure, Phacility
epriestley edited the content of Changelog.
Dec 1 2021, 9:23 PM
epriestley committed rARC59b273fd15d3: (stable) Promote 2021 Week 49 (authored by epriestley).
(stable) Promote 2021 Week 49
Dec 1 2021, 9:22 PM
epriestley committed rPd96bd22b8d59: (stable) Promote 2021 Week 49 (authored by epriestley).
(stable) Promote 2021 Week 49
Dec 1 2021, 9:21 PM
epriestley created an object: 2021 Week 49 (Early December).
Dec 1 2021, 9:21 PM
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver also needs to be able to provision database hosts, but these are more-or-less a trivial subset of repository hosts.

Dec 1 2021, 8:44 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I completed all the repository migrations over the weekend and seemingly haven't run into any issues.

Dec 1 2021, 8:41 PM · Almanac, Infrastructure, Phacility

Nov 22 2021

epriestley closed T13653: After an AWS event, Phacility hosts may come up with swap only partially configured as Resolved.

This appears resolved: the workflow now tests that /proc/meminfo reports an appropriate value for TotalSwap.

Nov 22 2021, 2:02 PM · Phacility
epriestley committed rARCc23222438b30: (stable) Provide an API for parsing swap information from "/proc/meminfo" (authored by epriestley).
(stable) Provide an API for parsing swap information from "/proc/meminfo"
Nov 22 2021, 1:45 PM
epriestley closed D21733: Provide an API for parsing swap information from "/proc/meminfo".
Nov 22 2021, 1:45 PM
epriestley committed rARCc53bb21bbd3e: Provide an API for parsing swap information from "/proc/meminfo" (authored by epriestley).
Provide an API for parsing swap information from "/proc/meminfo"
Nov 22 2021, 1:45 PM
epriestley added a comment to D21733: Provide an API for parsing swap information from "/proc/meminfo".

This overlaps somewhat with PhutilSystem::getSystemMemoryInformation(), but that mechanism is narrower and also doesn't really work in practice, so it would probably be reasonable to remove it entirely.

Nov 22 2021, 1:43 PM
epriestley updated the diff for D21733: Provide an API for parsing swap information from "/proc/meminfo".

Satisfy lint by catching and re-throwing Throwable.

Nov 22 2021, 1:32 PM
epriestley requested review of D21733: Provide an API for parsing swap information from "/proc/meminfo".
Nov 22 2021, 1:30 PM
epriestley added a revision to T13653: After an AWS event, Phacility hosts may come up with swap only partially configured: D21733: Provide an API for parsing swap information from "/proc/meminfo".
Nov 22 2021, 1:30 PM · Phacility

Nov 21 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Just for completeness, vault used to be an HAProxy host serving as an SSH load balancer, but this responsibility moved to lb001 once ELBs became able to listen on inbound port 22 and TCP forward, so there is no longer a vault class of machines.

Nov 21 2021, 3:55 PM · Almanac, Infrastructure, Phacility

Nov 20 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

The new provisioning process for repository shards is:

Nov 20 2021, 9:02 PM · Almanac, Infrastructure, Phacility

Nov 19 2021

epriestley closed D21732: Allow "PhutilAWSException" to identify "EBS: Not Found" errors.
Nov 19 2021, 10:55 PM
epriestley committed rARC7cbdf378198b: Allow "PhutilAWSException" to identify "EBS: Not Found" errors (authored by epriestley).
Allow "PhutilAWSException" to identify "EBS: Not Found" errors
Nov 19 2021, 10:55 PM
epriestley requested review of D21732: Allow "PhutilAWSException" to identify "EBS: Not Found" errors.
Nov 19 2021, 10:28 PM
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: D21732: Allow "PhutilAWSException" to identify "EBS: Not Found" errors.
Nov 19 2021, 10:27 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Nov 19 2021, 10:24 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Piledriver was built before the FutureGraph stuff settled in T11968; it runs into the same general set of sequencing problems and yield would likely be a good approach.

Nov 19 2021, 10:22 PM · Almanac, Infrastructure, Phacility
epriestley committed rP8103d361774c: Remove "bin/celerity" dependency on database setup (authored by epriestley).
Remove "bin/celerity" dependency on database setup
Nov 19 2021, 6:11 PM
epriestley closed D21730: Remove "bin/celerity" dependency on database setup.
Nov 19 2021, 6:11 PM
epriestley added a comment to D21730: Remove "bin/celerity" dependency on database setup.

See also D19941, which removed a dependency that did previously exist.

Nov 19 2021, 6:10 PM
epriestley requested review of D21730: Remove "bin/celerity" dependency on database setup.
Nov 19 2021, 5:58 PM

Nov 18 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I can't figure out how to delete...

Nov 18 2021, 7:24 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

I got rid of everything I could, and nothing appears to be affected.

Nov 18 2021, 7:20 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

We have a lot of leftover VPC cruft that I'm going to nuke, notably meta and admin VPCs that (as far as I can tell) have nothing in them, and then a bunch of subnets (meta.private-a, meta.private-b, block-public-222, admin.public-a, admin.public-b, meta.public-a, meta.public-b, block-private-3) and some NGWs etc. I'm like 99% sure this stuff is all leftover from testing years ago and nothing depends on it, but I guess we'll see what happens when I delete all of it.

Nov 18 2021, 6:55 PM · Almanac, Infrastructure, Phacility
epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

Here's the last known state of the world from T12816:

Nov 18 2021, 6:49 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Nov 18 2021, 6:26 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Nov 18 2021, 6:21 PM · Almanac, Infrastructure, Phacility
epriestley added a revision to T13630: Move Phacility provisioning to Piledriver: Unknown Object (Differential Revision).
Nov 18 2021, 5:15 PM · Almanac, Infrastructure, Phacility

Nov 17 2021

epriestley added a comment to T13630: Move Phacility provisioning to Piledriver.

See also NAT carryover from T12816, via T13542.

Nov 17 2021, 8:02 PM · Almanac, Infrastructure, Phacility
epriestley closed T13542: Rebalance Phacility instances into a private subnet as Resolved.

Closing this in favor of T13630, which covers the same ground.

Nov 17 2021, 8:02 PM · Phacility

Nov 16 2021

epriestley closed D21726: Provide missing "AlmanacInterfaceTransactionQuery".
Nov 16 2021, 7:48 PM
epriestley committed rPc7b04170fedc: Provide missing "AlmanacInterfaceTransactionQuery" (authored by epriestley).
Provide missing "AlmanacInterfaceTransactionQuery"
Nov 16 2021, 7:48 PM
epriestley requested review of D21726: Provide missing "AlmanacInterfaceTransactionQuery".
Nov 16 2021, 7:47 PM

Nov 15 2021

epriestley added a comment to T13654: Wind Down Phacility Operations.

I'm planning to simply delete the Discourse forum without preserving any content.

Nov 15 2021, 4:22 PM · Phacility