Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F13527578: D21740.id51811.diff
Fri, Jul 26, 5:33 PM
Unknown Object (File)
Tue, Jul 23, 3:03 AM
Unknown Object (File)
Mon, Jul 22, 2:49 AM
Unknown Object (File)
Fri, Jul 19, 4:25 AM
Unknown Object (File)
Wed, Jul 10, 1:40 AM
Unknown Object (File)
Tue, Jul 9, 4:50 AM
Unknown Object (File)
Sun, Jul 7, 4:47 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.