Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F15315896: D21740.id51812.diff
Thu, Mar 6, 6:14 PM
Unknown Object (File)
Wed, Feb 26, 9:27 AM
Unknown Object (File)
Sat, Feb 22, 5:07 PM
Unknown Object (File)
Wed, Feb 19, 1:45 PM
Unknown Object (File)
Wed, Feb 19, 1:45 PM
Unknown Object (File)
Wed, Feb 19, 1:44 PM
Unknown Object (File)
Thu, Feb 13, 5:41 PM
Unknown Object (File)
Feb 3 2025, 3:15 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.