Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F15573584: D21740.diff
Mon, May 5, 9:17 PM
F15567434: D21740.id51812.diff
Fri, May 2, 6:18 AM
F15551721: D21740.diff
Sun, Apr 27, 6:09 PM
F15526302: D21740.diff
Mon, Apr 21, 8:33 PM
F15498239: D21740.id51811.diff
Sun, Apr 13, 12:23 PM
F15485827: D21740.diff
Thu, Apr 10, 2:47 AM
F15484599: D21740.id51812.diff
Wed, Apr 9, 7:10 PM
F15482928: D21740.id51811.diff
Wed, Apr 9, 8:41 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.