Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 26, 7:34 AM
Unknown Object (File)
Sat, May 10, 6:56 AM
Unknown Object (File)
Fri, May 9, 7:32 PM
Unknown Object (File)
Thu, May 8, 4:47 PM
Unknown Object (File)
Tue, May 6, 2:39 PM
Unknown Object (File)
Mon, May 5, 9:17 PM
Unknown Object (File)
Fri, May 2, 6:18 AM
Unknown Object (File)
Apr 27 2025, 6:09 PM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.