Page MenuHomePhabricator

Correct some Arcanist behaviors under PHP8.1
ClosedPublic

Authored by epriestley on Dec 9 2021, 8:46 PM.
Tags
None
Referenced Files
F19659890: D21740.diff
Sat, Feb 7, 1:59 AM
F19659889: D21740.diff
Sat, Feb 7, 1:59 AM
F19632699: D21740.diff
Thu, Feb 5, 5:16 AM
F19612605: D21740.diff
Tue, Feb 3, 7:24 PM
F19562624: D21740.id51812.diff
Sat, Jan 31, 2:46 PM
F19092995: D21740.id51812.diff
Dec 3 2025, 7:15 PM
F18945560: D21740.diff
Nov 11 2025, 6:30 PM
F18855730: D21740.id.diff
Nov 1 2025, 6:26 AM
Subscribers
None

Details

Summary

Ref T13588. See that task for discussion.

Improve behavior under PHP8.1, particularly the deprecation warning raised by calling strlen(null).

Test Plan
  • Ran arc help, arc branches, arc diff, etc., under PHP 8.1 and PHP 7.4.
  • Created this change with PHP8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2021, 9:44 PM
This revision was automatically updated to reflect the committed changes.