Page MenuHomePhabricator

Provide additional Arcanist PHP 8.1 fixes
ClosedPublic

Authored by epriestley on Dec 10 2021, 12:21 AM.
Tags
None
Referenced Files
F14484329: D21742.diff
Tue, Dec 31, 2:46 AM
Unknown Object (File)
Sat, Dec 21, 12:32 PM
Unknown Object (File)
Sat, Dec 21, 4:04 AM
Unknown Object (File)
Fri, Dec 20, 5:52 PM
Unknown Object (File)
Thu, Dec 19, 3:56 PM
Unknown Object (File)
Sat, Dec 14, 4:15 PM
Unknown Object (File)
Fri, Dec 13, 6:35 AM
Unknown Object (File)
Tue, Dec 10, 6:46 PM
Subscribers
None

Details

Summary

Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.

Test Plan

Ran various arc workflows under PHP 8.1.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Fix unit tests and a handful of other errors.
  • Also fix service profiler test case.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 10 2021, 12:42 AM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.