Paths

Table of Contentst

Provide additional Arcanist PHP 8.1 fixes
b50a646a3f49
Actions

Description

Provide additional Arcanist PHP 8.1 fixes

Summary: Ref T13588. I pointed my local php at PHP 8.1 and this is what I've hit so far; all these cases seem very unlikely to have any subtle behavior.

Test Plan: Ran various arc workflows under PHP 8.1.

Maniphest Tasks: T13588

Differential Revision: https://secure.phabricator.com/D21742

Details

Provenance

epriestley	Authored on Dec 9 2021, 11:57 PM
epriestley	Pushed on Dec 10 2021, 12:42 AM

Differential Revision

D21742: Provide additional Arcanist PHP 8.1 fixes

Parents

rARC488f13a60e88: Add a lint rule forbidding use of "each()"

Branches

Unknown

Tags

Unknown

Tasks

T13588: PHP 8 Compatibility

Build Status

Buildable 25611
Build 35427: Run Core Tests

Event Timeline

epriestley committed rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes (authored by epriestley).Dec 10 2021, 12:42 AM

epriestley added a task: T13588: PHP 8 Compatibility.

epriestley added an edge: D21742: Provide additional Arcanist PHP 8.1 fixes.

Harbormaster completed building B25611: rARCb50a646a3f49: Provide additional Arcanist PHP 8.1 fixes.Dec 10 2021, 12:42 AM

epriestley mentioned this in 2021 Week 50 (Mid December).Dec 11 2021, 3:47 PM

Changes (21)

Path

Size

src/

configuration/

ArcanistConfigurationManager.php

filesystem/

PhutilDirectoryFixture.php

future/

exec/

ExecFuture.php

lint/

linter/

ArcanistXMLLinter.php

__tests__/

ArcanistLinterTestCase.php

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

ArcanistParentMemberReferenceXHPASTLinterRule.php

ArcanistSelfMemberReferenceXHPASTLinterRule.php

parser/

ArcanistBundle.php

ArcanistDiffParser.php

PhutilBugtraqParser.php

PhutilEmailAddress.php

PhutilURI.php

aast/

api/

AASTNodeList.php

serviceprofiler/

PhutilServiceProfiler.php

unit/

renderer/

ArcanistUnitConsoleRenderer.php

utils/

PhutilArray.php

PhutilCallbackFilterIterator.php

workflow/

ArcanistDiffWorkflow.php

ArcanistWorkflow.php

support/

lib/

extract-symbols.php

rARCb50a646a3f49

View Options

src/configuration/ArcanistConfigurationManager.php

View Options

src/filesystem/PhutilDirectoryFixture.php

View Options

src/future/exec/ExecFuture.php

View Options

src/lint/linter/ArcanistXMLLinter.php

View Options

src/lint/linter/tests/ArcanistLinterTestCase.php

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistParentMemberReferenceXHPASTLinterRule.php

View Options

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

View Options

src/parser/ArcanistBundle.php

View Options

src/parser/ArcanistDiffParser.php

View Options

src/parser/PhutilBugtraqParser.php

View Options

src/parser/PhutilEmailAddress.php

View Options

src/parser/PhutilURI.php

View Options

src/parser/aast/api/AASTNodeList.php

View Options

src/serviceprofiler/PhutilServiceProfiler.php

View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

View Options

src/utils/PhutilArray.php

View Options

src/utils/PhutilCallbackFilterIterator.php

View Options

src/workflow/ArcanistDiffWorkflow.php

View Options

src/workflow/ArcanistWorkflow.php

View Options

support/lib/extract-symbols.php

Provide additional Arcanist PHP 8.1 fixesb50a646a3f49Actions

Description

Details

Event Timeline

Changes (21)

rARCb50a646a3f49

src/configuration/ArcanistConfigurationManager.php

src/filesystem/PhutilDirectoryFixture.php

src/future/exec/ExecFuture.php

src/lint/linter/ArcanistXMLLinter.php

src/lint/linter/__tests__/ArcanistLinterTestCase.php

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistParentMemberReferenceXHPASTLinterRule.php

src/lint/linter/xhpast/rules/ArcanistSelfMemberReferenceXHPASTLinterRule.php

src/parser/ArcanistBundle.php

src/parser/ArcanistDiffParser.php

src/parser/PhutilBugtraqParser.php

src/parser/PhutilEmailAddress.php

src/parser/PhutilURI.php

src/parser/aast/api/AASTNodeList.php

src/serviceprofiler/PhutilServiceProfiler.php

src/unit/renderer/ArcanistUnitConsoleRenderer.php

src/utils/PhutilArray.php

src/utils/PhutilCallbackFilterIterator.php

src/workflow/ArcanistDiffWorkflow.php

src/workflow/ArcanistWorkflow.php

support/lib/extract-symbols.php

Provide additional Arcanist PHP 8.1 fixes
b50a646a3f49
Actions

src/lint/linter/tests/ArcanistLinterTestCase.php