meminfo"
ClosedPublic
Actions

Authored by epriestley on Nov 22 2021, 1:30 PM.

Details

Reviewers: None
Maniphest Tasks: T13653: After an AWS event, Phacility hosts may come up with swap only partially configured
Commits: rARC59b273fd15d3: (stable) Promote 2021 Week 49
rARCc23222438b30: (stable) Provide an API for parsing swap information from "/proc/meminfo"
rARCc53bb21bbd3e: Provide an API for parsing swap information from "/proc/meminfo"

Summary

Ref T13653. This entirely exists to support converging into the right swap state in deployment workflows.

Test Plan

Ran unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Nov 22 2021, 1:30 PM

Harbormaster completed remote builds in B25585: Diff 51791.Nov 22 2021, 1:30 PM

epriestley requested review of this revision.Nov 22 2021, 1:30 PM

Satisfy lint by catching and re-throwing Throwable.

It would be slightly more appropriate for this class to throw a more tailored exception, but I don't think there's a suitable existing exception and this already feels very heavy for its actual use case.

Harbormaster completed remote builds in B25586: Diff 51792.Nov 22 2021, 1:32 PM

This overlaps somewhat with PhutilSystem::getSystemMemoryInformation(), but that mechanism is narrower and also doesn't really work in practice, so it would probably be reasonable to remove it entirely.

This revision was not accepted when it landed; it landed in state Needs Review.Nov 22 2021, 1:45 PM

Closed by commit rARCc53bb21bbd3e: Provide an API for parsing swap information from "/proc/meminfo" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCc53bb21bbd3e: Provide an API for parsing swap information from "/proc/meminfo".

epriestley added a commit: rARCc23222438b30: (stable) Provide an API for parsing swap information from "/proc/meminfo".

epriestley added a commit: rARC59b273fd15d3: (stable) Promote 2021 Week 49.Dec 1 2021, 9:22 PM