Page MenuHomePhabricator

Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
ClosedPublic

Authored by epriestley on Dec 16 2021, 11:07 PM.

Details

Summary

Ref T13588. This configuration value may not be set.

Also fix an issue in bin/storage and whatever else I hit between now and this diff actually uploading.

Also fix a MySQLi report mode difference, beginning in PHP 8.1.

Also update a bunch of "static" property usage in Lisk.

Test Plan

Ran bin/files ... locally under PHP 8.1.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Add annotations for interfaces implemented by PhabricatorHandleList.
  • Fix a strlen() in query construction.
  • Correct behavior in query clause construction.
  • Fix a piece of user initializing code for PHP 8.1.
  • Fix a PHP 8.1 issue in user querying.
  • Fix a PHP 8.1 check in local disk storage engine code.
  • Fix a PHP 8.1 issue in application search code.
  • Fix another random PHP 8.1 issue.
This revision was not accepted when it landed; it landed in state Needs Review.Dec 16 2021, 11:24 PM
This revision was automatically updated to reflect the committed changes.