Page MenuHomePhabricator
Feed Advanced Search

Sep 2 2016

epriestley added a revision to T11577: Initializing databases for the first time while already in cluster mode fails: Restricted Differential Revision.
Sep 2 2016, 3:08 PM · Clusters, Bug Report
epriestley added a comment to T11577: Initializing databases for the first time while already in cluster mode fails.

A bad half-fix for this is here:

Sep 2 2016, 3:01 PM · Clusters, Bug Report
epriestley renamed T11577: Initializing databases for the first time while already in cluster mode fails from Create db schema in cluster mode to Initializing databases for the first time while already in cluster mode fails.
Sep 2 2016, 2:56 PM · Clusters, Bug Report
epriestley added a comment to T11577: Initializing databases for the first time while already in cluster mode fails.

I can reproduce this. Fixing it will take a bit of work.

Sep 2 2016, 2:56 PM · Clusters, Bug Report
aubort created T11577: Initializing databases for the first time while already in cluster mode fails.
Sep 2 2016, 2:34 PM · Clusters, Bug Report
epriestley closed T11576: Typo at calendar transaction as Resolved.

Resolved by D16488.

Sep 2 2016, 1:19 PM · Calendar, Bug Report
Luke081515.2 added a revision to T11576: Typo at calendar transaction: Restricted Differential Revision.
Sep 2 2016, 1:12 PM · Calendar, Bug Report
Luke081515.2 created T11576: Typo at calendar transaction.
Sep 2 2016, 12:59 PM · Calendar, Bug Report
epriestley reopened T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags" as "Open".
Sep 2 2016, 12:24 PM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

We have a parser for comment docblocks, used to generate documentation and extract metadata from source code. This is a docblock:

Sep 2 2016, 12:24 PM · Bug Report
epriestley renamed T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags" from phutil_symbols.php fails when parsing docblocks specifying external symbols to Make PhutilDocblockParser always return arrays when parsing "@doc-tags".
Sep 2 2016, 12:20 PM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

I'm going to retarget this to make the API more consistent.

Sep 2 2016, 12:19 PM · Bug Report
yelirekim closed T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags" as Resolved by committing Restricted Diffusion Commit.
Sep 2 2016, 12:05 PM · Bug Report
epriestley added a revision to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags": Restricted Differential Revision.
Sep 2 2016, 11:53 AM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

We should probably change this API to always return array(), the "sometimes array, sometimes scalar" return value is pretty unintuitive. And any code which fixed this by adding (array) will just work.

Sep 2 2016, 11:51 AM · Bug Report
epriestley closed T11573: Phabricator goes down with minimal load due to asset delivery issue for some users as Resolved.

I'm going to close this for now since there's no more upstream action available given that the issue either no longer reproduces or disabling APCu appears to fix it and be a reasonable workaround.

Sep 2 2016, 11:38 AM · Bug Report
epriestley added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

Yeah, I think this didn't crop up sooner through a combination of the cache and there being relatively few files with multiple @phutil-external-symbol tags.

Sep 2 2016, 11:20 AM · Bug Report
yelirekim added a comment to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".

I'm not sure how this wasn't reported earlier, I guess the module cache prevented everyone from encountering it?

Sep 2 2016, 5:01 AM · Bug Report
yelirekim added a revision to T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags": Restricted Differential Revision.
Sep 2 2016, 4:58 AM · Bug Report
yelirekim created T11575: Make PhutilDocblockParser always return arrays when parsing "@doc-tags".
Sep 2 2016, 4:51 AM · Bug Report

Sep 1 2016

thoughtpolice added a comment to T11270: PHP 7 does not reasonably support asynchronous signal handling until `async_signals` lands.

FWIW, PHP 7.1.0 RC1 was released today, and it includes the async signal change. The following amended script from T11270#184087 seems to work:

Sep 1 2016, 11:36 PM · Daemons, Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

We don't really use APCu for very much, so if you are able to isolate it as the issue (or are just suspicious, e.g. based on that launchpad bug looking pretty similar) it's probably OK to turn it off. I'd expect you to lose something like 5% performance with it off, not 50%+.

Sep 1 2016, 9:41 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Just some quick googling revealed this issue with a prior version of APCu.

Sep 1 2016, 9:35 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I turned it back on and ran additional load tests but Apache was able to handle everything. To be honest, I was surprised how well the site held up with APCu turned off. The numbers are about the same.

Sep 1 2016, 9:32 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

If you turn APCu back on, does it freeze up again?

Sep 1 2016, 8:42 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've been running load tests for the past 2-3 hours and for some reason, I can't bring it down anymore. You can probably mark this bug as 'unable to reproduce'. I'll continue looking into the issue and see if there's a definitive way to reproduce.

Sep 1 2016, 8:36 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I'm not immediately sure about the daemon confusion, although I suspect it's not likely to be a hint at the root issue. Caching for setup issues falls back to some pretty whacky shenanigans with APC/APCu disabled.

Sep 1 2016, 7:08 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

That's probably a webhook URI configured in feed.http-hooks (which may no longer be configured).

Sep 1 2016, 7:05 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've started the load tests without APC. One odd item I didn't notice before that may or may not be related is that Phabricator is having a hard time knowing that daemons are running (e.g. you have 2 unresolved setup issues instead of just 1 because APC is turned off). I checked the daemon logs and see they are flooded with this with one entry occurring a lot. I can't track down the source because I don't know what address it's trying to reach out to (is this a repository pull or a herald rule?). Again, this may be completely unrelated and a different issue all together.

Sep 1 2016, 6:59 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I don't see anything interesting in Multimeter, it just shows that the host doesn't see much traffic and that we probably need to update some package definitions.

Sep 1 2016, 6:40 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Are you running APC (Config → Cache Status shows APC as the active "Data Cache")?

If so, can you reproduce it if you disable APC (apc.enabled=0 in php.ini), restart apache, verify that no "Data Cache" is available any more in Config → Cache Status, and then use the takedown script?

Sep 1 2016, 6:36 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Here's the output. I removed "events" from some of them to improve formatting.

Sep 1 2016, 6:33 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Are you running APC (Config → Cache Status shows APC as the active "Data Cache")?

Sep 1 2016, 6:29 PM · Bug Report
jessjohnson added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

I've added a simple javascript file on the installation I grabbed this report from. As part of the troubleshooting process, I installed a vanilla installation of Phabricator on a separate machine with no modifications (version referenced in the bug report) and was able to reproduce the problem.

Sep 1 2016, 6:24 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

Also, can you show me what these pages look like?

Sep 1 2016, 6:23 PM · Bug Report
epriestley added a comment to T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.

GET /res/phabricator/86668b8e/rsrc/js/phui/rdar.js HTTP/1.1

Sep 1 2016, 6:20 PM · Bug Report
jessjohnson created T11573: Phabricator goes down with minimal load due to asset delivery issue for some users.
Sep 1 2016, 6:12 PM · Bug Report
epriestley added a comment to T11572: Herald Rule not inheriting Object policy from Project in a way I understand.

This is a bug with how relative/object policies and inherited/indirect policies interact.

Sep 1 2016, 4:39 PM · Bug Report
ephemeris created T11572: Herald Rule not inheriting Object policy from Project in a way I understand.
Sep 1 2016, 4:33 PM · Bug Report
andl added a comment to T11570: `arc patch` download empty binary file from hosted svn repository.

looks like a duplicate of T8647

Sep 1 2016, 2:34 PM · Arcanist, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay, thank you for the pointers, we have indeed a huge performance improvement using standard mysql replication, which seems to increase the queue usage.

Sep 1 2016, 2:32 PM · Diffusion, Bug Report
epriestley added a project to T11547: Paste query results do not display actual length of listed Pastes (but always "5 lines" if Paste is longer): Contributor Onboarding.
Sep 1 2016, 2:29 PM · Contributor Onboarding, Paste, Bug Report
epriestley closed T11568: Daemons queue usage is low leading to slow imports as Resolved.

I'm going to close this for now since I don't plan to take any further action as the upstream; this appears to be an environmental issue (which we don't offer support for) rather than a scalability limitation (which we do).

Sep 1 2016, 2:21 PM · Diffusion, Bug Report
epriestley added a comment to T11570: `arc patch` download empty binary file from hosted svn repository.

I've just dumped this on the pile of arc patch-related bugs. Some of them are likely duplicates, possibly including this one, but I don't expect to dig through that pile until the next major iteration on arc, since at least some of them are likely not addressable without other changes. T11429 has a rough overview of upcoming plans.

Sep 1 2016, 2:12 PM · Arcanist, Bug Report
epriestley moved T11570: `arc patch` download empty binary file from hosted svn repository from Backlog to arc patch on the Arcanist board.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
epriestley added a project to T11570: `arc patch` download empty binary file from hosted svn repository: Arcanist.
Sep 1 2016, 2:08 PM · Arcanist, Bug Report
andl created T11570: `arc patch` download empty binary file from hosted svn repository.
Sep 1 2016, 11:18 AM · Arcanist, Bug Report
benjumanji added a comment to T10456: Conduit interprets all arguments from curl requests as strings.
params="                                                                                                                                                                                   
    {                                                                                                                                                                                      
        \"buildTargetPHID\": \"$PHID\",                                                                                                                                                    
        \"artifactKey\": \"jenkins.uri.$PHID\",                                                                                                                                            
        \"artifactType\": \"uri\",                                                                                                                                                         
        \"artifactData\": {                                                                                                                                                                
            \"uri\": \"http://build:8080/job/$JOB_NAME/$BUILD_NUMBER\",                                                                                                                    
            \"name\": \"Jenkins Build\",                                                                                                                                                   
            \"ui.external\": true                                                                                                                                                          
        },                                                                                                                                                                                 
        \"__conduit__\": { \"token\": \"$CONDUIT_API_TOKEN\" }                                                                                                                             
    }"
Sep 1 2016, 9:25 AM · Restricted Project, Conduit, Bug Report

Aug 31 2016

donaldguy added a comment to T10456: Conduit interprets all arguments from curl requests as strings.

if it helps anyone, the workaround "fix" is to place the following code in the file "src/applications/conduit/parametertype/ConduitBoolParameterType.php "

$value = (boolean) $value;

at about line 9 just before the following piece of code:

if (!is_bool($value)) {

Its a bit of a hack, so I'm not sure how much to trust this workaround for a production instance of Phabricator, but hopefully, it helps someone out there. The issue is (I think) basically related to http://stackoverflow.com/questions/27446946/preserve-data-type-of-post-fields-when-sending-data-using-php-and-curl where PHP converts the curl input as a string.

Aug 31 2016, 11:15 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

I'm not entirely sure, but it seems plausible. We compute "Queue Utilization" as basically:

Aug 31 2016, 10:43 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay, seems bad indeed, do you think it might explain why the queue is capped at 20-30% ?

Aug 31 2016, 10:18 PM · Diffusion, Bug Report
avivey placed T10746: Aborted build in Harbormaster still shows as building in Diffusion up for grabs.

"Failed builds show as building" is actually very different from "Aborted builds show as building". Handling the Aborting one is a more involved than I'd like to dig into right now.

Aug 31 2016, 9:38 PM · Restricted Project, Harbormaster, Bug Report
avivey added a revision to T10746: Aborted build in Harbormaster still shows as building in Diffusion: Restricted Differential Revision.
Aug 31 2016, 9:29 PM · Restricted Project, Harbormaster, Bug Report
avivey claimed T10746: Aborted build in Harbormaster still shows as building in Diffusion.
Aug 31 2016, 9:23 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.
...
13. >>> [4] <query> INSERT INTO `daemon_log` ...
14. <<< [4] <query> 870,858 us
...
Aug 31 2016, 8:46 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Yes, here it is.

Aug 31 2016, 8:38 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Okay. Can you run this command?

Aug 31 2016, 8:00 PM · Diffusion, Bug Report
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

Ah yes sorry, I saw some other reference to Nuance today and thought it was for that.

Aug 31 2016, 7:31 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Oh, no, this is the right task. Your logs:

Aug 31 2016, 6:45 PM · Diffusion, Bug Report
avivey renamed T11567: Allow dashes in monospace font preferences from Allow dashes in monospace font to Allow dashes in monospace font preferences.
Aug 31 2016, 5:52 PM · Contributor Onboarding, User Preferences
aubort added a comment to T11568: Daemons queue usage is low leading to slow imports.

I think you may have answered to the wrong task :)

Aug 31 2016, 5:29 PM · Diffusion, Bug Report
epriestley added a comment to T11568: Daemons queue usage is low leading to slow imports.

Someone has configured a bad Nuance source, so let's start by fixing that.

Aug 31 2016, 5:09 PM · Diffusion, Bug Report
chad added a project to T11568: Daemons queue usage is low leading to slow imports: Diffusion.
Aug 31 2016, 4:54 PM · Diffusion, Bug Report
chad added a project to T11567: Allow dashes in monospace font preferences: User Preferences.
Aug 31 2016, 4:54 PM · Contributor Onboarding, User Preferences
aubort updated the task description for T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:57 PM · Diffusion, Bug Report
aubort updated the task description for T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:51 PM · Diffusion, Bug Report
aubort created T11568: Daemons queue usage is low leading to slow imports.
Aug 31 2016, 3:47 PM · Diffusion, Bug Report
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

The reason we suggest @ as a delimiter is that you don't have to escape forward slashes if you use a delimiter other than /, so you get a more readable regexp.

Aug 31 2016, 2:31 PM · Herald, Documentation
MattSeen added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

I think I'm going insane. I was wrangling with that for ages and as you pointed out /\.js$/ does in fact work. I have no idea how I did every permutations of that regex except that one.

Aug 31 2016, 1:38 PM · Herald, Documentation
epriestley added a comment to T11567: Allow dashes in monospace font preferences.

I believe this is fine; I can't immediately come up with an attack using -.

Aug 31 2016, 12:35 PM · Contributor Onboarding, User Preferences
• jgdye created T11567: Allow dashes in monospace font preferences.
Aug 31 2016, 12:30 PM · Contributor Onboarding, User Preferences
epriestley added a comment to T11566: Provide more complete guidance on using regular expressions in Herald.

Form (1) is expected to work, which is why we don't document a need for form (7): one is not expected to exist. If form (1) does not work, this is a bug with Herald itself, not with the Herald documentation.

Aug 31 2016, 12:25 PM · Herald, Documentation
MattSeen updated the task description for T11566: Provide more complete guidance on using regular expressions in Herald.
Aug 31 2016, 11:33 AM · Herald, Documentation
MattSeen created T11566: Provide more complete guidance on using regular expressions in Herald.
Aug 31 2016, 11:32 AM · Herald, Documentation

Aug 30 2016

epriestley added a comment to T11565: Typo in Harbormaster User Guide.

Thanks for the report. This should be fixed in HEAD of master, and fixed in production some time in the next 24 hours when the docs regenerate.

Aug 30 2016, 9:22 PM · Documentation, Bug Report
epriestley closed T11565: Typo in Harbormaster User Guide as Resolved by committing Restricted Diffusion Commit.
Aug 30 2016, 9:09 PM · Documentation, Bug Report
epriestley added a revision to T11565: Typo in Harbormaster User Guide: Restricted Differential Revision.
Aug 30 2016, 8:57 PM · Documentation, Bug Report
epriestley claimed T11565: Typo in Harbormaster User Guide.
Aug 30 2016, 8:55 PM · Documentation, Bug Report
kocsenc created T11565: Typo in Harbormaster User Guide.
Aug 30 2016, 8:33 PM · Documentation, Bug Report
epriestley closed T11562: New as Spite.
Aug 30 2016, 5:22 PM · Bug Report
• abelardo6 created T11562: New .
Aug 30 2016, 5:21 PM · Bug Report
shuLhan renamed T11560: Inconsistent field "name" between maniphest.edit parameter and maniphest.search response from Inconsistent field "name" between maniphest.edit parameter and manifest.search response to Inconsistent field "name" between maniphest.edit parameter and maniphest.search response.
Aug 30 2016, 3:20 PM · Conduit, Bug Report
shuLhan updated the task description for T11560: Inconsistent field "name" between maniphest.edit parameter and maniphest.search response.
Aug 30 2016, 3:18 PM · Conduit, Bug Report
shuLhan added a project to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter: Conduit.
Aug 30 2016, 2:47 PM · Restricted Project, Conduit, Bug Report
shuLhan created T11560: Inconsistent field "name" between maniphest.edit parameter and maniphest.search response.
Aug 30 2016, 2:44 PM · Conduit, Bug Report
jcox closed T10951: Search shows document types corresponding to disabled apps as Resolved.

Macro dancingpeople:

Aug 30 2016, 1:48 PM · Contributor Onboarding, Search, Bug Report

Aug 29 2016

epriestley added a comment to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.

Not yet, but soon. New code should use project.edit.

Aug 29 2016, 6:03 PM · Restricted Project, Conduit, Bug Report
shuLhan added a comment to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.

Did the project.create API deprecated?

Aug 29 2016, 6:02 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11482: Build a changeset cache for Diffusion to improve move/copy detection behvaior.

T10423 was resolved indirectly (in connection with T11524) so we've sort of inched forward here.

Aug 29 2016, 5:57 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.

Try using project.edit instead.

Aug 29 2016, 5:52 PM · Restricted Project, Conduit, Bug Report
epriestley added a parent task for T10635: Loading differential revision slow when lots of unit test messages exist: T11402: Garbage collect and/or compress/archive harbormaster build unit messages.
Aug 29 2016, 4:35 PM · Restricted Project, Haskell.org, Harbormaster, Performance
lucaro added a comment to T11548: 500 Internal Server Error when trying to clone HG repo via https.

du -sh returns 1.3GB for that repository so it should be below that limit.

Aug 29 2016, 3:59 PM · Bug Report
shuLhan added a revision to T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter: Restricted Differential Revision.
Aug 29 2016, 12:04 PM · Restricted Project, Conduit, Bug Report
epriestley added a comment to T11548: 500 Internal Server Error when trying to clone HG repo via https.

This is almost certainly T4369. I would expect that this repository is larger than 2GB?

Aug 29 2016, 10:58 AM · Bug Report
epriestley merged task T11548: 500 Internal Server Error when trying to clone HG repo via https into T4369: Phabricator HTTP repository hosting has fairly severe scalability limits.
Aug 29 2016, 10:57 AM · Bug Report
epriestley closed T11549: sdefrgthzuioö as Invalid.
Aug 29 2016, 10:56 AM · Bug Report
shuLhan updated the task description for T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.
Aug 29 2016, 10:50 AM · Restricted Project, Conduit, Bug Report
shuLhan updated the task description for T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.
Aug 29 2016, 10:38 AM · Restricted Project, Conduit, Bug Report
shuLhan created T11551: Conduit API "project.create" return error with ERR-CONDUIT-CORE when only "name" passed as parameter.
Aug 29 2016, 10:31 AM · Restricted Project, Conduit, Bug Report
ivo added a subtask for T11362: Arcanist tries to land onto identical remote branch instead of 'master': T11535: Make it possible for arc land to disable upstream branch tracking.
Aug 29 2016, 10:09 AM · Arcanist, Bug Report