Page MenuHomePhabricator
Feed Advanced Search

Aug 8 2016

epriestley added a comment to T11371: Restore PHP to Glory.

(Just so no one thinks too highly of me, I'll underscore that I very briefly peaked at #11. I think I had slid to about #35,000 by the end of the lightning round and "-∞ dumpster garbage rank" by the end of the competition.)

Aug 8 2016, 10:48 PM · Public & Media Relations
epriestley added a comment to T11371: Restore PHP to Glory.

Sadly, I didn't win ICFP with PHP this year. I got up to #11 (just 33,600 points from the top slot!) but had to go to a meeting in the morning:

Aug 8 2016, 8:04 PM · Public & Media Relations
michaeljs1990 awarded T11371: Restore PHP to Glory a Love token.
Aug 8 2016, 8:01 PM · Public & Media Relations
yelirekim awarded T11371: Restore PHP to Glory a Y So Serious token.
Aug 8 2016, 7:27 PM · Public & Media Relations
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

When you click the pencil icon next to the "Hierarchy" item, you get to a page like this one:

Aug 8 2016, 5:33 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

(I'm hoping there's no real use case for "show some other arbitrary page's navigation", although who knows.)

Aug 8 2016, 5:30 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I'm hoping to get away with two options, e.g. a checkbox like this:

Aug 8 2016, 5:29 PM · Phriction, Restricted Project
epriestley added a comment to T11439: Retrieve Diff PHID via phid.lookup.

I found that the overhead of managing herald + harbormaster was much higher than our previous setup and was causing friction getting folks to adopt phabricator for new projects

Aug 8 2016, 4:49 PM · Feature Request
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

Yeah -- the specific change I'd expect is basically that this:

Aug 8 2016, 4:43 PM · Phriction, Restricted Project
epriestley closed T7783: phriction diffs don't default to remarkup as Wontfix.

These use the prose algorithm now, and I don't plan to try to implement syntax highlighting for prose diffs.

Aug 8 2016, 4:36 PM · Remarkup, Phriction
epriestley closed T7783: phriction diffs don't default to remarkup, a subtask of T9379: Build Phriction v3, as Wontfix.
Aug 8 2016, 4:36 PM · Phriction
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I think both are about 95% equivalent, my version ("a Hierarchy is a single menu item") is just easier for me to do from an engineering viewpoint and the other version I'd have to think about for a while before I could even guess how much work it is. I think the simpler-to-implement version is a bit more flexible/powerful too, although maybe not quite as intuitive at first glance.

Aug 8 2016, 4:34 PM · Phriction, Restricted Project
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

The shortest path on the nav is probably something slightly more directly porting Profile Menu editing:

Aug 8 2016, 4:31 PM · Phriction, Restricted Project
epriestley moved T9379: Build Phriction v3 from Preflight to The Queue on the Prioritized board.
Aug 8 2016, 4:22 PM · Phriction
epriestley added a project to T9379: Build Phriction v3: Prioritized.
Aug 8 2016, 4:21 PM · Phriction
epriestley added a comment to T7773: Allow code reviews across multiple repos.

We will almost certainly never support diffs coming from multiple different repository sources. They can't be built, can't be updated, can't be patched, can't be meaningfully interdiffed, local commits are meaningless, can't be atomically landed, and they basically don't make sense in general.

Aug 8 2016, 4:04 PM · Restricted Project, Differential
epriestley added a comment to T11439: Retrieve Diff PHID via phid.lookup.

Can you walk me through your workflow in more detail? The expectation is:

Aug 8 2016, 3:56 PM · Feature Request
epriestley edited projects for T11440: Drafts for unsaved objects, added: EditEngine; removed Maniphest.
Aug 8 2016, 3:54 PM · EditEngine, Feature Request
epriestley renamed T11440: Drafts for unsaved objects from draft for new tasks to Drafts for unsaved objects.
Aug 8 2016, 3:54 PM · EditEngine, Feature Request
epriestley triaged T11440: Drafts for unsaved objects as Wishlist priority.

This is nice in theory, but I suspect it may be very complex to implement in practice.

Aug 8 2016, 3:53 PM · EditEngine, Feature Request
epriestley added a comment to T11440: Drafts for unsaved objects.

(I've destroyed the token compromised earlier in this thread.)

Aug 8 2016, 3:34 PM · EditEngine, Feature Request

Aug 7 2016

epriestley reopened T11439: Retrieve Diff PHID via phid.lookup as "Open".
Aug 7 2016, 7:02 PM · Feature Request
epriestley closed T11437: Provide a usable UI for configuring header logos, a subtask of T11096: Redesign main header / quick create / search, as Resolved.
Aug 7 2016, 7:00 PM · Design
epriestley closed T11437: Provide a usable UI for configuring header logos as Resolved by committing Restricted Diffusion Commit.
Aug 7 2016, 7:00 PM · Config
epriestley added a revision to T11437: Provide a usable UI for configuring header logos: Unknown Object (Differential Revision).
Aug 7 2016, 6:52 PM · Config
epriestley closed T11439: Retrieve Diff PHID via phid.lookup as Resolved.

Try differential.querydiffs.

Aug 7 2016, 12:54 PM · Feature Request

Aug 6 2016

epriestley added a comment to T4245: Make repository URIs slightly prettier.

How would we distinguish between source/android/browse/carafe/ being "browse branch carafe of repository android" vs "browse the home page of repository carafe located at path android/browse/" in such a scheme?

Aug 6 2016, 9:56 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
epriestley renamed T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL from MySQL database backup produces warning on Ubuntu 16.04.1 to MySQL "-p<password>" flag produces a warning in recent versions of MySQL.
Aug 6 2016, 9:46 PM · Bug Report
epriestley edited the content of Changelog.
Aug 6 2016, 9:43 PM
epriestley created 2016 Week 32 (Early August).
Aug 6 2016, 9:43 PM
epriestley closed T7939: Support Herald rules for Calendar events as Resolved by committing Restricted Diffusion Commit.
Aug 6 2016, 9:37 PM · Herald, Calendar
epriestley closed T7939: Support Herald rules for Calendar events, a subtask of T7926: Modernize Calendar Infrastructure, as Resolved.
Aug 6 2016, 9:37 PM · Calendar
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

This document may also be helpful in scripting Phabricator commands:

Aug 6 2016, 9:06 PM · Bug Report
epriestley added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

The Aug 19 2015 reply from James Day in https://bugs.mysql.com/bug.php?id=66546 gives me some hope that MySQL may adjust behavior here. Although that comment is now almost a year old, it responds to a comment from about two and a half years prior, so this may actually be fairly new in MySQL timescales.

Aug 6 2016, 8:53 PM · Bug Report
epriestley triaged T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL as Wishlist priority.
Aug 6 2016, 8:48 PM · Bug Report
epriestley reopened T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL as "Open".

I think this is the corresponding MySQL bug:

Aug 6 2016, 8:48 PM · Bug Report
epriestley added a comment to T11438: Separate paid user count by pricing plan subgroup in Phacility statistics.

We can limit the number of instances, but I think the big question we want to answer is how many free instnaces convert to paying instances over some long period of time.

Aug 6 2016, 5:28 PM · Phacility
epriestley added a comment to T11432: Ability to exclude self ("Current Viewer") from Feed panels.

I think this is reasonable to pursue, but I'd like to put the capability at the ApplicationSearch level rather than making it specific to one field in Feed -- basically, provide not(user) and not-viewer() or typeahead functions (or similar functions with better names).

Aug 6 2016, 4:19 PM · Feed, Feature Request
epriestley closed T11438: Separate paid user count by pricing plan subgroup in Phacility statistics as Wontfix.

Cool. We can build this later for "free tier trial" if we do that, since we would definitely make different decisions based on the data then (0% conversion = don't do it, 100% conversion = ship it immediately, somewhere in the middle = run the numbers or whatever).

Aug 6 2016, 4:17 PM · Phacility
epriestley added a comment to T11438: Separate paid user count by pricing plan subgroup in Phacility statistics.

Oh, I can skip it if you aren't too concerned about it, it just came up and I didn't want to forget about it. I think it's like 10 minutes of work, but I'm perfectly happy to not do that work too. I don't think having this data would change any decisions I'd make, at least, even if the data showed extreme results:

Aug 6 2016, 4:12 PM · Phacility
epriestley created T11438: Separate paid user count by pricing plan subgroup in Phacility statistics.
Aug 6 2016, 4:04 PM · Phacility
epriestley added a comment to T11435: arc land doesn't work if visual diff tool is configured.

I think this should be fixed in HEAD of master now. It should promote to stable pretty shortly, probably. Let us know if you're still seeing issues after updating, and thanks for the report!

Aug 6 2016, 4:00 PM · Arcanist, Bug Report
epriestley closed T11435: arc land doesn't work if visual diff tool is configured as Resolved by committing Restricted Diffusion Commit.
Aug 6 2016, 4:00 PM · Arcanist, Bug Report
epriestley added a comment to T11435: arc land doesn't work if visual diff tool is configured.

I'd theoretically be open to doing that kind of thing, but I worry it would waste a lot of our time in arguing over whether or not something is really a good bug report or not. We already see a lot of this with our security bounty program and the definition of a valid report there is very narrow.

Aug 6 2016, 2:23 PM · Arcanist, Bug Report
epriestley created T11437: Provide a usable UI for configuring header logos.
Aug 6 2016, 2:10 PM · Config
epriestley added a revision to T11435: arc land doesn't work if visual diff tool is configured: Unknown Object (Differential Revision).
Aug 6 2016, 1:41 PM · Arcanist, Bug Report
epriestley added a comment to T11435: arc land doesn't work if visual diff tool is configured.

I think we already add this flag in most cases (via ArcanistGitAPI->getDiffBaseOptions()), but the specific check in arc land doesn't go through that code (since it doesn't really care about the diff, just if the are any changes at all).

Aug 6 2016, 1:37 PM · Arcanist, Bug Report
epriestley moved T11435: arc land doesn't work if visual diff tool is configured from Backlog to vNext on the Arcanist board.
Aug 6 2016, 1:26 PM · Arcanist, Bug Report
epriestley closed T11436: fdsa as Spite.
Aug 6 2016, 1:22 PM · Feature Request

Aug 5 2016

rdohms awarded T731: Allow revisions to have alternate acceptance conditions a Like token.
Aug 5 2016, 9:43 AM · Restricted Project, Restricted Project, Differential
epriestley added a project to T4245: Make repository URIs slightly prettier: Prioritized.
Aug 5 2016, 12:01 AM · Prioritized, Diffusion (v3), KDE, Restricted Project

Aug 4 2016

epriestley closed T11431: ./bin/* files don't seem to be valid executables as Resolved.

Cool -- I don't think we can really detect this because we don't have an opportunity to run any code to check for it. We could possibly have the web UI run a setup check, but I think we get about 1 of these a year and it's reasonably likely that users try to run bin/* before hitting the web UI anyway. If you have any ideas about how we could have caught/prevented this, let us know.

Aug 4 2016, 10:27 PM · Bug Report (Needs Information)
epriestley added a comment to T11431: ./bin/* files don't seem to be valid executables.

They should be symlinks. As git represents both symlinks and the executable flag, it should be unnecessary to chmod them.

Aug 4 2016, 7:22 PM · Bug Report (Needs Information)
epriestley merged T11430: Add PyLint3 to Arcanist Linters into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Aug 4 2016, 6:41 PM · Lint, Arcanist
epriestley merged task T11430: Add PyLint3 to Arcanist Linters into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Aug 4 2016, 6:41 PM · Lint, Arcanist, Feature Request
epriestley added a comment to T11371: Restore PHP to Glory.

ICFP2016 starts in about 6 hours:

Aug 4 2016, 6:16 PM · Public & Media Relations
epriestley created an object: C146: ICFP Contest 2016.
Aug 4 2016, 6:08 PM
epriestley added a comment to T8145: Support global/broadcast notifications.

(Possibly it might be easier to select the correct audience in Phabricator since you can use projects or other rules, but all of the use cases here and elsewhere just want to hit everyone, I think.)

Aug 4 2016, 5:32 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.

Yeah, basically like the Facebook Rooster system except making it act as "pinned notifications" instead of "pinned dashboard panels". We could do either, reasonably, although it's slightly messier to do a real-time notification of "a new panel appeared on all dashboards, go look". But I'm basically not sure why this is better than email in any case where the users are employees.

Aug 4 2016, 5:30 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.

I think a global banner (or some equally omnipresent, persistent element) is reasonable for "this system is going down in a couple of minutes". But if that's the only really good use case we have for it, though, I wonder if we shouldn't just build a "shutdown in X minutes" feature that automatically does this, counts down, stops new batch jobs from starting, maybe pauses builds, puts the system into read-only when the countdown finishes, etc. -- a dedicated "graceful shutdown" feature instead of just a broadcast feature. I don't think any of these things are really problems today, but I could imagine more of a "shutdown process" being useful in the future.

Aug 4 2016, 5:27 PM · Notifications
johnny-bit awarded T11428: Upcoming: Personal Herald Rules No Longer Semi-Private a Like token.
Aug 4 2016, 4:54 PM · Policy, Installing & Upgrading, Herald
epriestley added a comment to T11427: Banner/MOTD/way to display a persistent message on all pages?.

Yeah, agreed. I added a little discussion to T8145.

Aug 4 2016, 4:52 PM · Feature Request
epriestley updated subscribers of T8145: Support global/broadcast notifications.

@bjshively, for this use case:

Aug 4 2016, 4:49 PM · Notifications
epriestley added a comment to T8145: Support global/broadcast notifications.
  • T11427 is similar.
  • T10855 discusses a similar and possibly overlapping use case (mirroring system status into Phabricator), but I believe that use case isn't after global/on-all-pages notifications.
Aug 4 2016, 4:44 PM · Notifications
epriestley renamed T8145: Support global/broadcast notifications from Send notification from command line? to Support global/broadcast notifications.
Aug 4 2016, 4:37 PM · Notifications
epriestley added a comment to T11427: Banner/MOTD/way to display a persistent message on all pages?.

T8145 is also related, and maybe a little closer to intent here. I can retarget that.

Aug 4 2016, 4:35 PM · Feature Request
epriestley created T11429: Upcoming: Changes to Arcanist.
Aug 4 2016, 4:07 PM · Public & Media Relations, Installing & Upgrading, Arcanist
epriestley added a comment to T9410: Policy behavior for Herald rules is murky and inconsistent.

T11428 puts the corporate communication wheels in motion to make this change.

Aug 4 2016, 3:23 PM · Restricted Project, Herald, Restricted Project
epriestley added a subtask for T11428: Upcoming: Personal Herald Rules No Longer Semi-Private: T9410: Policy behavior for Herald rules is murky and inconsistent.
Aug 4 2016, 3:20 PM · Policy, Installing & Upgrading, Herald
epriestley added a parent task for T9410: Policy behavior for Herald rules is murky and inconsistent: T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.
Aug 4 2016, 3:20 PM · Restricted Project, Herald, Restricted Project
epriestley created T11428: Upcoming: Personal Herald Rules No Longer Semi-Private.
Aug 4 2016, 3:16 PM · Policy, Installing & Upgrading, Herald
epriestley moved T9410: Policy behavior for Herald rules is murky and inconsistent from Backlog to Next on the Herald board.
Aug 4 2016, 2:59 PM · Restricted Project, Herald, Restricted Project
epriestley added a comment to T11391: Unable to add uri to Diffusion.

Update past rPa5b26104 (Jul 9).

Aug 4 2016, 2:51 PM · Bug Report (Needs Information), Diffusion
epriestley closed T11391: Unable to add uri to Diffusion as Invalid.

Closing this since we haven't seen a response for about a week, this report didn't follow the instructions by omitting version information, and it's very likely that this is resolved by updating.

Aug 4 2016, 2:40 PM · Bug Report (Needs Information), Diffusion
epriestley closed T11424: Differential inline comments (their positions) are misleading after new diff as Resolved.

Yeah, T7447 is probably the best source of discussion about this.

Aug 4 2016, 1:10 AM · Bug Report

Aug 3 2016

epriestley closed T11420: Stable sort project tags in query results as Resolved by committing Restricted Diffusion Commit.
Aug 3 2016, 11:46 PM · Projects, Feature Request
epriestley added a revision to T7939: Support Herald rules for Calendar events: Unknown Object (Differential Revision).
Aug 3 2016, 11:46 PM · Herald, Calendar
epriestley added a comment to T11420: Stable sort project tags in query results.

D16367 make the order consistent (instead of reversed) in the task list view and on workboard cards.

Aug 3 2016, 11:20 PM · Projects, Feature Request
epriestley added a revision to T11420: Stable sort project tags in query results: Unknown Object (Differential Revision).
Aug 3 2016, 11:16 PM · Projects, Feature Request
epriestley closed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess as Resolved by committing Restricted Diffusion Commit.
Aug 3 2016, 11:12 PM · Documentation, Herald
epriestley closed T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess, a subtask of T7939: Support Herald rules for Calendar events, as Resolved.
Aug 3 2016, 11:12 PM · Herald, Calendar
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I think this is a perfectly reasonable capability to want in the general case, I just want to make sure that this isn't a big fancy solution to a problem that could also be solved by checking a checkbox or making a one-line change to the build or whatever. Definitely possible that most Jenkins users are just doing very basic stuff with it, though.

Aug 3 2016, 6:16 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

I'm not super familiar with Jenkins -- what makes this job require parameters in the body? Other users seem to be using Jenkins successfully without requiring this capability on the Phabricator side, as far as I know.

Aug 3 2016, 6:05 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

Ah, that one's easier.

Aug 3 2016, 6:00 PM · Restricted Project, Harbormaster
epriestley added a comment to T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).

@eadler, does your use case need a fancy content type like application/json, or just plain old www-url-normal-web-form-encoded?

Aug 3 2016, 5:32 PM · Restricted Project, Harbormaster
epriestley merged T11422: support sending a body in harbormaster build steps into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Aug 3 2016, 5:30 PM · Restricted Project, Harbormaster
epriestley merged task T11422: support sending a body in harbormaster build steps into T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Aug 3 2016, 5:30 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T11420: Stable sort project tags in query results.

I don't think this is a sort stability issue: we're preserving the order which the user who entered the tags originally used (in this particular UI it looks like we actually use reverse order, which I'd consider a bug, but other UIs like the "Tags" in the rightmost column and when editing the tags via "Edit Task" we use the original order).

Aug 3 2016, 3:09 PM · Projects, Feature Request
epriestley added a member for Blessed Committers: fooishbar.
Aug 3 2016, 2:45 PM
epriestley added a member for Community: fooishbar.
Aug 3 2016, 2:45 PM

Aug 2 2016

epriestley added a comment to T10915: Allow story points to just be task count.

Just to be completely sure I understand this:

Aug 2 2016, 9:39 PM · Restricted Project, Feature Request
epriestley merged task T11417: Update Diff title and summary when commit message is changed into T2386: When users edit commit message information and run "arc diff" without --verbatim, warn them.
Aug 2 2016, 8:42 PM · Feature Request
epriestley merged T11417: Update Diff title and summary when commit message is changed into T2386: When users edit commit message information and run "arc diff" without --verbatim, warn them.
Aug 2 2016, 8:42 PM · Restricted Project, Arcanist
epriestley added a comment to T11417: Update Diff title and summary when commit message is changed.

You can use --verbatim to cause this update.

Aug 2 2016, 8:42 PM · Feature Request
epriestley added a comment to T10915: Allow story points to just be task count.

Just to clarify, workboard columns with a limit should currently show text like this in the header:

Aug 2 2016, 8:36 PM · Restricted Project, Feature Request
epriestley closed T11403: Phabricator hosted git repositories appear to error with 'failed to push some refs' without any error detail.. as Resolved.

If you can identify why sudo was broken and what you did to fix it, we can probably add a setup warning to test for this problem. However, since we haven't seen other users with broken sudo and we couldn't help users resolve the issue with available information even if we did detect it, I don't think pursuing a check in the upstream is worthwhile.

Aug 2 2016, 6:18 PM · Diffusion, Bug Report
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

(You can't write "Run Build Plans: ..." personal rules, but you can write them in object rules, which isn't too much different.)

Aug 2 2016, 4:02 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

It's also probably bad/inconsistent that you can run builds via Herald which you could not run via the web UI.

Aug 2 2016, 4:00 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

I have mixed feelings about relaxing this. I think there are basically two parts to this:

Aug 2 2016, 3:57 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess: Unknown Object (Differential Revision).
Aug 2 2016, 3:32 PM · Documentation, Herald