Page MenuHomePhabricator
Create Task
Maniphest T11424

Differential inline comments (their positions) are misleading after new diff
Closed, ResolvedPublic
Actions

Description

I expect this is a deliberate choice, but why do we keep inline comments after a new diff is pushed even though they are not on the right lines (and therefore confusing)?

Related Objects

Event Timeline

venky created this task.Aug 4 2016, 12:55 AM
avivey added a subscriber: avivey.Aug 4 2016, 1:01 AM

There's lots of discussion about this in T7447 and related T1460.

epriestley closed this task as Resolved.Aug 4 2016, 1:10 AM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

Yeah, T7447 is probably the best source of discussion about this.

You can disable this behavior in Settings → Diff Preferences if you'd prefer not to bring inlines forward.

Phabricator · Built by Phacility