Page MenuHomePhabricator
Feed Advanced Search

Mar 22 2016

epriestley renamed T10642: Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS from Search experience is not useable on Amazon RDS to Default search boolean logic is mildly inconvenient and not configurable in Amazon RDS.
Mar 22 2016, 1:11 AM · Search, Bug Report
epriestley renamed T10640: Allow application queries to be promoted as global search modes from Expose advanced maniphest search filters in main search to Allow application queries to be promoted as global search modes.
Mar 22 2016, 1:10 AM · Search, Feature Request
epriestley triaged T10640: Allow application queries to be promoted as global search modes as Wishlist priority.

These fields don't apply to other document types, and other document types have other fields which do apply to these results. It does not make sense to search all documents by, e.g., "Priorities". We definitely aren't going to pursue this as described.

Mar 22 2016, 1:10 AM · Search, Feature Request
epriestley updated subscribers of T8646: Provide more context for search results, particularly wiki documents.
Mar 22 2016, 12:58 AM · Design, Search, Restricted Project
epriestley merged task T10641: show same visual detailing on tasks in "all documents" search as is shown in maniphest search into T8646: Provide more context for search results, particularly wiki documents.
Mar 22 2016, 12:58 AM · Feature Request
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 22 2016, 12:40 AM · Nuance (v1)
epriestley added a comment to T10638: A Task can end up on a Milestone workboard column without being in that Milestone.

T10486 is related; T6027 and T5214 are somewhat related.

Mar 22 2016, 12:10 AM · Projects (v3), Bug Report

Mar 21 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 21 2016, 6:42 PM · Nuance (v1)
epriestley changed the status of T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines from Invalid to Resolved by committing Restricted Diffusion Commit.
Mar 21 2016, 6:24 PM · Remarkup, Bug Report
epriestley added a revision to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Unknown Object (Differential Revision).
Mar 21 2016, 6:21 PM · Remarkup, Bug Report
epriestley added a comment to Q347: task hierarchy template.

T7190 has discussion of a similar case.

Mar 21 2016, 6:07 PM · Maniphest
epriestley closed T10634: sorenalara as Spite.
Mar 21 2016, 5:06 PM · Feature Request
epriestley moved T10633: Render timezones explicitly in email from Backlog to Unprototype (v1) on the Calendar board.
Mar 21 2016, 4:41 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a project to T10633: Render timezones explicitly in email: Calendar.

I think this isn't tremendously important for Countdown but should definitely be sorted out before we unbeta Calendar.

Mar 21 2016, 4:41 PM · Calendar, Mail, Countdown, Bug Report
epriestley added a comment to T10633: Render timezones explicitly in email.

It might not be bad to always show timezones in email explicitly to deal with cases related to T3025 better (e.g., you fly to the east coast for a conference, get prompted to reconcile your timezone after T3025, and it may not be obvious that this also affects mail you receive until you return and re-reconicle back to PST).

Mar 21 2016, 4:15 PM · Calendar, Mail, Countdown, Bug Report
epriestley triaged T10633: Render timezones explicitly in email as Wishlist priority.

With metamta.one-mail-per-recipient on, we can adjust this to the viewer's preferences.

Mar 21 2016, 4:13 PM · Calendar, Mail, Countdown, Bug Report

Mar 20 2016

avivey awarded T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential a Doubloon token.
Mar 20 2016, 6:45 PM · Restricted Project, Differential
epriestley added a comment to T1258: Add an "Automatically CC Owners on Differential Revisions" checkbox to Owners.

I also may just restore this at some point to align with user expectation, even though I think it's a bad feature and we benefited on the balance from removing it.

Mar 20 2016, 5:20 PM · Restricted Project, Owners
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

T1258 might be another attack on this, not sure how much that overlaps things.

Mar 20 2016, 5:18 PM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

We have a large, and growing, set of teams that would like to get CCed whenever a review is created in a repository they work in.

Mar 20 2016, 5:12 PM · Restricted Project, Herald, Feature Request
chad awarded T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential a Piece of Eight token.
Mar 20 2016, 3:22 PM · Restricted Project, Differential
epriestley added a comment to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

Yeah, pretty much the same for me. I believe "Open Revisions" has a small population of fans and "Local Commits" may get more useful eventually (e.g., after whatever happens with T1508) but I think we're on fairly firm ground shoving these into tabs.

Mar 20 2016, 12:55 PM · Restricted Project, Differential
epriestley added a comment to T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.

I spent some time on this, but this ends up being more involved than I thought because there's a lot of weirdness around how actions and property lists interact, so this is probably blocked on making all UIs which use property list tabs and actions switch to the two column view.

Mar 20 2016, 12:23 PM · Restricted Project, Differential
epriestley added a comment to T5214: Add Conduit API methods for workboards.

To provide some context, until recently, the API was in bad shape. Basically, the first time we wrote an application we'd maybe write some application.whatever methods, which shared some code with the rest of the application but not all of it, and then the API and application wouldn't always get changed in the same way. This resulted in methods like repository.create which can do maybe 20% of what the web UI can, does it in different, inconsistent ways, and edits made by the API might look or work differently than web UI edits. In bad cases, they'd even do different policy/permissions checks. This caused many many problems for a very long time.

Mar 20 2016, 12:10 PM · Restricted Project, Conduit, Maniphest, Workboards
epriestley added a comment to T5214: Add Conduit API methods for workboards.

Changes like T10569 should probably happen first. This is likely to be very complex, and is probably not a good task for a new contributor.

Mar 20 2016, 11:15 AM · Restricted Project, Conduit, Maniphest, Workboards
epriestley closed T10565: Make Phriction articles accessible via version control or arc as Invalid.

This request doesn't describe a root problem and we don't seem to be making progress toward one, so we can't move forward on it.

Mar 20 2016, 10:09 AM · Phriction, Feature Request
epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

No, we're not open to implementing this as multiple separate select controls. We don't really have a UI in mind that we're happy with, but we have several we're less unhappy with than multiple select controls (leading contenders: single optgrouped select, alternate actions menu for workboard actions; possible contenders: visual table-layout control, select per-project in a dialog).

Mar 20 2016, 10:07 AM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a comment to T10621: Create projects from external thing (extension to T3980).

How do you imagine Phabricator learning about the existence of new external groups? Just polling a list of every group in LDAP every hour or whatever?

Mar 20 2016, 9:38 AM · Restricted Project, Restricted Project, LDAP, Projects, Feature Request
epriestley added a comment to T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.

Like T10622, I think this is reasonable to expose as an extensible behavior, but it should wait for T10329 so we have better tools to support it.

Mar 20 2016, 9:30 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10622: Auto add reviewers based on custom logic.

I think this is generally reasonable but would like it to happen after T10329 (roughly, "proper extension infrastructure for arc"), when we'll have the tools we need to better manage versioning and deploying client changes.

Mar 20 2016, 9:29 AM · Restricted Project, Arcanist, Feature Request
epriestley added a comment to T10623: Allow Herald actions to reference conditions.

Can you describe the root problem? What kind of rules are these? Revision rules?

Mar 20 2016, 9:28 AM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10619: Permit custom harbormaster actions from the diffusion/differential pages.

You can already do some of this: "Land Revision" itself is added to the menu via DifferentialLandingActionMenuEventListener. You can use listeners like this to extend the menu.

Mar 20 2016, 9:22 AM · Restricted Project, Diffusion, Differential, Harbormaster, Feature Request

Mar 19 2016

ofbeaton awarded T1139: Internationalize Phabricator a Like token.
Mar 19 2016, 11:36 PM · Localization
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I've updated D14284 + D14286 + D14288 for the new API and rebased them onto modern code.

Mar 19 2016, 10:51 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

It seems that tag builds do not support build_parameters. We need to pass parameters, so this is blocked on them again.

Mar 19 2016, 10:46 PM · Restricted Project, Harbormaster
epriestley added a comment to T7789: Support Git Large File Storage.
  • Once D15499 lands, this is available as a prototype.
Mar 19 2016, 8:20 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 19 2016, 6:11 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

According to CircleCI this really truly works now, so I'll see if I can push our integration forward shortly.

Mar 19 2016, 1:36 PM · Restricted Project, Harbormaster
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

I renewed the certificate and launched a new VPC load balancer, which can forward port 22 traffic:

Mar 19 2016, 1:35 PM · Phacility, Ops
epriestley added a comment to T10629: Rotate the `secure.phabricator.com` SSL certificate.

We use secure.phabricator.com for both HTTP/HTTPS and SSH traffic and ELB can't currently forward port 22 -- except the docs now say EC2-VPC LBs can? So I need to figure out what's going on with that.

Mar 19 2016, 1:00 PM · Phacility, Ops
epriestley edited the content of Changelog.
Mar 19 2016, 12:35 PM
epriestley created 2016 Week 12 (Late March).
Mar 19 2016, 12:34 PM
epriestley created T10629: Rotate the `secure.phabricator.com` SSL certificate.
Mar 19 2016, 12:29 PM · Phacility, Ops
epriestley removed a watcher for Arcanist: • stephane.chaperot.
Mar 19 2016, 2:33 AM
epriestley added a parent task for T10329: Implement internal workflows / a build engine in Arcanist: T10622: Auto add reviewers based on custom logic.
Mar 19 2016, 2:31 AM · Restricted Project, Arcanist
epriestley added a subtask for T10622: Auto add reviewers based on custom logic: T10329: Implement internal workflows / a build engine in Arcanist.
Mar 19 2016, 2:31 AM · Restricted Project, Arcanist, Feature Request
epriestley added a subtask for T10620: Support complex mappings from branch names to JIRA/Maniphest tasks: T10329: Implement internal workflows / a build engine in Arcanist.
Mar 19 2016, 2:30 AM · Restricted Project, Arcanist, Feature Request
epriestley added a parent task for T10329: Implement internal workflows / a build engine in Arcanist: T10620: Support complex mappings from branch names to JIRA/Maniphest tasks.
Mar 19 2016, 2:30 AM · Restricted Project, Arcanist
epriestley created T10628: Merge "Local Commits" and "Open Revisions Affecting These Files" into tabs on "Revision Update History" in Differential.
Mar 19 2016, 2:28 AM · Restricted Project, Differential
epriestley closed T9788: config/versions page - also show dates of commits as Resolved.

I think the remaining part was "show a lot more versions of different things", but I can't immediately think of cases where that would have helped us resolve something faster.

Mar 19 2016, 2:11 AM · Config
epriestley added a comment to T4188: Put expires headers on js/css/img on dotorg.

CORGI will fix this and clearly it is too hard for me.

Mar 19 2016, 2:02 AM · Public & Media Relations

Mar 18 2016

epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

That one worked OK, yell if you're still seeing an issue?

Mar 18 2016, 11:02 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Test: User Guide: Prototype Applications

Mar 18 2016, 11:02 PM · Phurl, Bug Report
epriestley closed T10625: Links like "((prototype))" are not expanded properly in email as Resolved by committing Restricted Diffusion Commit.
Mar 18 2016, 11:00 PM · Phurl, Bug Report
epriestley added a revision to T10625: Links like "((prototype))" are not expanded properly in email: Unknown Object (Differential Revision).
Mar 18 2016, 10:59 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Oh -- I misunderstood. The issue isn't that we're getting invalid markup or emitting markup in a text context, but that the link is relative.

Mar 18 2016, 10:51 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

This is probably very easy to fix, let me spend 3 seconds on it.

Mar 18 2016, 10:49 PM · Phurl, Bug Report
epriestley added a comment to T10625: Links like "((prototype))" are not expanded properly in email.

Yes, Phurl provides URL shortening. U10 is the root object providing ((prototype)).

Mar 18 2016, 10:48 PM · Phurl, Bug Report
chad awarded T7789: Support Git Large File Storage a Haypence token.
Mar 18 2016, 6:24 PM · Customer Impact, Restricted Project, Files, Diffusion
avivey awarded T7789: Support Git Large File Storage a Mountain of Wealth token.
Mar 18 2016, 5:25 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

The technically-functional-prototype code is live on this install, now:

Mar 18 2016, 4:46 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 3:44 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley reopened T10618: Prevent duplicate notifications about blocking tasks as "Open".

This isn't really the same as T7013 or T9161. T7013 was intended as a pure infrastructure optimization, I just named it really badly. And even if we had the fanciest rules imaginable, T9161 wouldn't help, because this case is currently unknowable.

Mar 18 2016, 3:38 PM · Restricted Project, Maniphest, Feature Request
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Sorry, I picked a really bad name for it originally.

Mar 18 2016, 3:31 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

This task has nothing to do with any user-visible behavior and is purely a performance/network optimization, despite all the discussion about batching emails here. :)

Mar 18 2016, 3:27 PM · Aphlict, Conpherence
epriestley renamed T7013: Support bulk transmission of notification frames in internal Aphlict protocol from Support message batching in the notification pipeline to Support bulk transmission of notification frames in internal Aphlict protocol.
Mar 18 2016, 3:27 PM · Aphlict, Conpherence
epriestley added a comment to T10589: Create useable search experience for Maniphest.

You can use the default syntax (+x +y) to perform an AND search explicitly. See:

Mar 18 2016, 3:23 PM · Feature Request
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

(There is also a different type of cache from <object hash -> metadata> we could build in Git, but that's kind of a lot of work.)

Mar 18 2016, 2:43 PM · Diffusion, Bug Report
epriestley added a comment to T10614: Images in Diffusion don't register as such in BrowseTable.

In SVN, we can use a different icon because we have prebuilt cache of file types (and must have this cache for other reasons, and can build this cache efficiently, and SVN distinguishes between binary and text files).

Mar 18 2016, 2:40 PM · Diffusion, Bug Report
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 2:25 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T9987: Diffs in a task should be sorted by the dependency tree.

Please tell me if you would merge this improvement if we implement it.

Mar 18 2016, 2:09 PM · Maniphest, Feature Request
epriestley added a comment to T7789: Support Git Large File Storage.

Quick update:

Mar 18 2016, 1:42 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 18 2016, 1:27 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 18 2016, 1:27 PM · Diffusion (v3), Restricted Project
epriestley edited the content of Organizations Using Phabricator.
Mar 18 2016, 1:19 PM
epriestley changed the visibility for Organizations Using Phabricator.
Mar 18 2016, 1:19 PM
epriestley added a revision to T10604: Allow application code to stream request data: Unknown Object (Differential Revision).
Mar 18 2016, 12:05 PM · Diffusion (v3), Restricted Project
ivo awarded T10034: Plan the future of Maniphest task relationships a Like token.
Mar 18 2016, 9:59 AM · Maniphest
epriestley added a comment to T7789: Support Git Large File Storage.

One issue which we'll hit eventually is that git-lfs doesn't currently support pushing to remotes by URL, but we push to staging areas by URL:

Mar 18 2016, 1:27 AM · Customer Impact, Restricted Project, Files, Diffusion

Mar 17 2016

epriestley added a comment to T6027: Way to edit which column a task is in from the task itself.

Is there any chance that this feature will be implemented sometime soon?

Mar 17 2016, 10:16 PM · Restricted Project, Prioritized, Restricted Project, Mobile, Workboards, Maniphest
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 17 2016, 8:33 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley created T10617: Improve raw-PHID remarkup rules.
Mar 17 2016, 7:48 PM · Remarkup
epriestley added a comment to T7789: Support Git Large File Storage.

No way for the upload API to say "no thanks, I already have that file"?

Mar 17 2016, 6:49 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

Why are users who shouldn't be changing priorities doing it?

Mar 17 2016, 6:06 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T6502: Policy to define who can move cards in a workboard.

See T10333 for plans to make dragging cards in sorted workboards more clear (and T8135 for additional discussion). Those UIs aren't as clear as they should be and we'd like them to be more clear.

Mar 17 2016, 4:54 PM · Projects, Wikimedia, Policy, Workboards
epriestley added a comment to T10611: No option to specify a Space when editing a Project's visibility policy.

"project" there just the noun, not "Project-object", but we could probably pick a different word to avoid ambiguity.

Mar 17 2016, 4:22 PM · Projects, Restricted Project, Feature Request, Spaces
epriestley added a comment to T7789: Support Git Large File Storage.

Quick progress update:

Mar 17 2016, 3:41 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

D15483 changes the constant to 47 (15 window size + 32 for gzip + zlib), which should accept and decode the broadest possible range of inputs. If this somehow breaks something, 31 (15 window size + 16 for gzip only) is probably the next thing to try. See that change for discussion.

Mar 17 2016, 3:34 PM · Bug Report, Diffusion
epriestley added a comment to T10610: ExecFuture does not kill child processes on timeout.

This is probably a variant on T4551.

Mar 17 2016, 3:00 PM · libphutil, Bug Report
epriestley added a comment to T10609: Add @username style typeahead search to other node types .

For searching across all types of everything, I lean toward adding an "Insert object reference..." button to the header which pops up a search box (similar to the "Edit Blocking Tasks" box) instead of trying to trigger on {T... and such. I think this is a lot friendlier for new users, and we'll have a bit more room to let you filter/customize the query, and this operation is probably not so common that it needs to be triggered on a whim inline. For power users, we could maybe add a keystroke (say, Ctrl/Alt + @) or something so you didn't need to actually click the button.

Mar 17 2016, 1:20 PM · Feature Request

Mar 16 2016

epriestley removed a watcher for Infrastructure: • 9999999999.
Mar 16 2016, 10:58 PM
epriestley updated the task description for T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 16 2016, 10:49 PM · Infrastructure
epriestley renamed T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates from missing index on repository_pathchange table to Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.
Mar 16 2016, 10:46 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Here's a diff to make bin/storage adjust always run ANALYZE on every table after it makes other adjustments, but I'm not really sure if that's actually helpful or not (e.g., from the documentation, it sounds like the good analysis can be immediately overwritten by a bad one in some cases?):

Mar 16 2016, 10:01 PM · Infrastructure
epriestley added a revision to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates: Unknown Object (Differential Revision).
Mar 16 2016, 9:50 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

I think so. Sorry for the originally misleading claim.Sorry for the originally misleading claim.

Mar 16 2016, 9:48 PM · Infrastructure
epriestley added a comment to T10260: Harbormaster Herald Rules.

Oh, I might not have made subscribers actually do anything, I don't remember. They definitely should, though, even if they don't yet.

Mar 16 2016, 9:39 PM · Haskell.org, Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Well, the docs suggest not doing that:

Mar 16 2016, 9:29 PM · Infrastructure
epriestley added a comment to T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates.

Should we get rid of the <commitID, isDirect, changeType> key, then?

Mar 16 2016, 9:24 PM · Infrastructure
epriestley added a revision to T7789: Support Git Large File Storage: Unknown Object (Differential Revision).
Mar 16 2016, 7:49 PM · Customer Impact, Restricted Project, Files, Diffusion