Page MenuHomePhabricator
Feed Advanced Search

Jan 16 2016

epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That word stuff still has some weird/buggy results, I'll see if I can improve the behavior.

Jan 16 2016, 10:51 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Alright, all that stuff is hopefully fixed/improved now:

Jan 16 2016, 10:49 PM · Remarkup, Typeahead
epriestley added a comment to T10168: Provide a clearer pathway forward for old projects with invalid hashtags.

T10150 is probably describing the same issue, but this report is much more detailed.

Jan 16 2016, 10:41 PM · Projects, Bug Report
epriestley updated subscribers of T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
Jan 16 2016, 10:41 PM · Projects, Bug Report
epriestley merged task T10150: Project Tag Links work Intermitently into T10168: Provide a clearer pathway forward for old projects with invalid hashtags.
Jan 16 2016, 10:41 PM · Projects, Bug Report
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 10:37 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Restricted Differential Revision.
Jan 16 2016, 10:02 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:45 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:40 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 16 2016, 9:17 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 9:14 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Maybe we can do this:

Jan 16 2016, 8:20 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That'll break @evan danger priestley and #differential mobile unbeta. I don't really see a clean way to resolve that based on spaces-typed, since both human and project names may contain an arbitrary number of internal words. We could put some artificial cutoff (three words? maybe four or five for projects?) but I don't immediately see a way to write a rule that always does what you users want.

Jan 16 2016, 8:18 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Let's try the less-annoying way and see if it actually causes problems, it's definitely the behavior I would prefer personally.

Jan 16 2016, 8:14 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 8:04 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Do you think that's preferable? I think it's probably much better for experienced users, but I'm a little worried some users will type a #, sit there, then tell us it's broken if we do that.

Jan 16 2016, 8:02 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

We could also decline to pop the typeahead until the user types the first (valid) character. Currently we pop it on @ or # immediately to show the user that it's available and aid discovery, but it might be better to wait until they type one valid character before we pop it, so there wouldn't be a flash on cases of ##, etc.

Jan 16 2016, 7:59 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 16 2016, 7:58 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

Typeahead starts when preceded by ., -, (, |, #, @

Jan 16 2016, 7:57 PM · Remarkup, Typeahead
Luke081515.2 awarded Blog Post: Development Notes (2016 Week 3) a Like token.
Jan 16 2016, 7:07 PM
chad awarded T10166: Build a permanent destruction workflow for Phacility instances a The World Burns token.
Jan 16 2016, 4:06 PM · Phacility
epriestley added a comment to T7163: Convert Phacility file storage to use S3.

The second biggest source of storage pressure appears to be test instances that, e.g., imported the Linux Kernel and were then suspended. I've filed T10166 to follow up.

Jan 16 2016, 3:06 PM · Files, Phacility
epriestley created T10166: Build a permanent destruction workflow for Phacility instances.
Jan 16 2016, 3:06 PM · Phacility
epriestley added a comment to T7163: Convert Phacility file storage to use S3.

This is now available in the cluster, but the storage engine currently never selects it for new writes because MySQL is still configured to allow 8MB chunks. I'm going to selectively migrate some data, but probably not turn default writes on for a week or so.

Jan 16 2016, 2:42 PM · Files, Phacility
epriestley closed T10165: Differential syntax highlighting can't handle ES6 backtick strings as Resolved.

Pygments added support a couple of months ago but hasn't released a version with support yet. See:

Jan 16 2016, 2:44 AM · Bug Report
Luke081515.2 awarded T10054: Define product direction for Project/Profile UIs a Love token.
Jan 16 2016, 12:21 AM · Projects

Jan 15 2016

chad awarded Blog Post: Development Notes (2016 Week 3) a Like token.
Jan 15 2016, 8:29 PM
epriestley published Blog Post: Development Notes (2016 Week 3).
Jan 15 2016, 8:11 PM
epriestley added a comment to T10164: Clicking "Use Project Icon" 404's.

Oh, that probably didn't get updated for the new IconSet stuff.

Jan 15 2016, 8:02 PM · Bug Report, Projects
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 7:14 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 15 2016, 7:13 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

(1) is currently intentional -- I'm being pretty aggressive about throwing the prompt away, and dismiss it if you use "up" or "down" to get off the ends of the list, under the assumption those actions mean "throw this away, I hate it". I'm definitely open to changing those to just eat the inputs.

Jan 15 2016, 7:04 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

One thing I've done differently than, e.g., Facebook is that I've made summoning the completer explicit (when you type "@" or "#"), not implicit (when you position your cursor somewhere in something that looks like a username in the text).

Jan 15 2016, 6:05 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

That appears to be working better, now.

Jan 15 2016, 5:49 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:41 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:40 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 15 2016, 5:40 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.

I think my analysis of the blur thing wasn't quite right, I'm still getting intermittent success with clicking results. I'll dig into that a bit more.

Jan 15 2016, 5:35 PM · Remarkup, Typeahead
epriestley updated the task description for T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:33 PM · Remarkup, Typeahead
epriestley triaged T10163: Remarkup Autocomplete Errata as Normal priority.
Jan 15 2016, 5:33 PM · Remarkup, Typeahead
epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 15 2016, 5:32 PM · Remarkup, Typeahead
epriestley added a comment to T10163: Remarkup Autocomplete Errata.
In T10163#154221, @chad wrote:

If I type @demo and then tab it changes to @abuna

Jan 15 2016, 5:27 PM · Remarkup, Typeahead
epriestley closed T3725: Using keyword @ to address users does not autocomplete names as Resolved.

I'm going to call this resolved and move errata to T10163, since I assume most people on this task mostly just wanted to know when the feature landed.

Jan 15 2016, 5:21 PM · FreeBSD, User Delight, Remarkup
epriestley created T10163: Remarkup Autocomplete Errata.
Jan 15 2016, 5:20 PM · Remarkup, Typeahead
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

This is now live on this install.

Jan 15 2016, 5:18 PM · FreeBSD, User Delight, Remarkup
epriestley edited the content of Changelog.
Jan 15 2016, 5:08 PM
epriestley created 2016 Week 3 (Mid January).
Jan 15 2016, 5:08 PM
• joncalhoun awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Jan 15 2016, 4:56 PM · Workboards (v3), Restricted Project
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

T10161 is a case of another install that selected ElasticSearch without a specific reason, based on a general belief that it is better in some intangible way.

Jan 15 2016, 2:05 PM · Elasticsearch, Search
epriestley triaged T10161: Fulltext indexing produces invalid JSON documents in Elasticsearch as Wishlist priority.
Jan 15 2016, 2:04 PM · Elasticsearch, Bug Report
epriestley added a comment to T10161: Fulltext indexing produces invalid JSON documents in Elasticsearch.

See some general discussion in T9893, although this doesn't seem to be an ElasticSearch 2.0 issue.

Jan 15 2016, 2:04 PM · Elasticsearch, Bug Report
epriestley created Blog Post: Request for Cat Facts.
Jan 15 2016, 2:00 PM
epriestley updated the title for this countdown from to Diablo III: Season 5.
Jan 15 2016, 1:52 PM
epriestley added a comment to T10146: Surface lint failures in reviews for a given repository.

(I've made a private note about this elsewhere, if you work with @nipunn.)

Jan 15 2016, 1:44 PM · Diffusion, Feature Request
epriestley closed T8306: Understanding phd, memory limitations, elasticsearch index slowness as Invalid.

Just closing this since it's a huge fishing expedition that we can't help with, see Contributing Bug Reports and Support Resources.

Jan 15 2016, 1:36 PM · Elasticsearch
epriestley updated subscribers of T9893: Support ElasticSearch 2.0 - 5.1.
Jan 15 2016, 1:34 PM · Elasticsearch, Search
epriestley merged task T9889: Object selector dialog does not work in Elasticsearch 2.0 into T9893: Support ElasticSearch 2.0 - 5.1.
Jan 15 2016, 1:34 PM · Elasticsearch
epriestley added a comment to T10161: Fulltext indexing produces invalid JSON documents in Elasticsearch.

(Also: why are you using ElasticSearch instead of the default search?)

Jan 15 2016, 1:33 PM · Elasticsearch, Bug Report
epriestley added a comment to T10161: Fulltext indexing produces invalid JSON documents in Elasticsearch.

What version of ElasticSearch are you using?

Jan 15 2016, 1:33 PM · Elasticsearch, Bug Report
epriestley added a revision to T3725: Using keyword @ to address users does not autocomplete names: Unknown Object (Differential Revision).
Jan 15 2016, 1:22 PM · FreeBSD, User Delight, Remarkup
epriestley closed T10160: asdasd as Spite.
Jan 15 2016, 1:17 PM · Feature Request
epriestley closed T10159: asdadas as Spite.
Jan 15 2016, 1:17 PM · Bug Report
epriestley closed T10158: asdasd as Spite.
Jan 15 2016, 1:17 PM · Bug Report
epriestley removed a member for Applications: • lukaszm-rc.
Jan 15 2016, 1:17 PM
epriestley added a comment to T10157: Cleaning up arcanist cpplint.

Sure.

Jan 15 2016, 11:48 AM · Arcanist, Bug Report
epriestley added a comment to T10156: Add an ACL permission to authorize only few people to accept revisions.

Can you explain this problem in more detail? See Describing Root Problems.

Jan 15 2016, 11:48 AM · Feature Request
epriestley added a comment to T10155: Error when displaying a repository with only one empty commit.

Thanks, those reproduction instructions are clear and I expect it will be straightforward for us to reproduce and fix this.

Jan 15 2016, 11:47 AM · Diffusion, Bug Report
epriestley triaged T10155: Error when displaying a repository with only one empty commit as Wishlist priority.
Jan 15 2016, 11:45 AM · Diffusion, Bug Report
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

Yeah -- we may be able to cheat a bit on usernames (although "@Evan Priestley" should also work), but can't cheat on project completion with # since #build more pylons and #build more supply depots should retrieve different results despite having a shared, multi-word prefix.

Jan 15 2016, 5:06 AM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

Mostly, users have a huge number of ways to interact with text: cursor keys, mouse, home/end keys, keystrokes like Ctrl+A and Ctrl+E, cut, paste, all the mouse-driven varieties of cut/paste, context menu actions like spelling correct, shift + everything listed so far to select stuff, dragging selected text, and multi-keystroke character input for non-latin languages. Javascript provides only indirect ways to guess how the user has performed mutations of the textarea, so we have to reconstruct and/or guess about a lot of behavior.

Jan 15 2016, 4:37 AM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

This thing is going to have a decade of bugs.

Jan 15 2016, 4:23 AM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T3725: Using keyword @ to address users does not autocomplete names.

Screen Shot 2016-01-14 at 8.18.49 PM.png (236×516 px, 29 KB)

Jan 15 2016, 4:21 AM · FreeBSD, User Delight, Remarkup
epriestley added a comment to T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.

Yeah, completeness is definitely sufficient motivation if you're up for it.

Jan 15 2016, 3:12 AM · Documentation, Herald
epriestley awarded T3725: Using keyword @ to address users does not autocomplete names a The World Burns token.
Jan 15 2016, 3:02 AM · FreeBSD, User Delight, Remarkup
epriestley claimed T3725: Using keyword @ to address users does not autocomplete names.
Jan 15 2016, 3:02 AM · FreeBSD, User Delight, Remarkup
epriestley closed T10154: The link of project is invalid as Invalid.

This report does not include reproduction steps. We can't move forward on bugs we can't reproduce. See Contributing Bug Reports.

Jan 15 2016, 2:23 AM · Bug Report
• guayosr awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
Jan 15 2016, 12:19 AM · Workboards (v3), Restricted Project

Jan 14 2016

epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 14 2016, 10:35 PM · Projects
epriestley closed T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster as Resolved by committing Restricted Diffusion Commit.
Jan 14 2016, 9:36 PM · Phacility
epriestley added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

step1.png (1×1 px, 135 KB)

Jan 14 2016, 9:35 PM · Phacility
epriestley added a revision to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster: Unknown Object (Differential Revision).
Jan 14 2016, 9:31 PM · Phacility
epriestley added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

Oh, I'll make this editable in the cluster from the instances panel. Change will go out on Saturday morning (about 36 hours from now).

Jan 14 2016, 9:29 PM · Phacility
epriestley updated subscribers of T1591: Differential "buoyant" header has been temporarily disabled.
Jan 14 2016, 8:52 PM · Inline Comments, Differential
epriestley merged task T10153: As a reviewer I'd like to have the name of the current file I am reviewing stick to the top of the page so that I don't have to scroll up to see what file I am in. into T1591: Differential "buoyant" header has been temporarily disabled.
Jan 14 2016, 8:52 PM · Feature Request
epriestley added a comment to T10152: Allow uri.allowed-protocols to be configured in the Phacility cluster.

See uri.allowed-protocols in Config.

Jan 14 2016, 8:45 PM · Phacility
epriestley added a comment to T10151: Vulnerability Response: CVE-2016-0777/CVE-2016-0778.

A sufficient diagnostic test is apparently to complete any connection with ssh -v and observe no "Roaming not allowed by server" message in the output. Cluster hosts with the configuration fix pass this test.

Jan 14 2016, 6:59 PM · Security, Phacility
franshamk awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jan 14 2016, 6:00 PM · Workboards (v3), Restricted Project
epriestley added a comment to T10151: Vulnerability Response: CVE-2016-0777/CVE-2016-0778.

I've applied the configuration fix to all Phacility cluster hosts that initiate SSH connections to untrusted servers, so we should be in the clear.

Jan 14 2016, 5:21 PM · Security, Phacility
epriestley created T10151: Vulnerability Response: CVE-2016-0777/CVE-2016-0778.
Jan 14 2016, 5:01 PM · Security, Phacility
epriestley added a comment to T10150: Project Tag Links work Intermitently.

I'm not really sure what's going on. The limit on the slug column is 128 characters, and that project name is nowhere near that (we should raise a better error message than we do, but I'm not sure how you're hitting the issue in the first place).

Jan 14 2016, 4:45 PM · Projects, Bug Report
epriestley added a comment to T10150: Project Tag Links work Intermitently.

Can you show me the output of bin/storage adjust? (For now, decline to apply any changes it suggests.)

Jan 14 2016, 4:42 PM · Projects, Bug Report
epriestley added a comment to T10150: Project Tag Links work Intermitently.

Prior to T9551 (circa October 12), projects could generate with invalid hashtags, but I don't think these ever worked (at least, many of them definitely did not work).

Jan 14 2016, 4:02 PM · Projects, Bug Report
epriestley added a comment to T10150: Project Tag Links work Intermitently.

The original report in Q272 is almost certainly unrelated.

Jan 14 2016, 3:55 PM · Projects, Bug Report
epriestley added a comment to T10004: ApplicationEditor Errata.

I think T10116 may have fixed the "actions ignored" issue -- does it still reproduce for you after that?

Jan 14 2016, 3:22 PM · ApplicationEditor
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 14 2016, 3:18 PM · Projects
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 14 2016, 3:06 PM · Projects
michaeloa awarded T10118: regex for parsing severity codes in ArcanistCppLinter is wrong a Like token.
Jan 14 2016, 3:03 PM · Lint, Arcanist, Bug Report
epriestley closed T10118: regex for parsing severity codes in ArcanistCppLinter is wrong as Resolved.

Resolved by D15019.

Jan 14 2016, 3:00 PM · Lint, Arcanist, Bug Report
epriestley renamed T10118: regex for parsing severity codes in ArcanistCppLinter is wrong from regex in ArcanistCppLinter is wrong to regex for parsing severity codes in ArcanistCppLinter is wrong.
Jan 14 2016, 2:59 PM · Lint, Arcanist, Bug Report
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 14 2016, 2:54 PM · Projects