Page MenuHomePhabricator

Project Tag Links work Intermitently
Closed, DuplicatePublic

Assigned To
None
Authored By
DaveInTO
Jan 14 2016, 3:40 PM
Referenced Files
F1061400: Screen Shot 2016-01-14 at 11.48.29 AM.png
Jan 14 2016, 4:54 PM
F1061398: Screen Shot 2016-01-14 at 11.49.34 AM.png
Jan 14 2016, 4:54 PM
F1061392: Screen Shot 2016-01-14 at 10.35.11 AM.png
Jan 14 2016, 4:49 PM
F1061391: Screen Shot 2016-01-14 at 10.23.49 AM.png
Jan 14 2016, 4:49 PM
F1061393: Screen Shot 2016-01-14 at 10.39.37 AM.png
Jan 14 2016, 4:49 PM
F1061388: Screen Shot 2016-01-14 at 8.44.06 AM.png
Jan 14 2016, 4:45 PM
F1061374: Screen Shot 2016-01-14 at 10.23.49 AM.png
Jan 14 2016, 3:40 PM
F1061379: Screen Shot 2016-01-14 at 10.39.37 AM.png
Jan 14 2016, 3:40 PM

Description

This seems to affect only older projects that were created prior to an upgrade last week (Jan 6th).
Clicking on a Tag link from a task brings up a 404 page.

Seems a little tricky to reproduce.
I thought It might have to do with a : in the Project Name older projects they colon ends up as part of the link.

But newer projects it does.
Eg.

NZ PLA: Media Factory: Release 2016-01 (Backlog)

Tag Link becomes
/tag/nz_pla_media_factory_release_2016-01/

Older
NZ COR: platform.newzulu.com
Tag Link becomes
/tag/nz_cor:_platform.newzulu.com/

Removing the colon fixes it..
I went and re-added the colon and now I'm getting an error #1406: Data too long for column 'slug' at row 1
But earlier this morning removing the colon, and adding it back in did work.
But also removing it from another one and replacing it with " - " caused breakage also

NZ COR - NZ/FM Integration which generated a tag link /tag/nz_cor_-_nz_fm_integration/ (404)

Screen Shot 2016-01-14 at 10.35.11 AM.png (300×750 px, 29 KB)

Screen Shot 2016-01-14 at 10.23.49 AM.png (542×1 px, 86 KB)

Screen Shot 2016-01-14 at 10.23.13 AM.png (608×1 px, 68 KB)

Screen Shot 2016-01-14 at 10.39.37 AM.png (56×630 px, 17 KB)

Screen Shot 2016-01-14 at 10.39.46 AM.png (502×1 px, 90 KB)

Event Timeline

The original report in Q272 is almost certainly unrelated.

Do you have a specific set of reproduction steps I can take against a local install to demonstrate this issue? This report seems to have a lot of observations but I don't understand what the reproduction steps are. See Contributing Bug Reports.

I wish I could reproduce it.
But all new projects I create work perfectly fine.

It seems to only be affecting projects prior to an upgrade done last week.(Jan 4th).

Prior to T9551 (circa October 12), projects could generate with invalid hashtags, but I don't think these ever worked (at least, many of them definitely did not work).

You should be able to force generation of new hashtags by changing the name of the project (then, presumably, changing it back).

Actually changing it back is failing with

error #1406: Data too long for column 'slug' at row 1

When I change
NZ COR - NZ/FM Integration
to
NZ COR: NZ/FM Integration

Can you show me the output of bin/storage adjust? (For now, decline to apply any changes it suggests.)

/var/www/phabricator# bin/storage adjust
Verifying database schemata...
Found no adjustments for schemata.

I'm not really sure what's going on. The limit on the slug column is 128 characters, and that project name is nowhere near that (we should raise a better error message than we do, but I'm not sure how you're hitting the issue in the first place).

I can create projects with either name locally without issues:

Screen Shot 2016-01-14 at 8.44.06 AM.png (187×389 px, 14 KB)

Do you have a value in the "Additional Hashtags" field (or showing in "Hashtags" on the project detail page) which is ridiculously long?

Yes..
nz_cor:_nz_fm_integrationnz_cor_nz_fm_integrationnz_cor_nz_fm_integrationnz_cor_-_nz_fm_integrationnz_cor_nz_fm_integrationnz_cor_nz_fm_integration
Is in there now.
I'll remove those.

Removing those allowed me to save.

Screen Shot 2016-01-14 at 11.48.29 AM.png (192×1 px, 33 KB)

Screen Shot 2016-01-14 at 11.49.34 AM.png (510×1 px, 85 KB)

404's continue.