Page MenuHomePhabricator

Cleaning up arcanist cpplint
Closed, ResolvedPublic


Upgraded arcanist here, and noticed a couple of minor issues that I'm afraid I missed in the submitted patch for T10118.

  1. In the install instruction instructions, I forgot to add a space so a couple of words run together.
  2. The getDefaultBinary function, specifies cpplint as the default. The default file one downloads from google is actually, so I'd suggest changing the default binary to that instead. This would probably cause some confusion for people doing a clean install, so if not fixed there, the alternative is to change the install instructions to add additional instructions about renaming the file (though that seems rather cumbersome).

If you are OK with these changes, I can send you a new diff.

Revisions and Commits