Page MenuHomePhabricator
Feed Advanced Search

Apr 23 2015

epriestley triaged T7894: Give more specific error when git clone fails as Low priority.
Apr 23 2015, 8:28 PM · Diffusion
epriestley triaged T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked as Wishlist priority.
Apr 23 2015, 8:28 PM · Typeahead, Notifications
epriestley renamed T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked from Event Listeners should respect middle and right clicks if possible to Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.
Apr 23 2015, 8:25 PM · Typeahead, Notifications
epriestley added a comment to T7897: Make various <div /> elements in menus act like <a /> elements when middle-clicked or right-clicked.

Event listeners do, generally speaking, respect middle and right clicks. This isn't a case of event listeners just being too ambitious.

Apr 23 2015, 8:24 PM · Typeahead, Notifications
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

(Our largest human-facing source file is PhabricatorApplicationTransactionEditor.php and weighs in at a paltry 78KB.)

Apr 23 2015, 7:48 PM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

In an ideal world, would the regularly edited human-facing 537KB file still be a single 537KB file (rather than, e.g., a collection of smaller files, or a code-generated file, or some other kind of resource)?

Apr 23 2015, 7:44 PM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7860: When users search for "#x y", treat "#x" as a project hashtag.

I think it's reasonable for #x y to mean "documents matching query y in project #x", but I don't think x y should mean this on its own.

Apr 23 2015, 7:31 PM · Search
epriestley lowered the priority of T6187: Allow query results to be exported to spreadsheet rendered in the browser from Normal to Wishlist.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

T5307 discusses finding some way to fit "Export to spreadsheet.." -- and various other options -- into the UI in the general case.

Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a subtask for T6187: Allow query results to be exported to spreadsheet rendered in the browser: T5307: UX for taking actions with search results.
Apr 23 2015, 7:27 PM · ApplicationSearch
epriestley added a parent task for T5307: UX for taking actions with search results: T6187: Allow query results to be exported to spreadsheet rendered in the browser.
Apr 23 2015, 7:27 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a comment to T6187: Allow query results to be exported to spreadsheet rendered in the browser.

We're vanishingly unlikely to redesign search results in the general case, and this request isn't compatible with responsive "object" list search results.

Apr 23 2015, 7:26 PM · ApplicationSearch
epriestley renamed T6187: Allow query results to be exported to spreadsheet rendered in the browser from Make ApplicationSearch better on large result sets to Allow query results to be exported to spreadsheet rendered in the browser.
Apr 23 2015, 7:22 PM · ApplicationSearch
epriestley closed T6383: Blogs and Posts should be searchable. as Invalid.

Sorry, we don't accept feature requests for prototype applications like Phame. See:

Apr 23 2015, 7:15 PM · Phame
epriestley closed T5595: Allow all applications to filter results by project as Resolved.

Diffusion, Pholio, Differential and Maniphest now support generic, full-power modern project filtering. I think that covers all the applications we're aware of significant interest in for this feature. It will come to other applications as they get modernized and updated over time.

Apr 23 2015, 7:12 PM · Projects, ApplicationSearch
epriestley closed T4100: Support query parameterization in typeaheads as Resolved.

These aren't universally deployed yet, but are substantially complete and are deployed in multiple applications. See T7858 for some followups. These will deploy everywhere over time, although they may not come to some lesser-used applications for a bit.

Apr 23 2015, 7:08 PM · Typeahead, User Delight, Maniphest
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T5307: UX for taking actions with search results, as Resolved.
Apr 23 2015, 7:08 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T6860: Allow creation of parameterized application policies, as Resolved.
Apr 23 2015, 7:08 PM · Policy
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T5288: Add a filter to show projects that I haven't joined, as Resolved.
Apr 23 2015, 7:08 PM · Projects
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T7729: No Typeahead on Herald object rule creation, as Resolved.
Apr 23 2015, 7:08 PM · Typeahead, Herald
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T5162: Add Herald action value for content creator / author, as Resolved.
Apr 23 2015, 7:08 PM · Herald
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T3670: Add subprojects, as Resolved.
Apr 23 2015, 7:08 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley closed T4100: Support query parameterization in typeaheads, a subtask of T5595: Allow all applications to filter results by project, as Resolved.
Apr 23 2015, 7:08 PM · Projects, ApplicationSearch
epriestley triaged T7893: placing two memes side by side results in blank comment as Wishlist priority.

to meemees is two many meemees

Apr 23 2015, 6:47 PM · Remarkup
epriestley added a comment to T7887: method to dismiss/acknowledge individual notifications.

As much as I hate features, this is relatively easy to build from a JS/eng point of view, fixes T7132 more easily than giving it a real target, and might let us just not pursue T7843.

Apr 23 2015, 6:45 PM · Restricted Project, Notifications
epriestley updated subscribers of T7887: method to dismiss/acknowledge individual notifications.
Apr 23 2015, 6:42 PM · Restricted Project, Notifications
epriestley merged task T7132: Read test notifications individually by clicking them into T7887: method to dismiss/acknowledge individual notifications.
Apr 23 2015, 6:42 PM · Aphlict
epriestley added a comment to T7894: Give more specific error when git clone fails.

In Git, we get fairly good control over error messages, although less so in Subversion/Mercurial. We emit this particular message ourselves:

Apr 23 2015, 6:33 PM · Diffusion
epriestley added a comment to T7108: high server load due to continuous hg calls.

Does your remote also have an enormous number of branches?

Apr 23 2015, 3:40 PM · Mercurial
epriestley added a revision to T5595: Allow all applications to filter results by project: Unknown Object (Differential Revision).
Apr 23 2015, 3:26 PM · Projects, ApplicationSearch
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 3:26 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 3:08 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T5595: Allow all applications to filter results by project: Unknown Object (Differential Revision).
Apr 23 2015, 3:05 PM · Projects, ApplicationSearch
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 3:05 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 1:49 PM · Typeahead, User Delight, Maniphest
epriestley renamed T7896: Use user's time format preference when formatting times for the date/time picker from Allow changing time picker format to Use user's time format preference when formatting times for the date/time picker.
Apr 23 2015, 1:18 PM · Custom Fields
epriestley added a comment to T7896: Use user's time format preference when formatting times for the date/time picker.

This is possibly tricky because the user can enter some unparsable time format in their preferences, but we can assume that users mostly enter reasonable time formats until we have evidence to the contrary.

Apr 23 2015, 1:17 PM · Custom Fields
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 1:16 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 1:02 PM · Typeahead, User Delight, Maniphest
epriestley added a comment to T7896: Use user's time format preference when formatting times for the date/time picker.

When you enter "23:00", what does it do? What did you expect it to do?

Apr 23 2015, 12:58 PM · Custom Fields
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 12:29 PM · Typeahead, User Delight, Maniphest
epriestley added a comment to T7892: Investigate lint performance issues.

Couple things offhand:

Apr 23 2015, 12:06 PM · Lint
epriestley added a comment to T7892: Investigate lint performance issues.

Here's an updated profile

Apr 23 2015, 12:02 PM · Lint
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 11:56 AM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 11:00 AM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 10:35 AM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 23 2015, 10:19 AM · Typeahead, User Delight, Maniphest
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

And, if your desired value is larger, would making it easier to activate highlighting be a reasonable alternative approach? Currently you can highlight with:

Apr 23 2015, 9:48 AM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7895: Make HIGHLIGHT_BYTE_LIMIT configurable.

If it was configurable, what value would you set it to?

Apr 23 2015, 9:41 AM · Restricted Project, Restricted Project, Differential
epriestley added a comment to T7892: Investigate lint performance issues.

I think php_compat_info.json is the biggest easy win.

Apr 23 2015, 12:57 AM · Lint
epriestley added a comment to T7892: Investigate lint performance issues.

Those regexps can also be memoized.

Apr 23 2015, 12:50 AM · Lint
epriestley added a comment to T7892: Investigate lint performance issues.

This can probably build a single huge regexp and drop time to nearly zero:

Apr 23 2015, 12:50 AM · Lint
epriestley added a comment to T7892: Investigate lint performance issues.

The profile likely overstates the cost of functions like idx() and mpull(), but occasionally they're worth reducing to isset() or similar if they're really getting hit tens of thousands of times.

Apr 23 2015, 12:47 AM · Lint
epriestley added a comment to T7892: Investigate lint performance issues.

I don't see any huuuuge wins, but:

Apr 23 2015, 12:46 AM · Lint

Apr 22 2015

epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Let me know if that fixes it when you have a chance? Still not totally sure I've nailed this down but it shouldn't be possible for it to recurse now.

Apr 22 2015, 11:49 PM · Restricted Project, Workboards
epriestley closed T7891: "Exception: Call setUser() before rendering tokenizer string values." when clicking "Create Task" on workboard as Resolved.

I think workboard permissions are a little iffy until T6502.

Apr 22 2015, 11:25 PM
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

D12511 is a possible fix, although I was only sort of able to reproduce something sort-of similar to the issue you hit.

Apr 22 2015, 11:15 PM · Restricted Project, Workboards
epriestley added a revision to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error): Unknown Object (Differential Revision).
Apr 22 2015, 11:13 PM · Restricted Project, Workboards
epriestley added a comment to T7891: "Exception: Call setUser() before rendering tokenizer string values." when clicking "Create Task" on workboard.

Doesn't repro for me at HEAD and I'm pretty sure I remember fixing this. I presume you can't reproduce on this install?

Apr 22 2015, 11:09 PM
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

I suspect I'm just not hitting the right edge case, but this stuff did churn a lot recently so I just wanted to double check that it's definitely not me testing different code.

Apr 22 2015, 10:39 PM · Restricted Project, Workboards
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Just to confirm, you're ahead of rP8efdc4aa? I'll keep digging, but I can't immediately reproduce this at HEAD.

Apr 22 2015, 10:35 PM · Restricted Project, Workboards
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Ah, okay. Yeah, looks similar. I'll take a look, thanks!

Apr 22 2015, 10:24 PM · Restricted Project, Workboards
epriestley updated the task description for T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).
Apr 22 2015, 10:07 PM · Restricted Project, Workboards
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

Set debug.time-limit to a value like 15 and hit it again? That should give you a trace.

Apr 22 2015, 10:07 PM · Restricted Project, Workboards
epriestley closed T4475: Provide easier way to search within any Application when in it as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 9:31 PM · Restricted Project, Search
epriestley closed T7266: New saved custom search implicitly affects global search as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 9:31 PM · Search
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

You can change the chunk size constant to 1 to see the effect -- I expect it will lower memory usage (but not provide a huge reduction in peak, which I think is approximately a function of the largest file in the repository at these chunk sizes) but be much slower overall.

Apr 22 2015, 9:12 PM · Arcanist
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

I feel that the memory usage could be further improved if we linted by path, because we would only need to store a single XHPAST tree in memory. This means that we wouldn't need chunking.

Apr 22 2015, 9:11 PM · Arcanist
epriestley closed T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 9:01 PM · Maniphest, Herald
epriestley added a comment to T7266: New saved custom search implicitly affects global search.

I've marked D12509 as fixing this, although it really just obsoletes it. Specifically: it removes this behavior (we no longer default to the first query) and makes scope selection explicit instead (if you want to default to a specific query, just select it from the dropdown).

Apr 22 2015, 8:05 PM · Search
epriestley updated subscribers of T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Apr 22 2015, 7:13 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley merged task T7314: Default Phabricator search criteria confuses new users mixing commits and tasks into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Apr 22 2015, 7:13 PM · Search
epriestley added a comment to T7314: Default Phabricator search criteria confuses new users mixing commits and tasks.

I'm going to merge this into T4103, although D12509 partially obsoletes it. Hopefully, the explicit control surfaced in D12509 resolves the confusion here on its own.

Apr 22 2015, 7:13 PM · Search
epriestley added a revision to T7266: New saved custom search implicitly affects global search: Unknown Object (Differential Revision).
Apr 22 2015, 7:11 PM · Search
epriestley added a revision to T4475: Provide easier way to search within any Application when in it: Unknown Object (Differential Revision).
Apr 22 2015, 7:11 PM · Restricted Project, Search
epriestley added a revision to T7314: Default Phabricator search criteria confuses new users mixing commits and tasks: Unknown Object (Differential Revision).
Apr 22 2015, 7:11 PM · Search
epriestley added a comment to T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.

he he he

Apr 22 2015, 4:32 PM · Documentation
epriestley renamed T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule from 'Display Preferences > Monospaced Font' no longer works to Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.
Apr 22 2015, 4:31 PM · Documentation
epriestley added a comment to T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.

I think we should probably just document our way out of that; it's admittedly unclear that we're dumping the input into a font: attribute and we don't provide any examples.

Apr 22 2015, 4:30 PM · Documentation
epriestley closed T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 4:28 PM · Documentation
epriestley added a revision to T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule: Unknown Object (Differential Revision).
Apr 22 2015, 4:26 PM · Documentation
epriestley claimed T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.

Ah, I'll fix the double-escaping.

Apr 22 2015, 4:15 PM · Documentation
epriestley added a comment to T7888: Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.

I also can't reproduce this. An example string which works for me is:

Apr 22 2015, 4:12 PM · Documentation
epriestley added a comment to T5793: Add support for personal workboards.

After T7849 (in review), there's a sort of kludgey workaround for this that has some caveats but should get you 90% of the way there:

Apr 22 2015, 12:28 PM · User Delight, Wikimedia, Workboards
epriestley added a revision to T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Apr 22 2015, 12:21 PM · Maniphest, Herald
epriestley closed T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 12:16 PM · Arcanist
epriestley added a revision to T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Apr 22 2015, 12:07 PM · Maniphest, Herald
epriestley added a revision to T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Apr 22 2015, 11:50 AM · Maniphest, Herald
epriestley added a revision to T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Apr 22 2015, 11:36 AM · Maniphest, Herald
epriestley added a comment to T7878: strange "moved from" signal in [Phriction] diff.

I think the root cause for this is a bit complicated to explain, but basically we try to match this as a move:

Apr 22 2015, 11:17 AM · Differential
epriestley added a comment to T7880: Notifications are broken.

iiam

Apr 22 2015, 10:58 AM · Aphlict
epriestley added a comment to T7885: Error during Installation of Phabricator.

We don't require MySQL 5.5. The install guide says this:

Apr 22 2015, 10:55 AM
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

Estimate = review/test that ^^^

Apr 22 2015, 10:42 AM · Arcanist
epriestley added a revision to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories: Unknown Object (Differential Revision).
Apr 22 2015, 10:41 AM · Arcanist
epriestley closed T7885: Error during Installation of Phabricator as Resolved.

It looks like you already have a conflicting package installed already ("MySQL-server-5.6.13-1.el6.x86_64").

Apr 22 2015, 10:18 AM
epriestley added a comment to T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.

T7884 has the similar case of changing a real file to a symlink.

Apr 22 2015, 8:12 AM · Arcanist
epriestley merged task T7884: certain Differential revisions create unpatchable raw diffs in git into T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 22 2015, 8:11 AM
epriestley updated subscribers of T1022: arc patch fails to properly apply a patch which changes a symlink to a real file.
Apr 22 2015, 8:11 AM · Arcanist
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

Yeah, but I'd have to take another look at the code to give you an estimate since I don't remember exactly how much stuff is standing in our way. I'm headed to bed pretty soon but can take a gander tomorrow morning.

Apr 22 2015, 3:43 AM · Arcanist
epriestley added a comment to T7882: Fatal when viewing commit or searching.

psyduck

Apr 22 2015, 3:06 AM · Search, Diffusion