Page MenuHomePhabricator

Document that "Monospaced Font Preference" must be a valid CSS "Font" rule
Closed, ResolvedPublic

Description

Tested strings:

  • Courier New
  • "Courier New'
  • 15px
  • 15pt
  • 11pt "Consolas" (my previous setting, it indeed worked)

No change in how code blocks/diffs/audits/etc look like in both Chrome and Firefox. Tested on this instance and on my local installation.

Event Timeline

dtf raised the priority of this task from to Needs Triage.
dtf updated the task description. (Show Details)
dtf added a subscriber: dtf.

I also can't reproduce this. An example string which works for me is:

32px impact

Screen_Shot_2015-04-22_at_9.12.11_AM.png (1×1 px, 395 KB)

Looks like we're escaping the quotes... but I'd assume we always have been.

Hm, 32px impact works for me...

For example 11px "Consolas" returns:

pasted_file (108×350 px, 17 KB)

Ah, I'll fix the double-escaping.

Looks like we're escaping the quotes... but I'd assume we always have been.

Don't have much to say here, but it worked on a month-old build.

By the way:

pasted_file (138×543 px, 12 KB)

I don't beleive font: 32px; to be valid CSS.

I think we should probably just document our way out of that; it's admittedly unclear that we're dumping the input into a font: attribute and we don't provide any examples.

We could probably better document that it is just a straight font rule, and takes anything that rule does. https://developer.mozilla.org/en-US/docs/Web/CSS/font

epriestley renamed this task from 'Display Preferences > Monospaced Font' no longer works to Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.Apr 22 2015, 4:31 PM
epriestley reopened this task as Open.
epriestley triaged this task as Low priority.
epriestley added a project: Documentation.

font: italic small-caps bolder 16px/3 cursive;

O.o

http://www.w3.org/TR/css3-fonts/#propdef-font

I don't beleive font: 32px; to be valid CSS.

Seems like you are right.

chad raised the priority of this task from Low to Normal.