Page MenuHomePhabricator
Create Task
Maniphest T7888

Document that "Monospaced Font Preference" must be a valid CSS "Font" rule
Closed, ResolvedPublic
Actions

Assigned To
chad
Authored By
dtf
Apr 22 2015, 4:06 PM
Tags
Referenced Files
F379009: Screen_Shot_2015-04-22_at_9.32.15_AM.png
Apr 22 2015, 4:32 PM
F379001: pasted_file
Apr 22 2015, 4:18 PM
F378999: pasted_file
Apr 22 2015, 4:14 PM
F378996: Screen_Shot_2015-04-22_at_9.12.11_AM.png
Apr 22 2015, 4:12 PM
F378994: Capture.PNG
Apr 22 2015, 4:12 PM
F378989: pasted_file
Apr 22 2015, 4:09 PM
Subscribers
chad
dtf
epriestley

Description

Tested strings:

  • Courier New
  • "Courier New'
  • 15px
  • 15pt
  • 11pt "Consolas" (my previous setting, it indeed worked)

No change in how code blocks/diffs/audits/etc look like in both Chrome and Firefox. Tested on this instance and on my local installation.

Revisions and Commits

rP Phabricator
D12508rP306ab292596c Add documentation for customizing fonts
D12506rPe7702acdc659 Don't escape quotation marks when printing the monospaced CSS rule

Event Timeline

dtf created this task.Apr 22 2015, 4:06 PM
dtf raised the priority of this task from to Needs Triage.
dtf updated the task description. (Show Details)
dtf added a subscriber: dtf.
chad added a subscriber: chad.Apr 22 2015, 4:09 PM

pasted_file (150×539 px, 21 KB)

dtf added a comment.Apr 22 2015, 4:12 PM

Well,

Capture.PNG (703×1 px, 103 KB)

epriestley added a subscriber: epriestley.Apr 22 2015, 4:12 PM

I also can't reproduce this. An example string which works for me is:

32px impact

Screen_Shot_2015-04-22_at_9.12.11_AM.png (1×1 px, 395 KB)

chad added a comment.Apr 22 2015, 4:13 PM

Looks like we're escaping the quotes... but I'd assume we always have been.

dtf added a comment.Apr 22 2015, 4:13 PM

Hm, 32px impact works for me...

chad added a comment.Apr 22 2015, 4:14 PM

For example 11px "Consolas" returns:

pasted_file (108×350 px, 17 KB)

epriestley claimed this task.Apr 22 2015, 4:15 PM

Ah, I'll fix the double-escaping.

dtf added a comment.Apr 22 2015, 4:18 PM

Looks like we're escaping the quotes... but I'd assume we always have been.

Don't have much to say here, but it worked on a month-old build.

By the way:

pasted_file (138×543 px, 12 KB)

epriestley added a revision: D12506: Don't escape quotation marks when printing the monospaced CSS rule.Apr 22 2015, 4:26 PM
epriestley closed this task as Resolved by committing rPe7702acdc659: Don't escape quotation marks when printing the monospaced CSS rule.Apr 22 2015, 4:28 PM
epriestley added a commit: rPe7702acdc659: Don't escape quotation marks when printing the monospaced CSS rule.
chad added a comment.Apr 22 2015, 4:28 PM

I don't beleive font: 32px; to be valid CSS.

epriestley added a comment.Apr 22 2015, 4:30 PM

I think we should probably just document our way out of that; it's admittedly unclear that we're dumping the input into a font: attribute and we don't provide any examples.

chad added a comment.Apr 22 2015, 4:30 PM

We could probably better document that it is just a straight font rule, and takes anything that rule does. https://developer.mozilla.org/en-US/docs/Web/CSS/font

epriestley renamed this task from 'Display Preferences > Monospaced Font' no longer works to Document that "Monospaced Font Preference" must be a valid CSS "Font" rule.Apr 22 2015, 4:31 PM
epriestley reopened this task as Open.
epriestley triaged this task as Low priority.
epriestley added a project: Documentation.
chad added a comment.Apr 22 2015, 4:31 PM

font: italic small-caps bolder 16px/3 cursive;

O.o

dtf added a comment.Apr 22 2015, 4:31 PM

http://www.w3.org/TR/css3-fonts/#propdef-font

I don't beleive font: 32px; to be valid CSS.

Seems like you are right.

epriestley added a comment.Apr 22 2015, 4:32 PM

he he he

Screen_Shot_2015-04-22_at_9.32.15_AM.png (181×698 px, 27 KB)

chad claimed this task.Apr 22 2015, 6:40 PM
chad raised the priority of this task from Low to Normal.
chad added a revision: D12508: Add documentation for customizing fonts.Apr 22 2015, 7:11 PM
chad closed this task as Resolved by committing rP306ab292596c: Add documentation for customizing fonts.Apr 22 2015, 7:13 PM
chad added a commit: rP306ab292596c: Add documentation for customizing fonts.
Phabricator · Built by Phacility