Page MenuHomePhabricator
Feed Advanced Search

Apr 10 2015

epriestley added a comment to T7802: Provide (or increase visibility of) some Maniphest documentation.

When filing feature requests, please describe specific problems:

Apr 10 2015, 4:12 PM · Maniphest
epriestley added a comment to T5750: Implement typeahead browse mode.

This is opening up into some very deep infrastructure work.

Apr 10 2015, 12:11 PM · Restricted Project, Wikimedia, Typeahead, Design, Maniphest

Apr 9 2015

epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Apr 9 2015, 11:10 PM · Typeahead
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Apr 9 2015, 10:34 PM · Typeahead
epriestley added a revision to T7689: Load handles just-in-time: Unknown Object (Differential Revision).
Apr 9 2015, 10:26 PM · Typeahead
epriestley edited P1754 good_key.log.
Apr 9 2015, 10:19 PM
epriestley added a comment to T7798: Way to hide/collapse inline comments in differential, inline presentation suggestion.

D12337 for the policy dialog fix.

Apr 9 2015, 8:09 PM · Differential
epriestley closed T7797: Remarkup links support only HTTP schemes as Resolved.

Add other protocols by configuring uri.allowed-protocols.

Apr 9 2015, 7:59 PM · Remarkup
epriestley added a comment to T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

I'm maybe 60/40 on message being better than participants, but @chad might have stronger feelings. Agreed that it's not confusing to show a departed participant if their message is shown.

Apr 9 2015, 4:56 PM · Conpherence
epriestley added a comment to T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

Although the behavior makes a somewhat-reasonable sort of sense when considered carefully, I'd personally expect removed participants to immediately vanish and would be equally confused about the behavior as implemented.

Apr 9 2015, 4:53 PM · Conpherence
epriestley closed T7793: Building xhpast is broken as Resolved by committing Restricted Diffusion Commit.
Apr 9 2015, 3:53 PM · XHPAST
epriestley added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.

T5031 doesn't really need to happen first but we'd end up in a cleaner place if it did.

Apr 9 2015, 3:26 PM · Differential, Audit
epriestley added a subtask for T7794: Differential revision list "draft notification" bubble should ignore deleted drafts: T5031: Draft Comment Persists After Submission.
Apr 9 2015, 3:26 PM · Differential, Audit
epriestley added a parent task for T5031: Draft Comment Persists After Submission: T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.
Apr 9 2015, 3:26 PM · Restricted Project, Support Impact, Mobile
epriestley added a revision to T7793: Building xhpast is broken: Unknown Object (Differential Revision).
Apr 9 2015, 3:24 PM · XHPAST
epriestley added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.

As it turns out, this is fairly messy.

Apr 9 2015, 3:20 PM · Differential, Audit
epriestley added a subtask for T7571: Conpherence v2 Errata: T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.
Apr 9 2015, 1:47 PM · Conpherence
epriestley added a parent task for T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence: T7571: Conpherence v2 Errata.
Apr 9 2015, 1:47 PM · Conpherence
epriestley updated subscribers of T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.
Apr 9 2015, 1:46 PM · Conpherence
epriestley added a comment to T7794: Differential revision list "draft notification" bubble should ignore deleted drafts.

We'll fix the bubble behavior. The persistence behavior is intentional.

Apr 9 2015, 1:44 PM · Differential, Audit
epriestley renamed T7794: Differential revision list "draft notification" bubble should ignore deleted drafts from Unable to delete draft inline comment (still stays in db) to Differential revision list "draft notification" bubble should ignore deleted drafts.
Apr 9 2015, 1:44 PM · Differential, Audit
epriestley added a comment to T7791: PhabricatorDataCacheSpec::initNoneSpec is undefined.

Whoops, thanks.

Apr 9 2015, 1:03 AM

Apr 8 2015

epriestley created T7790: Link to Phacility documentation from Phacility main site.
Apr 8 2015, 10:12 PM · Phacility
allixsenos awarded T7781: Make feed.http-hooks staff-editable or user-editable a Like token.
Apr 8 2015, 9:27 PM · Setup, Phacility
epriestley added a comment to T7789: Support Git Large File Storage.

(From a user point of view, at least?)

Apr 8 2015, 8:45 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7789: Support Git Large File Storage.

This is better than git-annex only because it works better on Windows?

Apr 8 2015, 8:44 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley added a comment to T7788: Support public Phriction pages.

Set policy.allow-public to true in your config, which will allow you to use the "Public (No Login Required)" policy setting. You can do this from the Config application on your instance.

Apr 8 2015, 7:38 PM · Phacility Support
epriestley added a comment to T7787: Support "!priority high" and other email commands from "arc todo".

We'd possibly be better off popping up $EDITOR for a description (or optionally accepting it from stdin or a file) and then interpreting mail commands in that description. That feels more flexible and consistent, and probably a lot easier to use.

Apr 8 2015, 7:03 PM · Arcanist
epriestley added a comment to T7781: Make feed.http-hooks staff-editable or user-editable.

See T4345, approximately.

Apr 8 2015, 6:45 PM · Setup, Phacility
epriestley closed T7782: Document data import in the cluster as Resolved by committing Restricted Diffusion Commit.
Apr 8 2015, 6:37 PM · Phacility
epriestley closed T7781: Make feed.http-hooks staff-editable or user-editable as Resolved by committing Restricted Diffusion Commit.
Apr 8 2015, 6:37 PM · Setup, Phacility
epriestley added a comment to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay.

Yeah, this is definitely motivated mostly by cowsay, we'd just get dot for free.

Apr 8 2015, 6:28 PM · Phacility, Phacility Support
epriestley renamed T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay from Install Graphviz to Build a Phacility cluster service tier to sandbox Graphviz and Cowsay.
Apr 8 2015, 6:24 PM · Phacility, Phacility Support
epriestley added a comment to T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay.

I'm vaguely concerned about installing dot (and cowsay) because it's possible that they include features which can execute arbitrary commands and compromise the security of a host. Mercurial had such a vulnerability recently, see D12112 for some discussion. It is is unlikely that dot or cowsay have such issues, but I suspect neither program (particularly cowsay) was developed with malicious input at the forefront of design considerations, and the more binaries we execute directly, the greater our exposure.

Apr 8 2015, 6:21 PM · Phacility, Phacility Support
epriestley added a revision to T7781: Make feed.http-hooks staff-editable or user-editable: Unknown Object (Differential Revision).
Apr 8 2015, 3:33 PM · Setup, Phacility
epriestley added a revision to T7782: Document data import in the cluster: Unknown Object (Differential Revision).
Apr 8 2015, 3:33 PM · Phacility
epriestley added a revision to T7781: Make feed.http-hooks staff-editable or user-editable: Unknown Object (Differential Revision).
Apr 8 2015, 3:15 PM · Setup, Phacility
epriestley added a revision to T7781: Make feed.http-hooks staff-editable or user-editable: Unknown Object (Differential Revision).
Apr 8 2015, 3:05 PM · Setup, Phacility
epriestley added a revision to T7781: Make feed.http-hooks staff-editable or user-editable: Unknown Object (Differential Revision).
Apr 8 2015, 2:58 PM · Setup, Phacility
epriestley closed T7778: "Unknown Object (????)" in outbound email as Resolved by committing Restricted Diffusion Commit.
Apr 8 2015, 12:22 PM · Mail
epriestley added a revision to T7778: "Unknown Object (????)" in outbound email: Unknown Object (Differential Revision).
Apr 8 2015, 12:16 PM · Mail
epriestley created T7782: Document data import in the cluster.
Apr 8 2015, 12:12 PM · Phacility
epriestley claimed T7778: "Unknown Object (????)" in outbound email.

I think I removed an array_filter() somewhere, probably during T7731.

Apr 8 2015, 12:10 PM · Mail
epriestley created T7781: Make feed.http-hooks staff-editable or user-editable.
Apr 8 2015, 12:05 PM · Setup, Phacility
epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 8 2015, 12:25 AM · Support Impact, Setup
epriestley placed T7777: Description for "security.strict-transport-security" is incorrect up for grabs.
Apr 8 2015, 12:23 AM · Documentation
epriestley closed T7777: Description for "security.strict-transport-security" is incorrect as Wontfix.

We're satisfied with the current behavior. If you're rewriting responses in a proxy, you should overwrite the header.

Apr 8 2015, 12:12 AM · Documentation

Apr 7 2015

epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 7 2015, 11:54 PM · Support Impact, Setup
epriestley closed T7777: Description for "security.strict-transport-security" is incorrect as Wontfix.

This is behaving as expected. We send the header with "max-age=0" in order to overwrite older settings user agents may have cached.

Apr 7 2015, 11:51 PM · Documentation
epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 7 2015, 10:08 PM · Support Impact, Setup
epriestley created T7775: PhabricatorBot calls deprecated Conduit method "diffusion.getcommits".
Apr 7 2015, 9:33 PM · Phabot, Conduit
epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 7 2015, 9:26 PM · Support Impact, Setup
epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 7 2015, 8:41 PM · Support Impact, Setup
epriestley added a revision to T5501: Provide a builtin APC / OpCache diagnostics page and improve OpCache support: Unknown Object (Differential Revision).
Apr 7 2015, 8:00 PM · Support Impact, Setup
epriestley added a comment to T7773: Allow code reviews across multiple repos.

Can you describe your use case in more detail? See:

Apr 7 2015, 3:52 PM · Restricted Project, Differential
epriestley added a comment to T5791: Write Herald rules for outbound mail.

To better define this:

Apr 7 2015, 2:09 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a revision to T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects: Unknown Object (Differential Revision).
Apr 7 2015, 12:27 PM · Spaces, Wikimedia, Policy
epriestley removed 1 mock(s) for T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks: Unknown Object (Pholio Mock).
Apr 7 2015, 12:25 PM · Restricted Project, libphutil
epriestley removed a revision from T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks: Unknown Object (Differential Revision).
Apr 7 2015, 12:25 PM · Restricted Project, libphutil
epriestley removed a parent task for T7740: Chrome exhibits weird scrolling jumping with anchor in the URL: T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks.
Apr 7 2015, 12:25 PM · Google Chrome
epriestley removed a subtask for T5042: Futures()->limit(X) does not ensure that X number of tasks are running after the first set of tasks: T7740: Chrome exhibits weird scrolling jumping with anchor in the URL.
Apr 7 2015, 12:25 PM · Restricted Project, libphutil
epriestley closed T7770: Origins as Spite.
Apr 7 2015, 12:04 PM
• nagym718 awarded T3820: Implement top-level "Spaces" that provide policy isolation to groups of objects a Mountain of Wealth token.
Apr 7 2015, 9:49 AM · Spaces, Wikimedia, Policy
epriestley edited the content of Adding Hardware.
Apr 7 2015, 12:50 AM

Apr 6 2015

• xmf006 awarded T7565: Ship Conpherence v2 a Mountain of Wealth token.
Apr 6 2015, 10:45 PM · Conpherence
epriestley created T7769: $0 invoices should be automatically payable.
Apr 6 2015, 10:38 PM · Phortune, Phacility
epriestley closed T7768: Status codes seem incorrect as Wontfix.

This is intentional. This is a login page, not a 404. We don't 404 logged-out users because we don't want to disclose the existence of applications.

Apr 6 2015, 9:59 PM · Aphront
epriestley triaged T7767: Running `arc anoid` results in a python stacktrace as Wishlist priority.

We should try to emit a more actionable error message.

Apr 6 2015, 8:30 PM · Arcanist
epriestley added a comment to T7746: Phacility mail is going to "Spam" for some Gmail users.

Yeah, give me about 30 days and I'll send you another one.

Apr 6 2015, 7:23 PM · Mail, Phacility
epriestley added a comment to T7426: Creating a new project does not publish a feed story.

Yeah, publishing everything feels OK to me. Some of the stuff like lock edits and icon edits is maybe pretty fluff, but it's all so rare that it doesn't seem worth special casing.

Apr 6 2015, 7:08 PM · Feed, Projects
epriestley edited P1751 spam.txt.
Apr 6 2015, 6:58 PM
epriestley added a comment to T7746: Phacility mail is going to "Spam" for some Gmail users.

Steps I've taken so far:

Apr 6 2015, 6:43 PM · Mail, Phacility
qgil awarded T7711: Formalize Paid Prioritization? a Love token.
Apr 6 2015, 6:29 PM
epriestley added a comment to T7746: Phacility mail is going to "Spam" for some Gmail users.

Mailgun's minimum Managed pricepoint doesn't make sense for us so I guess I get to learn about mail ops. :/

Apr 6 2015, 5:46 PM · Mail, Phacility
epriestley added a comment to T7746: Phacility mail is going to "Spam" for some Gmail users.

Mailgun got back to me suggesting that I check out their "Managed" offering, which is how I got in contact with them in the first place, so their sales funnel is currently looping back on itself.

Apr 6 2015, 5:10 PM · Mail, Phacility
epriestley closed T7731: Make "Send me an email" force mail delivery through notification preferences as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 5:01 PM · Herald
epriestley added a comment to T7686: Always sort myself to top of Participants List.

A particular case where leaving is difficult is in the column, although trying to address that right now is probably putting the cart before the horse as I imagine we're somewhat likely to either get per-room menus or participant lists or both there.

Apr 6 2015, 4:17 PM · Conpherence
epriestley added a comment to T7765: Room and thread participant lists should sort alphabetically.

A better description of this task is probably "Participant lists should have a meaningful, obvious ordering".

Apr 6 2015, 4:09 PM · Conpherence
epriestley added a comment to T7686: Always sort myself to top of Participants List.

I also think "Leave Room" sounds pretty good if we have a reasonable place in the UI to put it. It's not immediately obvious to me that I'd leave a room by X-ing myself off the participant list, even though the interaction makes sense if you know about it.

Apr 6 2015, 4:06 PM · Conpherence
epriestley added a comment to T7686: Always sort myself to top of Participants List.

Oh, there's a task for this. T7765 is closely related.

Apr 6 2015, 4:05 PM · Conpherence
epriestley added a parent task for T7707: Implement a read-through cache layer: T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
Apr 6 2015, 3:58 PM · Performance
epriestley added a subtask for T4103: Implement "Role Profiles" to provide search, homepage and application defaults: T7707: Implement a read-through cache layer.
Apr 6 2015, 3:58 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

To define this a bit better, I'm imagining these components:

Apr 6 2015, 3:52 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a comment to T4953: If arc diff is run twice on exact same commit, will upload new diff to differential.

am not 100% sure why you'd want to resubmit in the 'environment side-effects' case.

Apr 6 2015, 3:25 PM · Restricted Project, Arcanist, Wikimedia
epriestley added a comment to T4953: If arc diff is run twice on exact same commit, will upload new diff to differential.

The behaviour in this case, where changed patches get --update'd, and unchanged patches generate entirely new revisions, is surprising to say the least.

Apr 6 2015, 3:17 PM · Restricted Project, Arcanist, Wikimedia
epriestley closed T7764: Default monospaced font shows as blank as Resolved by committing Restricted Diffusion Commit.
Apr 6 2015, 3:08 PM · User Preferences
epriestley added a revision to T7764: Default monospaced font shows as blank: Unknown Object (Differential Revision).
Apr 6 2015, 2:52 PM · User Preferences
epriestley added a comment to T7731: Make "Send me an email" force mail delivery through notification preferences.

The specific behavioral change this implements is that Personal (not Global or Object) Herald rules which take a "Send me an email" action can override these user settings:

Apr 6 2015, 2:43 PM · Herald
epriestley added a revision to T7731: Make "Send me an email" force mail delivery through notification preferences: Unknown Object (Differential Revision).
Apr 6 2015, 2:40 PM · Herald
epriestley triaged T7616: Arcanist to be able to access site requiring client side SSL certificate as Wishlist priority.
Apr 6 2015, 1:29 PM · Arcanist, libphutil
epriestley added a comment to T7616: Arcanist to be able to access site requiring client side SSL certificate.

We haven't seen other interest in this and don't plan to pursue it in the near term. I believe deployment of client SSL certificates is exceptionally rare in the wild. Running Conduit over SSH (T550) might solve some of the same problems but has far broader acceptance.

Apr 6 2015, 1:29 PM · Arcanist, libphutil

Apr 5 2015

epriestley added a revision to T7731: Make "Send me an email" force mail delivery through notification preferences: Unknown Object (Differential Revision).
Apr 5 2015, 5:46 PM · Herald
epriestley added a revision to T7731: Make "Send me an email" force mail delivery through notification preferences: Unknown Object (Differential Revision).
Apr 5 2015, 5:39 PM · Herald
epriestley added a comment to T7765: Room and thread participant lists should sort alphabetically.

I do think two possibly-reasonable exceptions are:

Apr 5 2015, 4:22 PM · Conpherence
epriestley added a comment to T7765: Room and thread participant lists should sort alphabetically.

Oh, maybe it's sorting by "most recent message".

Apr 5 2015, 4:17 PM · Conpherence
epriestley added a comment to T7765: Room and thread participant lists should sort alphabetically.

lists currently sort by join order

Apr 5 2015, 3:48 PM · Conpherence
epriestley created T7765: Room and thread participant lists should sort alphabetically.
Apr 5 2015, 3:44 PM · Conpherence
epriestley added a comment to T7764: Default monospaced font shows as blank.

Yeah, we should probably remove this. T4103 will eventually allow global defaults to be set up.

Apr 5 2015, 2:33 PM · User Preferences

Apr 4 2015

epriestley added a comment to M1433: Global Search.

I'd get rid of the "top query returned" behavior if we adopt this, to make things simpler. "All" would always mean "all", never "top query among saved queries".

Apr 4 2015, 7:39 PM · Search
epriestley added a comment to M1433: Global Search.

Yeah, I'd make the app search be something like "Current Application" and it works like "All" if you're in a weird application like Settings or Auth or whatever.

Apr 4 2015, 7:38 PM · Search