Page MenuHomePhabricator

Room and thread participant lists should sort alphabetically
Closed, ResolvedPublic

Description

The participant lists currently sort by join order, which seems less useful than sorting alphabetically. For example, it makes it more difficult to quickly assess if a specific user is a room member.

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Conpherence.
epriestley added subscribers: epriestley, btrahan, chad.

lists currently sort by join order

Well, that might be optimistic.

If the list was alphabetical, we could probably forgo sorting yourself to the top.

Oh, maybe it's sorting by "most recent message".

Screen_Shot_2015-04-05_at_9.16.47_AM.png (408×256 px, 37 KB)

I do think two possibly-reasonable exceptions are:

  • Maybe sort you to the top;
  • maybe sort users who can edit the room to the top (in rooms only) -- basically, "admins first".

A better description of this task is probably "Participant lists should have a meaningful, obvious ordering".

If they already have a meaningful (but not obvious) ordering, we should make it obvious (e.g., if it's by-last-message, put "last message X minutes ago" next to each entry or whatever).

If they don't have a meaningful ordering, using alphabetical seems reasonable, possibly with the "you on top" and/or "admins on top" rules.

(After T6868, it might also make sense to put "away" users on the bottom, but I don't actually think this is very good and T6868 is probably a long way away.)

The existing order is based on when participants are added. (I think anyway; the query is on conpherence phid and the index used is (conpherence phid, participant phid) so I think it ends up ordered by id? Seems like that on my test data.)

Ergo, go with the "I am at the top, rest of the list is alphabetical" option. Diff in a moment.