Page MenuHomePhabricator
Create Task
Maniphest T7798

Way to hide/collapse inline comments in differential, inline presentation suggestion
Closed, WontfixPublic
Actions

Description

Many of our users preference the use of inlines for conversation in regards to the referenced section of code over doing it in the top feed since even if we keep it to no more then 100 ncsl per review multiple topics on different segments can spawn and doing all that conversation in the top can cause confusion.

Because of this the code diffs can become quite large and spaced out by the inlines.
In this case a way to hide/collapse the inlines would be very useful especially if you just want to look over the code without having to scroll through all the inline replies.

In a perfect world the inlines would actually be reference points(little icon with a number at the center) and when clicked would display either a pop-up of the discussions or a feed off to the left similar to how the file tree is presented and could be made as a config option but I would assume that would take a decent bit of work to do.

Related Objects

Event Timeline

nzelinsk created this task.Apr 9 2015, 8:05 PM
nzelinsk raised the priority of this task from to Normal.
nzelinsk updated the task description. (Show Details)
nzelinsk added a project: Differential.
nzelinsk changed the edit policy from "All Users" to "Custom Policy".
nzelinsk added a subscriber: nzelinsk.
chad changed the edit policy from "Custom Policy" to "All Users".Apr 9 2015, 8:06 PM
epriestley added a subscriber: epriestley.Apr 9 2015, 8:09 PM

D12337 for the policy dialog fix.

chad raised the priority of this task from Normal to Needs Triage.Apr 9 2015, 8:15 PM
chad closed this task as Wontfix.EditedApr 9 2015, 9:14 PM
chad claimed this task.
chad added a subscriber: chad.

T5654 and T7447 most closely approximate this task. I'm not sure if we had those features you'd have need for this. Specifically T7447 would, when the author addressed all comments and updated the diff, present a clean UI with indicators of older discussion points.

nzelinsk added a comment.Apr 9 2015, 9:30 PM

You are mostly right, my problem is that I have users that are used to Code Collaborator which presents comments in a left frame and present pins on the code diff to represent where a comment/discussion started and a lot of them find the inline off-setting of code as messy and basically wanted to at least hide it.

I guess I'll just throw in some code to get the desired effect for now and keep an eye on the two tasks you mentioned.
Thanks for your hard work on Phabricator, your code is very impressive.

P.S. I'm trying to pull them to Differential because Code Collaborator has little/terrible integration with existing environments and losses any tracking metadata for a git environment that would link commits to reviews.

cduruk added a subscriber: cduruk.Jul 1 2015, 5:12 PM
cduruk removed a subscriber: cduruk.
cduruk added a subscriber: cduruk.Jul 1 2015, 5:20 PM
cduruk removed a subscriber: cduruk.
edibiase added a subscriber: edibiase.Nov 2 2015, 3:27 PM
Phabricator · Built by Phacility