D10876 was a specific bad case of this because of a bug (loading 73K "assigned tasks" for logged out users) but users with "only" a few thousand tasks (which is reasonable on real installs with real users) will currently pay a needlessly high performance penalty, and it should be possible to assign a user 75K tasks without making Phabricator unusable for them.

Closed by commit rP435085862892.

Closed by commit rP81a13ed8bda8.

Yeah, that helps, thanks.

I haven't looked at the code recently, but I would expect the cleanest approach to be to turn DifferentialDiffEditor into a proper transaction editor, which operates on a DifferentialDiff instead of a DifferentialRevision -- not to merge it into DifferentialTransactionEditor.

I was basically really far off with my optimistic assessment.

When adding the To/Cc HTML, maybe make sure the mail already has an HTML body, so we never end up with a body that only has to/cc.

Closed by commit rP4e5775f1dad9.

Closed by commit rPd2ea0bc5f0df.

The task description has a little spec that I like over a setup warning. Support Impact part is true given the recent merge action.

This has recently had some Support Impact. A setup warning seems reasonable?

Thanks @qgil

Closed by commit rP22551d106d35.

Closed by commit rPaeb3a12e13ae.

Closed by commit rP786232c4bc29.

Er, not a 404, a permissions dialog.

Theory here is that the image isn't being created with the right permissions when we pull it from the authentication service. Then the user tries to load it, hits a 404 in the background, and gets a cookie set.

project.query does not emits the auxiliary dictionary, so there's no way of getting custom field value with the api :(

I'm just going to merge this into T5604, I think it will be hard to do that without getting this at the same time.

This has Support Impact

In T4151#53936, @epriestley wrote:

The only thing remaining here is:

• When creating a hosted repository, it defaults to having all its hosting options off.

Instead, these should probably be something like:

• SSH: Read/Write if diffusion.ssh-user is set?
• HTTP: Read/Write if diffusion.allow-http-auth is set?

I don't think we have a totally unambiguous way to pick defaults, but those are probably better than the status quo.

I'd say:

So what should the fix be here?

Putting this upforgrabs as its just blocked on T5604 now and otherwise works. (i.e. Maniphest doesn't work everything else does.)

I can't reproduce this fully and then have questions....

Another thank you note. You guys are great.

@austinstoker, you want to see this: T3179#81309

We want to migrate to phabricator from trac, but to get buy-in we need to migrate trac tickets and their custom fields to Maniphest tickets. As I understand we can either wait on this ticket, or delve into the code and try to resolve this. Is there any other option?

Feel free to rejigger priority. That said, I think if this was "high" priority it should DEFINITELY be a Support Impact thing too.

Closed by commit rP796428c810a0.

For anyone waiting on this with bated breath, there are a couple of minor followups in T6495, T6496, and T6497 to iron out some details.

This should now (post rP3fa8b152b635) work.

Great work @epriestley

Closed by commit rPc8d20d3c66f2.

There's also some kind of mess with MySQL 6.0 (which is 6 years old but doesn't exist since there was a transition to a "new release model" after Oracle bought MySQL AB?) and renaming utf8 to utf8mb3, and maybe renaming utf8mb4 to utf8. I haven't been able to figure out exactly what the story is here yet, but we should be well-prepared to deal with whatever happens there now that we have the storage adjust infrastructure.

Alrighty folks - after your next upgrade this should be completely resolved.

Well, let's see if I destroyed everything before we celebrate too much.

If only beers could be purchased with mountain of wealth tokens... :3

I feel we owe @epriestley many beers and chips for this change. Or a lifetime's worth.

Closed by commit rPa17a36869254.

D10804 fixes the wiki issue directly. D10798 (which is the patch in P1415) will also fix it indirectly.

Need a way to add tokens to comments. :)

D10800 will resolve the last known bits here. Will close when it lands.

D10800 marks this as fixed. For more details (or if you run into issues) see T6485 (which will be updated shortly to reflect the current state of the world).

I think once the task is marked "resolved" you can expect this functionality to work and its potentially most expedient to just hang out until then. In the interim, there's a mountain of technical debt I am taking out, plus related features... Here's my current list

Also want to add that we had several duplicate differential_drafts on our install as well. About 15 objectPHID-authorPHID combinations had duplicates, ranging from 2-10 duplicates each. Cleaning them up was pretty straightforward.

Nothing is usable yet.

I'm unclear on whether or not any of the recent changes are usable right now. Is there any way to actually limit access by project right now? It would be helpful if the task description was updated with a checklist of things that are (not) supported.

No. See: https://secure.phabricator.com/book/phabcontrib/article/feature_requests/#setting-expectations

Can this be implemented this year? Would be great present for Christmas.