Page MenuHomePhabricator
Create Task
Maniphest T6102

Improve typeahead behavior around exact matches
Closed, ResolvedPublic
Actions

Description

@zeeg reports that on an install with more than 5 projects matching "Security", including an exact match for "Security", typeaheads can fill up with other matches and not allow selection of "Security".

We should sort shorter/exact matches first, so a result is always selectable by typing its name exactly.

Revisions and Commits

rP Phabricator
D11305rP49ee09be3f45 Tokenizers - improve algorithm around exact matches.
D10867rP81a13ed8bda8 Search Typeahead - make exact matches show up first

Related Objects

Event Timeline

epriestley created this task.Sep 15 2014, 11:03 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley added subscribers: epriestley, zeeg.
eadler added a subscriber: eadler.Sep 15 2014, 11:09 PM
chad added a subscriber: chad.Sep 16 2014, 2:46 AM
qgil added a subscriber: qgil.Sep 16 2014, 7:27 AM
epriestley added a project: Support Impact.Oct 3 2014, 3:41 AM

Support Impact This is broken with no real workaround.

btrahan claimed this task.Nov 15 2014, 2:54 AM
btrahan added a revision: D10867: Search Typeahead - make exact matches show up first.Nov 17 2014, 11:11 PM
btrahan closed this task as Resolved.Nov 17 2014, 11:32 PM
btrahan added a commit: rP81a13ed8bda8: Search Typeahead - make exact matches show up first.

Closed by commit rP81a13ed8bda8.

aklapper added a subscriber: aklapper.Nov 18 2014, 12:20 PM
qgil added a project: Wikimedia.EditedDec 11 2014, 7:40 AM

Wikimedia upgraded yesterday, and while typing "Wikidata" seems to bring "Wikidata" among the top five suggestions, it is not the top result, which makes us think that we can still run into scenarios like the one described here.

Details: https://phabricator.wikimedia.org/T76732#838798

btrahan added a comment.Dec 11 2014, 5:51 PM

When I type "Wikidata" on your install its the top result:

Screenshot_2014-12-11_09.51.06.png (687×1 px, 182 KB)

epriestley added a comment.Dec 11 2014, 6:07 PM

I can reproduce it on the WMF install in tokenizers:

Screen_Shot_2014-12-11_at_10.07.09_AM.png (318×934 px, 32 KB)

btrahan added a comment.Dec 11 2014, 6:14 PM

Oh, I thought this was about the global search. The existing patch only covers the global search in the upper right.

btrahan reopened this task as Open.Dec 11 2014, 6:15 PM
btrahan removed btrahan as the assignee of this task.
qgil moved this task from Backlog to Important on the Wikimedia board.Dec 12 2014, 11:21 PM
btrahan claimed this task.Jan 9 2015, 10:41 PM
btrahan added a revision: D11305: Tokenizers - improve algorithm around exact matches..Jan 9 2015, 10:43 PM
btrahan closed this task as Resolved by committing rP49ee09be3f45: Tokenizers - improve algorithm around exact matches..Jan 9 2015, 10:54 PM
btrahan added a commit: rP49ee09be3f45: Tokenizers - improve algorithm around exact matches..
qgil awarded a token.Jan 10 2015, 12:22 AM
aklapper mentioned this in T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.Jun 11 2015, 11:48 AM
Phabricator · Built by Phacility