Git checks for missing origin in 1.7.1 happen too late in the update process
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	May 2 2014, 8:10 PM

Description

The checks from D7614 should fire as part of git pull, since the git fetch command depends on origin being correct. See IRC for context.

rP Phabricator
	D10855	rPd2ea0bc5f0df Diffusion - add verifyGitOrigin check to git fetch operation

Duplicates Merged Here: T5938: Unable to setup a clone of private git repo hosted on GitHub

epriestley raised the priority of this task from to Normal.

epriestley updated the task description. (Show Details)

epriestley added a subscriber: epriestley.

(+@spicyj)

We also don't correct remotes unless the old one fails. Instead, we should check remotes before doing a pull.

◀ Merged tasks: T5938.

T5938 has a very similar issue on Git 1.8.5.5. I'm at a loss as to what's going on there, but hopefully the fix for this will fix both.

Support Impact This has cropped up a number of times and is surprising and broken.

Closed by commit rPd2ea0bc5f0df.