Page MenuHomePhabricator
Feed All Stories

Feb 28 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 28 2018, 1:45 PM · Plans, Harbormaster

Feb 27 2018

epriestley added a parent task for T4340: Implement Content-Security-Policy and Strict-Transport-Security headers: T13093: Plans: 2018 Week 9 Bonus Content.
Feb 27 2018, 11:07 PM · Phacility, Security
epriestley added a subtask for T13093: Plans: 2018 Week 9 Bonus Content: T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.
Feb 27 2018, 11:07 PM · Plans, Phacility
epriestley added a revision to T13093: Plans: 2018 Week 9 Bonus Content: Unknown Object (Differential Revision).
Feb 27 2018, 10:33 PM · Plans, Phacility
epriestley added a revision to T13093: Plans: 2018 Week 9 Bonus Content: Unknown Object (Differential Revision).
Feb 27 2018, 9:59 PM · Plans, Phacility
epriestley added a revision to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers: Unknown Object (Differential Revision).
Feb 27 2018, 8:19 PM · Phacility, Security
epriestley added a revision to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers: Unknown Object (Differential Revision).
Feb 27 2018, 5:33 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

On the Stripe payment processing workflow, we embed a piece of Javascript directly from Stripe.
On the Recaptcha flow, we embed a piece of Javascript directly from Google.

Feb 27 2018, 5:09 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

Other stuff to test:

Feb 27 2018, 4:55 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

When we use a Quicksand transition from page A (which does not have Google or Recaptcha stuff on it) to page B (which does), the CSP from Page A will currently still be in control and prevent Page B from working.

Feb 27 2018, 4:11 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

On the Stripe payment processing workflow, we embed a piece of Javascript directly from Stripe.

Feb 27 2018, 4:05 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

I don't think this exposes new attack surface, at least today.

Feb 27 2018, 3:43 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

Idle thought: can we data: an SVG with onhover behaviors?

Feb 27 2018, 3:39 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

Idle thought: can we data: an SVG with onhover behaviors?

Feb 27 2018, 3:31 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

(Offhand, it's actually not immediately clear to me whether unsafe-eval applies to style attributes or not. Presumably, it should. This is easy to test.)

Feb 27 2018, 1:47 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

We use data: URIs to inline small images into CSS. For now, I'm going to allow these unconditionally. It's possible we could be more strict in the future, and allow data: as an img-src only in CSS files.

Feb 27 2018, 1:45 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

We use inline style="..." attributes and can't realistically get rid of these in the short term. Although some of these are just laziness in obscure interfaces, quite a few are legitimate (for example, inline background-image for profile images, and inline computed width or position values for elements which can be moved or resized in Javascript). We could move more rendering to Javascript, but Phabricator "mostly sort of" works with Javascript disabled and I generally think this is desirable, so I think this would be a tradeoff, not a strict improvement.

Feb 27 2018, 1:34 PM · Phacility, Security
epriestley added a comment to T4340: Implement Content-Security-Policy and Strict-Transport-Security headers.

From PHI399:

Feb 27 2018, 1:33 PM · Phacility, Security
epriestley updated the task description for T13093: Plans: 2018 Week 9 Bonus Content.
Feb 27 2018, 12:55 PM · Plans, Phacility
kuba-orlik awarded T182: Commit into repository directly from differential a Like token.
Feb 27 2018, 11:05 AM · Haskell.org, Restricted Project, Differential
kuba-orlik awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Feb 27 2018, 10:48 AM · Calendar
bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Okay. For the sake of 100% clarity it would be nice if the timeline story did show why the action was taken as it isn't immediately clear (unless you've read the documentation of course) why it was removed.

Feb 27 2018, 8:05 AM · Herald, Diffusion, Projects
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Very rough version of the new log:

Feb 27 2018, 2:05 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 27 2018, 1:49 AM · Plans, Harbormaster

Feb 26 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 26 2018, 10:50 PM · Plans, Harbormaster
epriestley added a comment to T12455: Tag order on tasks matters for subprojects and milestones.

See T13092; tangentially, it might be nice to render these stories more explicitly as "X added Y, removed Z (because Z is a subproject of Y, and objects may not be tagged with multiple mutual ancestors/descendant projects)", if some sufficiently terse phrasing can be found.

Feb 26 2018, 6:17 PM · Bug Report
epriestley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

I'll make a note on T12455, but we might be able to render this timeline story more clearly, e.g. "X added project Y (which automatically removed Z, a subproject)" but I think this is likely fairly natural/obvious in most cases and I'm not sure if it's trivial to completely explain in the timeline.

Feb 26 2018, 6:16 PM · Herald, Diffusion, Projects
epriestley updated the task description for T13093: Plans: 2018 Week 9 Bonus Content.
Feb 26 2018, 6:06 PM · Plans, Phacility
bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Ah, that would certainly explain it. Sorry for the noise - when entering this I did wonder if I had missed something as it didn't make sense that a name collision would be able to cause this.

Feb 26 2018, 6:02 PM · Herald, Diffusion, Projects
epriestley triaged T13093: Plans: 2018 Week 9 Bonus Content as Normal priority.
Feb 26 2018, 4:38 PM · Plans, Phacility
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Feb 26 2018, 4:36 PM · Plans, Diffusion
epriestley closed T13092: Diffusion tagging can't handle projects with similar names as Resolved.

"Plasma on Wayland" is a subproject of "Plasma".

Feb 26 2018, 3:17 PM · Herald, Diffusion, Projects
bcooksley created T13092: Diffusion tagging can't handle projects with similar names.
Feb 26 2018, 9:04 AM · Herald, Diffusion, Projects

Feb 25 2018

epriestley edited the content of Welcome.
Feb 25 2018, 3:42 PM
epriestley edited the content of Starmap.
Feb 25 2018, 3:42 PM
epriestley edited the content of Roadmap.
Feb 25 2018, 3:36 PM
epriestley created U40 Plans.
Feb 25 2018, 3:30 PM
epriestley added a project to T13047: Plans: Symbol Indexes: Plans.
Feb 25 2018, 3:28 PM · Plans, Symbols
epriestley added a project to T13073: Plans: Drydock for normal software use cases where builds take more than 45 seconds: Plans.
Feb 25 2018, 3:28 PM · Plans, Drydock
epriestley added a project to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Plans.
Feb 25 2018, 3:28 PM · Plans, Data Exporters
epriestley added a project to T13074: Plans: Workboard triggers, groups, and subproject columns: Plans.
Feb 25 2018, 3:28 PM · Workboards (v3), Plans, Projects
epriestley added a project to T13053: Plans: Mail Tags and Failover: Plans.
Feb 25 2018, 3:28 PM · Plans, Must Encrypt Mail, Mail
epriestley added a project to T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction: Plans.
Feb 25 2018, 3:28 PM · Plans, Differential, Harbormaster
epriestley added a project to T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance: Plans.
Feb 25 2018, 3:28 PM · Plans, Diffusion
epriestley added a project to T13076: Plans: Phacility cluster caching, renaming, and rebalance/compaction: Plans.
Feb 25 2018, 3:28 PM · Plans, Ops, Infrastructure, Phacility
epriestley added a project to T13077: Plans: Phriction modern "v3" APIs, Drafts: Plans.
Feb 25 2018, 3:28 PM · Plans, Phriction
epriestley added a project to T13088: Plans: Harbormaster UI usability and interconnectedness: Plans.
Feb 25 2018, 3:28 PM · Plans, Harbormaster
epriestley added a project to T13083: Plans: Portals and Facts: Plans.
Feb 25 2018, 3:28 PM · Plans, Facts, Dashboards
epriestley added a project to T13090: Plans: 2018 Week 8 Bonus Content: Plans.
Feb 25 2018, 3:28 PM · Plans, Phacility
epriestley created Plans.
Feb 25 2018, 3:27 PM
epriestley created U39 Support Pacts.
Feb 25 2018, 3:25 PM

Feb 24 2018

epriestley edited the content of Changelog.
Feb 24 2018, 4:17 PM
epriestley created 2018 Week 8 (Late February).
Feb 24 2018, 4:16 PM
epriestley renamed T13091: Ferret "Relevance" order does not always have all the columns it needs available from Exception in search in Differential to Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 3:25 PM · Search
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

The second issue causes the error #1054: Unknown column 'epochModified' in 'order clause' (note no ft_doc) which isn't exactly the same as the first issue.

Feb 24 2018, 3:18 PM · Search
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

I think this is a couple of different issues:

Feb 24 2018, 3:17 PM · Search
epriestley added a comment to T13091: Ferret "Relevance" order does not always have all the columns it needs available.

When you use the "Query" field to activate Ferret fulltext search, a "Relevance" score is computed internally. Roughly, today: documents are more relevant if your terms appear in the title than if they appear only in other fields; and stemmed terms are more relevant if the exact term you searched for appears in the raw document than if the stemmed version appears in the normalized version of the document.

Feb 24 2018, 3:07 PM · Search
fumoboy007 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Feb 24 2018, 10:45 AM · Workboards (v3), Restricted Project
avivey updated the task description for T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:10 AM · Search
avivey created T13091: Ferret "Relevance" order does not always have all the columns it needs available.
Feb 24 2018, 4:09 AM · Search

Feb 23 2018

epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 7:12 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 2:15 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 2:03 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 1:52 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 1:39 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 1:18 PM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 3:20 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 2:46 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 2:20 AM · Plans, Harbormaster
epriestley added a revision to T13088: Plans: Harbormaster UI usability and interconnectedness: Unknown Object (Differential Revision).
Feb 23 2018, 2:06 AM · Plans, Harbormaster

Feb 22 2018

epriestley closed T13090: Plans: 2018 Week 8 Bonus Content as Resolved.

PHI379 describes a weird "Copied Lines" signal which can at least be triaged.

Feb 22 2018, 9:58 PM · Plans, Phacility
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Restricted Differential Revision.
Feb 22 2018, 9:44 PM · Plans, Phacility
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Unknown Object (Differential Revision).
Feb 22 2018, 8:58 PM · Plans, Phacility
epriestley closed T13087: Outbound mail should get X-Phabricator-Mail-ID and X-Phabricator-Unique headers as Resolved by committing Restricted Diffusion Commit.
Feb 22 2018, 8:47 PM · Mail
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Unknown Object (Differential Revision).
Feb 22 2018, 8:46 PM · Plans, Phacility
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Unknown Object (Differential Revision).
Feb 22 2018, 8:42 PM · Plans, Phacility
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Unknown Object (Differential Revision).
Feb 22 2018, 6:55 PM · Plans, Phacility
epriestley added a revision to T13077: Plans: Phriction modern "v3" APIs, Drafts: Unknown Object (Differential Revision).
Feb 22 2018, 6:55 PM · Plans, Phriction
epriestley added a revision to T13087: Outbound mail should get X-Phabricator-Mail-ID and X-Phabricator-Unique headers: Restricted Differential Revision.
Feb 22 2018, 6:35 PM · Mail
epriestley added a revision to T13090: Plans: 2018 Week 8 Bonus Content: Restricted Differential Revision.
Feb 22 2018, 6:35 PM · Plans, Phacility
epriestley triaged T13090: Plans: 2018 Week 8 Bonus Content as Normal priority.
Feb 22 2018, 5:55 PM · Plans, Phacility
epriestley renamed T13089: A full disk on a read replica database host can cause far-reaching request slowness? from A full disk on a read replica can cause far-reaching request slowness? to A full disk on a read replica database host can cause far-reaching request slowness?.
Feb 22 2018, 5:48 PM · Clusters, Infrastructure
epriestley renamed T13089: A full disk on a read replica database host can cause far-reaching request slowness? from A full disk on a read replica can kill everything to A full disk on a read replica can cause far-reaching request slowness?.
Feb 22 2018, 5:48 PM · Clusters, Infrastructure
epriestley triaged T13089: A full disk on a read replica database host can cause far-reaching request slowness? as Low priority.
Feb 22 2018, 4:30 PM · Clusters, Infrastructure
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Feb 22 2018, 3:58 PM · Plans, Diffusion
asherkin added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

As a note, pv can rate limit a pipe and is generally very useful all around.

Feb 22 2018, 10:33 AM · Plans, Harbormaster

Feb 21 2018

epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

this is a very good task :)

Feb 21 2018, 8:14 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

i used gem install so that i could remain ignorant of those types of problems

Feb 21 2018, 8:02 PM · Plans, Harbormaster
avivey added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.
$ sudo apt install lolcat
 ...
 ...
 ...
After this operation, 27.6 MB of additional disk space will be used.
Do you want to continue? [Y/n]
Feb 21 2018, 8:00 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

cat.gif (1×3 px, 7 MB)

Feb 21 2018, 7:50 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Colorful-Linux-Terminal-Output.gif (365×922 px, 341 KB)

Feb 21 2018, 7:22 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

haha

Feb 21 2018, 7:21 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

I suppose welding does normally take a long time.

Feb 21 2018, 7:21 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

it has an -s option

Feb 21 2018, 7:21 PM · Plans, Harbormaster
yelirekim added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

There is a program far superior to cat that already exists.

Feb 21 2018, 7:21 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

Testing any of this is also a pain right now, so before any of that happens I'm going to write bin/harbormaster build --log output.txt or bin/harbormaster write-a-log or something. This overlaps the actual API-writing request in T9124, but that has more complicated concerns (like UTF8 issues, writing to a closed log, etc).

Feb 21 2018, 7:16 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

maybe a "grep" would be nice

Feb 21 2018, 7:08 PM · Plans, Harbormaster
epriestley added a comment to T13088: Plans: Harbormaster UI usability and interconnectedness.

I'm planning to tackle the build log stuff first since it's the most clear-cut, all fairly close together, and also roughly the most dumb.

Feb 21 2018, 7:04 PM · Plans, Harbormaster
epriestley edited the content of 2018 Week 7 (Mid February).
Feb 21 2018, 5:02 PM
mcorteel added a comment to P2084 T12785 patch.

Once I get an answer on how to submit it... See T12785

Feb 21 2018, 4:18 PM