Page MenuHomePhabricator
Feed Advanced Search

Sep 13 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

See also PHI68.

Sep 13 2017, 10:55 PM · Customer Impact, Diffusion, Bug Report
epriestley added a revision to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Restricted Differential Revision.
Sep 13 2017, 7:21 PM · Customer Impact, Diffusion, Bug Report

Sep 12 2017

chad updated the task description for T12980: Diffusion search throws exception on older git.
Sep 12 2017, 3:13 AM · Diffusion
chad created T12980: Diffusion search throws exception on older git.
Sep 12 2017, 2:55 AM · Diffusion

Sep 5 2017

epriestley closed T12975: Unable to update Credential on URI when credential policy is set to other user as Resolved by committing Restricted Diffusion Commit.
Sep 5 2017, 6:56 PM · Passphrase, Diffusion
epriestley added a revision to T12975: Unable to update Credential on URI when credential policy is set to other user: Restricted Differential Revision.
Sep 5 2017, 6:34 PM · Passphrase, Diffusion
epriestley claimed T12975: Unable to update Credential on URI when credential policy is set to other user.
Sep 5 2017, 6:27 PM · Passphrase, Diffusion
chad created T12975: Unable to update Credential on URI when credential policy is set to other user.
Sep 5 2017, 6:27 PM · Passphrase, Diffusion

Aug 29 2017

chad created T12973: Commit list changes based on hash in URL.
Aug 29 2017, 8:47 PM · Diffusion

Aug 28 2017

chad closed T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting." as Resolved by committing Restricted Diffusion Commit.
Aug 28 2017, 7:00 PM · Diffusion
chad added a revision to T12051: "Autoclose: Disabled" could provide a stronger hint that it means "You, the user, have disabled Autoclose by adjusting a setting.": Restricted Differential Revision.
Aug 28 2017, 6:43 PM · Diffusion
chad closed T12824: Redesign Diffusion as Resolved.

The bulk of the work here is finished, no plans on approaching a re-design for diffusion home this pass.

Aug 28 2017, 5:57 PM · Design, Diffusion
chad closed T12804: Diffusion pre-redesign UI feedback (June 2017) as Resolved.

Closing out, thanks for all the feedback. Will follow up with individual tasks not addressed.

Aug 28 2017, 5:56 PM · Diffusion, Design
chad closed T12804: Diffusion pre-redesign UI feedback (June 2017), a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 28 2017, 5:56 PM · Design, Diffusion
chad closed T7701: Surface Code/File search better in Diffusion as Resolved.

New search shipping with last week's stable release.

Aug 28 2017, 5:46 PM · Restricted Project, Design, Diffusion

Aug 27 2017

epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

The behavior may have changed, but the change is from "we sometimes silently do the wrong thing" to "we explicitly refuse to do the wrong thing".

Aug 27 2017, 5:26 PM · Mercurial, Diffusion
chad merged task T12972: Ignoring missing version information on binaries doesn't seem to work into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Aug 27 2017, 4:05 PM · Mercurial, Diffusion
chad added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

Ah, it sounded like a regression from the report. I haven't tried to bisect to determine if that was true.

Aug 27 2017, 4:05 PM · Mercurial, Diffusion
epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

That is, specifically, it expected that hg commands do not work in Phabricator if it can not determine the version of hg, so this is not a bug. Ignoring the setup warning might mean "we used to do Mercurial stuff but don't anymore, leaving us with some archived Mercurial repositories which we don't really need to look at, so it's okay that hg commands won't be able to run".

Aug 27 2017, 4:03 PM · Mercurial, Diffusion
epriestley added a comment to T12972: Ignoring missing version information on binaries doesn't seem to work.

The version is strictly required because different versions of hg use different command syntax. If we can not determine which version of hg is installed, we can not run hg commands.

Aug 27 2017, 4:01 PM · Mercurial, Diffusion
chad created T12972: Ignoring missing version information on binaries doesn't seem to work.
Aug 27 2017, 3:58 PM · Mercurial, Diffusion
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I could totally be imagining that.

Aug 27 2017, 4:30 AM · Diffusion, Design
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

it shouldn't have changed, just now a border. I don't know how to update the colors since it some sort of strange math only engineers know.

Aug 27 2017, 4:27 AM · Diffusion, Design
avivey added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

If it matters, my laptop is actually 13" with 1080, but it's only because the store said they don't have a smaller version.

Aug 27 2017, 4:26 AM · Diffusion, Design

Aug 26 2017

avivey updated the task description for T6008: Editing files and contributing changes via web.
Aug 26 2017, 9:08 PM · Restricted Project, Wikimedia, Diffusion, Differential

Aug 24 2017

epriestley added a comment to T7789: Support Git Large File Storage.

See Planning for information on planning and timelines.

Aug 24 2017, 12:41 PM · Customer Impact, Restricted Project, Files, Diffusion
jkrets added a comment to T11030: Cannot clone public repository over HTTP anonymously..

I'm not sure it's a bug. The error message was surprising; HTTP/1.0 500 Error 1: sudo: a password is required. I see a matching error message in Q261. The solution there seems to be allowing the webserver process owner to have sudo rights. I now found there are docs on the subject diffusion_hosting#configuring-sudo.

Aug 24 2017, 11:59 AM · Diffusion, Bug Report
lazytiger added a comment to T7789: Support Git Large File Storage.
Aug 24 2017, 9:07 AM · Customer Impact, Restricted Project, Files, Diffusion

Aug 23 2017

epriestley added a comment to T11030: Cannot clone public repository over HTTP anonymously..

If you believe you've found a bug in Phabricator, please follow the instructions in Contributing Bug Reports to file a report.

Aug 23 2017, 6:01 PM · Diffusion, Bug Report
jkrets added a comment to T11030: Cannot clone public repository over HTTP anonymously..

This might be useful debugging information:

>> export GIT_CURL_VERBOSE=1
>> git clone http://phabricator.internal/diffusion/TRACTORAPI/tractor-api.git
Cloning into 'tractor-api'...
* Couldn't find host phabricator.internal in the .netrc file; using defaults
* About to connect() to phabricator.internal port 80 (#0)
*   Trying 10.11.45.21... * Connected to phabricator.internal (10.11.45.21) port 80 (#0)
> GET /diffusion/TRACTORAPI/tractor-api.git/info/refs?service=git-upload-pack HTTP/1.1
User-Agent: git/2.14.1
Host: phabricator.internal
Accept: */*
Accept-Encoding: gzip
Accept-Language: en-US, *;q=0.9
Pragma: no-cache
Aug 23 2017, 4:58 PM · Diffusion, Bug Report
remusvrm added a comment to T11030: Cannot clone public repository over HTTP anonymously..

This doesn't work again.

Aug 23 2017, 4:52 PM · Diffusion, Bug Report

Aug 22 2017

chad closed T12964: SSH Key adding workflows could use better UX, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 22 2017, 4:16 AM · Design, Diffusion
chad changed the status of T12823: Customization of Projects / Diffusion homepages, a subtask of T12824: Redesign Diffusion, from Resolved to Wontfix.
Aug 22 2017, 4:15 AM · Design, Diffusion
chad closed T12823: Customization of Projects / Diffusion homepages, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 22 2017, 4:14 AM · Design, Diffusion
chad added a revision to T12824: Redesign Diffusion: Restricted Differential Revision.
Aug 22 2017, 4:13 AM · Design, Diffusion

Aug 21 2017

chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

11" Macbook breakpoint is 1080 it looks, I think we still do tablet around 960? 1080 is enough space for anything we do. Not sure where @avivey 's laptop actually is. I do want to add more information to blame view though, so the space will be used.

Aug 21 2017, 8:56 PM · Diffusion, Design
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

I was joking.

Aug 21 2017, 8:47 PM · Diffusion, Design
epriestley added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Did you consider increasing the "tablet" breakpoint above the size of an 11" macbook instead?

Aug 21 2017, 8:45 PM · Diffusion, Design
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Just for @avivey and his 11" macbook: D18448

Aug 21 2017, 8:36 PM · Diffusion, Design
chad closed T12838: Make sure "state" is in new Branch view, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 21 2017, 4:09 PM · Design, Diffusion
chad closed T12838: Make sure "state" is in new Branch view as Resolved by committing Restricted Diffusion Commit.
Aug 21 2017, 4:09 PM · Design, Diffusion
chad added a revision to T12838: Make sure "state" is in new Branch view: Restricted Differential Revision.
Aug 21 2017, 3:55 PM · Design, Diffusion

Aug 17 2017

chad added a revision to T12838: Make sure "state" is in new Branch view: Restricted Differential Revision.
Aug 17 2017, 7:25 PM · Design, Diffusion
chad added a subtask for T12824: Redesign Diffusion: T12964: SSH Key adding workflows could use better UX.
Aug 17 2017, 2:25 AM · Design, Diffusion

Aug 16 2017

chad added a comment to T12838: Make sure "state" is in new Branch view.

neato!

Aug 16 2017, 10:52 PM · Design, Diffusion
epriestley added a comment to T12838: Make sure "state" is in new Branch view.

Yes. In Mercurial, branch heads may be "Open" or "Closed".

Aug 16 2017, 9:14 PM · Design, Diffusion
chad closed T12837: Make it clear you're browsing the history of a tag, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 16 2017, 7:16 PM · Design, Diffusion
chad closed T12837: Make it clear you're browsing the history of a tag as Resolved by committing Restricted Diffusion Commit.
Aug 16 2017, 7:16 PM · Design, Diffusion
chad added a revision to T12837: Make it clear you're browsing the history of a tag: Restricted Differential Revision.
Aug 16 2017, 7:16 PM · Design, Diffusion
chad added a comment to T12838: Make sure "state" is in new Branch view.

That the branch is closed?

Aug 16 2017, 7:15 PM · Design, Diffusion
chad added a comment to T12838: Make sure "state" is in new Branch view.

What is state here? I don't really remember what this was about, or if it's needed.

Aug 16 2017, 7:15 PM · Design, Diffusion
chad added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

Search is now in the header, see rP

Aug 16 2017, 1:47 AM · Diffusion, Design

Aug 15 2017

epriestley closed T11218: Differential advanced search: bucket/group by repository, a subtask of T9287: Working with many repositories, as Wontfix.
Aug 15 2017, 5:56 PM · Restricted Project, Restricted Project, Diffusion

Aug 14 2017

epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

@aubort, please use the community forum (see: Discourse) if you'd like to discuss this issue.

Aug 14 2017, 4:05 PM · Diffusion
aubort added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

+1 the problem is still here. There's no way for a end user to make it right without the need for an admin to go run a command on the server, which is not very good.

Aug 14 2017, 12:41 PM · Diffusion

Aug 12 2017

epriestley added a subtask for T12824: Redesign Diffusion: T929: Allow two arbitrary revisions to be compared in Diffusion.
Aug 12 2017, 10:52 AM · Design, Diffusion
epriestley merged task T12831: Update compare page with more features into T929: Allow two arbitrary revisions to be compared in Diffusion.
Aug 12 2017, 10:52 AM · Design, Diffusion
epriestley added a comment to T12831: Update compare page with more features.

I'm just going to merge this into T929, I don't think it's a distinct task. I'll link that to T12824.

Aug 12 2017, 10:52 AM · Design, Diffusion

Aug 11 2017

kojik1010 added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

adding my vote to @ivo's suggestion.

Aug 11 2017, 6:59 PM · Diffusion, Design
epriestley closed T4416: Drop "-u" flag from `hg pull` in daemons? as Resolved by committing Restricted Diffusion Commit.
Aug 11 2017, 2:15 AM · Mercurial, Diffusion
epriestley added a revision to T4416: Drop "-u" flag from `hg pull` in daemons?: Restricted Differential Revision.
Aug 11 2017, 12:49 AM · Mercurial, Diffusion

Aug 10 2017

chad closed T12832: Add autoclose table to Diffusion Manage as Resolved by committing Restricted Diffusion Commit.
Aug 10 2017, 8:26 PM · Design, Diffusion
chad closed T12832: Add autoclose table to Diffusion Manage, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 10 2017, 8:26 PM · Design, Diffusion
chad added a revision to T12832: Add autoclose table to Diffusion Manage: Restricted Differential Revision.
Aug 10 2017, 5:16 PM · Design, Diffusion
chad closed T12833: Credential workflow for URIs has spacing issues as Resolved by committing Restricted Diffusion Commit.
Aug 10 2017, 2:38 PM · Design, Diffusion
chad closed T12833: Credential workflow for URIs has spacing issues, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 10 2017, 2:38 PM · Design, Diffusion
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

The new rules on reports are still in flux a bit and extra-muddy for Community members, but I'd generally like to move to a "report + review" model for community reports, something like we currently have for code review. So the general idea is that your bug needs someone to review it and agree with it (e.g., reproduce a bug, or agree that a feature request is a brilliant new idea that makes sense and would be appropriate for the upstream and completely describes a reasonable, generally-experienced root problem) before it comes upstream.

Aug 10 2017, 11:47 AM · Bug Report, Diffusion
epriestley added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

I think this is a real bug. Here's a more complete example of what's going wrong, why it's wrong, and how to reproduce it.

Aug 10 2017, 11:09 AM · Bug Report, Diffusion
chad added a revision to T12833: Credential workflow for URIs has spacing issues: Restricted Differential Revision.
Aug 10 2017, 3:04 AM · Design, Diffusion

Aug 9 2017

chad added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

I would open to accepting this as a bug report if I felt it was deliberately designed to work the way you expect, but was not (like a regression). Or if information was presented that all other repository viewers do it this way. Otherwise I think it's more 'nitpick' or 'feature request'. A cursory look at GitHub, seems they show the full diff as well: https://github.com/phacility/phabricator/commit/5c1e4488dedafda08684b33a8a4786cf687d2811

Aug 9 2017, 11:07 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230805, @chad wrote:

In general are you aware we no longer take bug reports or feature requests here?

Aug 9 2017, 10:36 PM · Bug Report, Diffusion
chad added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

In general are you aware we no longer take bug reports or feature requests here?

Aug 9 2017, 10:28 PM · Bug Report, Diffusion
joshuaspence renamed T12959: Diffusion shows unexpected diff when an entire directory is removed from Diffusion shows mysterious diff when an entire directory is removed to Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:23 PM · Bug Report, Diffusion
joshuaspence added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.
In T12959#230799, @chad wrote:

What does "mysterious" mean.

Aug 9 2017, 10:21 PM · Bug Report, Diffusion
chad added a comment to T12959: Diffusion shows unexpected diff when an entire directory is removed.

What does "mysterious" mean.

Aug 9 2017, 10:20 PM · Bug Report, Diffusion
joshuaspence updated the task description for T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:13 PM · Bug Report, Diffusion
joshuaspence created T12959: Diffusion shows unexpected diff when an entire directory is removed.
Aug 9 2017, 10:12 PM · Bug Report, Diffusion
kmrhb added a comment to T8238: Formally support side-band change handoff in external repositories.

A possible mid-term solution is to use something like using refs which aren't "tags" (Like github's /refs/pulls/xxx); I think we've discussed it didn't like it because T8092 is desired for other things too.

Aug 9 2017, 2:27 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Aug 6 2017

chad closed T8874: Git push to hosted repository slow as Invalid.

Unclear if this is a feature request, bug report, or general question. Going to close out as it's old and not actionable.

Aug 6 2017, 3:44 AM · Diffusion
chad closed T12752: Pager in Diffusion doesn't tell you what page you're on as Resolved.
Aug 6 2017, 2:51 AM · Design, Diffusion
chad closed T12752: Pager in Diffusion doesn't tell you what page you're on, a subtask of T12824: Redesign Diffusion, as Resolved.
Aug 6 2017, 2:51 AM · Design, Diffusion
chad placed T5698: Github-style Remarkup previews on a checked-in resource up for grabs.
Aug 6 2017, 2:46 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Aug 1 2017

ivo added a comment to T12804: Diffusion pre-redesign UI feedback (June 2017).

In the past there used to be a Browse button at the repository homepage in Diffusion. Clicking on it would show the file tree for the current branch and some extra buttons. You could then click Search to grep the file contents of the current branch.

Aug 1 2017, 6:45 PM · Diffusion, Design
epriestley closed T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk as Resolved by committing Restricted Diffusion Commit.
Aug 1 2017, 3:57 PM · Diffusion
epriestley added a revision to T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk: Restricted Differential Revision.
Aug 1 2017, 3:53 PM · Diffusion

Jul 31 2017

epriestley created T12946: When users `bin/remove destroy` a repository, emit a reminder message about paths on disk.
Jul 31 2017, 9:07 PM · Diffusion
epriestley closed T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials as Resolved by committing Restricted Diffusion Commit.
Jul 31 2017, 4:43 PM · Diffusion
epriestley added a revision to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Restricted Differential Revision.
Jul 31 2017, 4:42 PM · Diffusion
epriestley added a project to T12945: "Mismatched origin" error on pulls may show credentials when origins have HTTP credentials: Diffusion.
Jul 31 2017, 2:07 PM · Diffusion

Jul 28 2017

epriestley added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

The simplest way to approach this is probably to do double writes: start writing the new tables, switch readers over, stop writing the old tables.

Jul 28 2017, 9:46 PM · Customer Impact, Diffusion, Bug Report
epriestley renamed T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs from "The ref "master" is ambiguous in this repository" in rP to Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.
Jul 28 2017, 6:37 PM · Customer Impact, Diffusion, Bug Report

Jul 27 2017

epriestley closed T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded. as Invalid.

This is vague and may not actually identify a problem; I don't plan to pursue it.

Jul 27 2017, 4:50 PM · Diffusion, Feature Request
epriestley closed T12291: Diffusion doesn't display file moves/renames in an easily consumable/reviewable way as Wontfix.

This seems to mostly be a matter of taste, and we already have behavior similar to the behavior of git, which seems reasonable.

Jul 27 2017, 4:28 PM · Diffusion, Feature Request

Jul 25 2017

epriestley closed T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories as Resolved by committing Restricted Diffusion Commit.
Jul 25 2017, 12:12 PM · Restricted Project, Clusters, Diffusion, Customer Impact

Jul 24 2017

chad closed T12931: Fallback for incorrect default branch in Diffusion could be nicer as Resolved by committing Restricted Diffusion Commit.
Jul 24 2017, 8:41 PM · Feature Request, Diffusion
epriestley added a revision to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories: Restricted Differential Revision.
Jul 24 2017, 6:43 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

See PHI14 for priority.

Jul 24 2017, 4:26 PM · Restricted Project, Clusters, Diffusion, Customer Impact
joshuaspence added a revision to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies: Restricted Differential Revision.
Jul 24 2017, 11:00 AM · Diffusion
joshuaspence added a comment to T12393: Instance reporting possible lock issue around `git fetch` of clustered working copies.

I am also seeing this error and am trying to work on a fix.

Jul 24 2017, 9:23 AM · Diffusion