Page MenuHomePhabricator
Feed Advanced Search

Mar 3 2017

epriestley merged T12345: Links in titles into T8845: Headings which resolve with markup become an `X` in Table of Contents on Wiki.
Mar 3 2017, 1:24 PM · libphutil, Remarkup
cspeckmim renamed T12344: Relative links to Phriction pages misinterprets URL-encoded characters from Relative links to Phriction pages mis-encode URL-encoded characters to Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:15 AM · Phriction, Remarkup, Bug Report
cspeckmim created T12344: Relative links to Phriction pages misinterprets URL-encoded characters.
Mar 3 2017, 3:13 AM · Phriction, Remarkup, Bug Report

Feb 23 2017

cspeckmim updated the task description for T12309: Differential comment that inlines a Paste and has code block after it renders in strange fashion.
Feb 23 2017, 2:22 AM · Remarkup, Bug Report
cspeckmim closed T12309: Differential comment that inlines a Paste and has code block after it renders in strange fashion as Invalid.

Ooh just kidding. ⌃+Refresh fixed everything

Feb 23 2017, 2:21 AM · Remarkup, Bug Report
cspeckmim created T12309: Differential comment that inlines a Paste and has code block after it renders in strange fashion.
Feb 23 2017, 2:20 AM · Remarkup, Bug Report

Feb 20 2017

bcooksley added a project to T5698: Github-style Remarkup previews on a checked-in resource: KDE.
Feb 20 2017, 10:01 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup

Feb 17 2017

avivey merged T12285: uml support into T3591: Render PlantUML syntax as macro in remarkup areas. .
Feb 17 2017, 12:10 PM · Remarkup
avivey changed the visibility for T3602: Provide some kind of "process this block with an interpreter" syntax to Remarkup.
Feb 17 2017, 12:04 PM · Remarkup
avivey changed the visibility for T3591: Render PlantUML syntax as macro in remarkup areas. .
Feb 17 2017, 11:59 AM · Remarkup

Feb 15 2017

chad updated subscribers of T12139: Add a proper emoji picker to Remarkup bar.

@beng pointed out this resource for future use: http://cldr.unicode.org/

Feb 15 2017, 9:16 PM · Remarkup, PHUI

Feb 13 2017

epriestley renamed T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks from Only evaluate newly added mentions when applying transactions to remarkup blocks to Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Feb 13 2017, 4:46 PM · Prioritized, Wikimedia, Remarkup
ofbeaton added a comment to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.

Can we please add the keyword subscribe or subscribers in this task title? I looked through 2 pages of subscribers search before filing a dup. I know now I was searching the wrong term, mention would have given it to me instead. But they are related.

Feb 13 2017, 4:11 PM · Prioritized, Wikimedia, Remarkup
epriestley merged T12254: re-subscribes on edit into T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
Feb 13 2017, 3:57 PM · Prioritized, Wikimedia, Remarkup
• sallyjackson added a comment to T11612: Remarkup - Support rendering of iterative expressions.
Feb 13 2017, 9:20 AM · Remarkup, Feature Request

Feb 12 2017

DemiMarie added a comment to T5301: Inline Remarkup escaping.

I see your point.

Feb 12 2017, 12:03 AM · Remarkup

Feb 11 2017

epriestley added a comment to T5301: Inline Remarkup escaping.

I think the complexity of those rules exceeds their utility.

Feb 11 2017, 12:42 AM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

What are your thoughts on allowing valid HTML entities through to the
browser without further escaping (outside of code blocks)? There seems to
be no reason to have them in text, and they could allow escaping.

Feb 11 2017, 12:22 AM · Remarkup

Feb 10 2017

epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

If you want to implement the rest of it with a ( trigger I can counter-diff you for a (( trigger.

Feb 10 2017, 2:53 PM · Phurl, Remarkup, Feature Request
chad added a comment to T12241: Make it easier to find objects while in remarkup box.

the trigger was the main thing preventing me from implementing phurl

Feb 10 2017, 2:51 PM · Phurl, Remarkup, Feature Request
epriestley added a project to T12241: Make it easier to find objects while in remarkup box: Phurl.
Feb 10 2017, 2:29 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

In the specific case of Phurl autocompletion, I'd be happy to review a change if someone wants to tackle it. The recent emoji autocompletion is probably a pretty good example to start from.

Feb 10 2017, 2:29 PM · Phurl, Remarkup, Feature Request
epriestley added a comment to T5951: Remarkup cannot properly link to Phriction pages with special characters in the title..

(It's still not possible to name a link X | Y, but I think we're no longer aware of any reasonable cases where this is important.)

Feb 10 2017, 2:26 PM · Remarkup
epriestley closed T5951: Remarkup cannot properly link to Phriction pages with special characters in the title. as Resolved.

I belive this was effectively resolved by changes connected to T7691. Specifically, if you had a page titled "A" at location "x", you previously needed to type [[ x | A ]] to get it to render the right link text. If you omitted the ... | A ... part, the link would just be named x.

Feb 10 2017, 2:25 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

What about triple backticks in code blocks? Code blocks can contain
anything, so I consider not being able to put three consecutive backticks
in them a bug.

Feb 10 2017, 2:18 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

Commentary on this is welcome, even just to say no it won't fly.

Feb 10 2017, 1:58 PM · Remarkup
epriestley merged T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment into T12241: Make it easier to find objects while in remarkup box.
Feb 10 2017, 1:54 PM · Phurl, Remarkup, Feature Request
epriestley merged task T11543: Provide an on-page workflow for searching for objects to reference while typing a Remarkup comment into T12241: Make it easier to find objects while in remarkup box.
Feb 10 2017, 1:54 PM · Restricted Project, Remarkup, Feature Request
epriestley added a comment to T12241: Make it easier to find objects while in remarkup box.

I think this is the same as T11543 but I'm going to merge that here since this one is a little cleaner. My current thinking:

Feb 10 2017, 1:53 PM · Phurl, Remarkup, Feature Request
avivey created T12241: Make it easier to find objects while in remarkup box.
Feb 10 2017, 12:13 PM · Phurl, Remarkup, Feature Request
rsmarples added a comment to T5301: Inline Remarkup escaping.

You're correct, using brackets makes the regex work, thanks.

Feb 10 2017, 12:31 AM · Remarkup

Feb 9 2017

epriestley added a comment to T5301: Inline Remarkup escaping.

For starters, this regex fails to work

Feb 9 2017, 10:33 PM · Remarkup
rsmarples added a comment to T5301: Inline Remarkup escaping.

T5397 is another copy of the pipes-in-tables issue.

You can use remarkup.ignored-object-names to prevent S3 from being marked up: S1 S2 S3 S4

Feb 9 2017, 10:20 PM · Remarkup

Feb 7 2017

chad added a comment to T5301: Inline Remarkup escaping.

That said, if it's open, we do plan to address it eventually.

Feb 7 2017, 4:04 AM · Remarkup
chad added a comment to T5301: Inline Remarkup escaping.

It sounds counter-intuitive, be the upstream prefers not to spend time on theoretical issues. Basically we have thousands of open tasks, and we complete them based on overall impact. Something hypothetically an issue isn't going to receive much attention.

Feb 7 2017, 4:00 AM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

What about triple backticks in code blocks? Code blocks can contain
anything, so I consider not being able to put three consecutive backticks
in them a bug.

Feb 7 2017, 3:51 AM · Remarkup

Feb 2 2017

epriestley updated the task description for T12191: Remarkup autocomplete can remain open after keyboard form submission.
Feb 2 2017, 4:24 PM · Remarkup, PHUI
epriestley created T12191: Remarkup autocomplete can remain open after keyboard form submission.
Feb 2 2017, 4:22 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Also I very probably meant "inline comment" and not "inline diff"

Feb 2 2017, 4:21 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Oh, I missed "inline". That reproduces for me. I'll file a separate issue.

Feb 2 2017, 4:20 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I do not have persistent chat open.

Feb 2 2017, 4:19 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Do you have persistent chat open?

Feb 2 2017, 4:18 PM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I came across a small bug with the "auto-suggest" feature. In differential I was writing an inline diff, and ended with :/ to show my face in plain ascii, and hit ⌘+⏎ immediately after to complete my inline diff. After typing :/ the auto-complete popped up and when I saved the draft with ⌘+⏎ it forever immortalized the auto-complete popup on screen with no seeming way to get rid of it (refreshing probably fixes~). I can reproduce on this install.

Feb 2 2017, 4:16 PM · Remarkup, PHUI

Feb 1 2017

DemiMarie added a comment to T5301: Inline Remarkup escaping.

T6143, while closed, seems to be a real-world use case to me.

Feb 1 2017, 2:16 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

All changes in Phabricator need to be driven by strong, real-world use-cases.

Feb 1 2017, 12:42 AM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

@epriestley I hope to fix this in a very general way, which will also solve many of the other tickets related to Remarkup (T6276, T5951, T5427).

Feb 1 2017, 12:17 AM · Remarkup

Jan 31 2017

epriestley merged T6002: Allow characters to be escaped in Remarkup into T5301: Inline Remarkup escaping.
Jan 31 2017, 11:46 PM · Remarkup
epriestley merged task T6002: Allow characters to be escaped in Remarkup into T5301: Inline Remarkup escaping.
Jan 31 2017, 11:46 PM · Remarkup
epriestley added a comment to T6002: Allow characters to be escaped in Remarkup.
Sample
cat file | grep something
Jan 31 2017, 11:45 PM · Remarkup
epriestley added a comment to T5301: Inline Remarkup escaping.

I'd like to see real use cases for this before pursuing it. In the use cases above:

Jan 31 2017, 11:45 PM · Remarkup
DemiMarie added a comment to T5301: Inline Remarkup escaping.

I'll take this and T6002. Where in Phabricator's source code can I find the relevant PHP code? Edit: Found it in libphutil.

Jan 31 2017, 11:13 PM · Remarkup

Jan 27 2017

mavit added a comment to T12139: Add a proper emoji picker to Remarkup bar.
In T12139#208563, @chad wrote:

If you're on linux, I think emojione extension likely only choice. What OS/Browser?

Jan 27 2017, 9:28 PM · Remarkup, PHUI

Jan 25 2017

cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

hmm everything seems in order

Jan 25 2017, 4:34 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Click here for 🐱

Jan 25 2017, 4:30 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

He's so little. :)

Jan 25 2017, 4:28 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

image.png (218×604 px, 34 KB)

Jan 25 2017, 4:27 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

These are still so painful on non-Safari

Jan 25 2017, 4:27 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Poor 🐈.

Jan 25 2017, 4:25 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

yup it works

Jan 25 2017, 4:24 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

💯

Jan 25 2017, 4:23 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I rolled the server for the bug testers.

Jan 25 2017, 4:23 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

🐱

🐱
🐱

🐱

🐱

🐱

Jan 25 2017, 4:22 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

🐈

🐈
🐈

🐈

🐈

🐈

Jan 25 2017, 4:21 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I guess I don't even have a glyph for :lion_face: anyway.

Jan 25 2017, 4:17 AM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 25 2017, 4:16 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I've already started the 2 minute arc diff process

Jan 25 2017, 4:16 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Also while you're in there maybe replace _ with (space) in the strings? I can't find :lion_face: by typing :fac... right now, but I think if you swap the underscores for spaces it will work. Then :cat should be able to find crying_cat_face and stuff, too.

Jan 25 2017, 4:15 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

not memorizing emoji collation order in 2017 pfft

Jan 25 2017, 4:14 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

FINE IT IS MY FAULT

Jan 25 2017, 4:13 AM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

The list is sorted by emoji. 🐈 is "alphabetically" earlier than 🐱 in the list of emoji.

Jan 25 2017, 4:12 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

cats are naturally dubious so i'm not surprised

Jan 25 2017, 4:05 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

image.png (548×712 px, 60 KB)

Jan 25 2017, 4:05 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I can't figure out the sort thing, don't think it's an emoji issue.

Jan 25 2017, 4:02 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

sort by awesome, descending

Jan 25 2017, 12:57 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Cat2 is twice as good as Cat

Jan 25 2017, 12:56 AM · Remarkup, PHUI
cspeckmim added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Typing :cat will list the cat2 emoji before cat
🐱

Screen Shot 2017-01-24 at 7.54.31 PM.png (434×768 px, 47 KB)

Jan 25 2017, 12:55 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Found the Chrome issue / Mac: https://bugs.chromium.org/p/chromium/issues/detail?id=551420

Jan 25 2017, 12:26 AM · Remarkup, PHUI

Jan 24 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

@johnny-bit I had good luck using https://chrome.google.com/webstore/detail/chromoji-emojis-for-googl/negakbijaemdgbhklopmghphgaeadmpo on Ubuntu/Chrome.

Jan 24 2017, 6:05 PM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 24 2017, 6:05 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

If you're on linux, I think emojione extension likely only choice. What OS/Browser?

Jan 24 2017, 4:45 PM · Remarkup, PHUI
johnny-bit added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Oh, woe is me, for there are no colours in my emoji. One thing to notice though - where can I find that beautiful emoji example in ui examples? Would be cool place to check for emoji support on different browsers/platforms :)

Jan 24 2017, 10:00 AM · Remarkup, PHUI
avivey added a comment to T12139: Add a proper emoji picker to Remarkup bar.

wow! the beautiful colors!

Jan 24 2017, 8:58 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (1×1 px, 430 KB)

Jan 24 2017, 4:11 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

@avivey let me know how this looks now

Jan 24 2017, 2:03 AM · Remarkup, PHUI
chad added a revision to T12139: Add a proper emoji picker to Remarkup bar: Restricted Differential Revision.
Jan 24 2017, 12:41 AM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

https://www.tjvantoll.com/2016/06/15/emoji-on-windows/

Jan 24 2017, 12:00 AM · Remarkup, PHUI

Jan 23 2017

chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Well, not non-existent, just black and white line art.

Jan 23 2017, 11:37 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Yeah emoji on Windows is non-existent still. At least, on Windows 10 Chrome / Firefox / Edge it's just what @avivey posted above.

Jan 23 2017, 11:37 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Crazy

Jan 23 2017, 7:37 PM · Remarkup, PHUI
avivey added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (309×603 px, 46 KB)

(Chrome on Windows 10)

Jan 23 2017, 7:29 PM · Remarkup, PHUI
johnny-bit added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Pros

  • Users on old versions of Windows or who compiled their own Gentoo don't have occasional missing/fallback emoji.
  • Users see the same picture of a smiling cat instead of different pictures of smiling cats.
Jan 23 2017, 6:27 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

If I can get most places to appear like Safari shows them, this will probably be good for a v1. The reason I like EmojiOne is mostly aesthetic, they are less busy visually (flatter) and are easier to determine what they are individually. I can also control the size. Let me futz with our emoji remarkup rule and see if I can normalize the display better. Though, not sure that's really possible still given Google search results.

Jan 23 2017, 6:05 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Chrome/Firefox seems to be shrinking them smaller. I think we can maybe cheat that with font-size and the emoji remarkup rule...

Jan 23 2017, 5:59 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

pasted_file (552×1 px, 195 KB)

Jan 23 2017, 5:57 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

This is what I see on my Macbook in Safari:

Jan 23 2017, 5:57 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

oh man, at least in Safari they look way better.

Jan 23 2017, 5:57 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

I believe Firefox is adopting EmojiOne. If I could CSS style the emojis, it would help. I find them small and hard to identify in text. Basic ones like ❤️ are easy, but all the different emotions are somewhat harder. 😁 vis. 😂 really are hard for me to visually focus on (and on my laptop, which is smaller dpi, is even harder).

Jan 23 2017, 5:52 PM · Remarkup, PHUI
epriestley added a comment to T12139: Add a proper emoji picker to Remarkup bar.

Emoji look terrible on nearly every platform / browser

Jan 23 2017, 5:41 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

phurl autocomplete might be nice too

Jan 23 2017, 5:00 PM · Remarkup, PHUI
chad added a comment to T12139: Add a proper emoji picker to Remarkup bar.

All I've learned is:

Jan 23 2017, 4:55 PM · Remarkup, PHUI