Page MenuHomePhabricator
Feed Advanced Search

Mar 8 2016

epriestley added a revision to T10538: Bridge GitHub to Phabricator: Unknown Object (Differential Revision).
Mar 8 2016, 4:29 PM · Nuance, GitHub
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 2:41 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 2:09 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 1:19 PM · Nuance (v1)
epriestley added a comment to T10419: Sample herald rule results.

Is this rule a lint-like rule, in the vein of T7617? See also T10523 for discussion of lint-like rules.

Mar 8 2016, 12:23 PM · Herald, Feature Request
joshuaspence awarded T10538: Bridge GitHub to Phabricator a Like token.
Mar 8 2016, 9:39 AM · Nuance, GitHub
nateguchi2 awarded T10538: Bridge GitHub to Phabricator a Grey Medal token.
Mar 8 2016, 7:40 AM · Nuance, GitHub
chad awarded T10538: Bridge GitHub to Phabricator a Baby Tequila token.
Mar 8 2016, 2:27 AM · Nuance, GitHub
michaeljs1990 awarded T10538: Bridge GitHub to Phabricator a Like token.
Mar 8 2016, 2:23 AM · Nuance, GitHub
tycho.tatitscheff awarded T10538: Bridge GitHub to Phabricator a Love token.
Mar 8 2016, 2:03 AM · Nuance, GitHub
epriestley updated subscribers of T10436: Enhance the API (project.query) to find parent- and/or subprojects.
Mar 8 2016, 1:52 AM · Restricted Project, Projects, Feature Request
epriestley merged task T10540: project.query API does not give information about parent projects into T10436: Enhance the API (project.query) to find parent- and/or subprojects.
Mar 8 2016, 1:52 AM · Projects, Bug Report
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 12:33 AM · Nuance (v1)
epriestley added a comment to T6848: It should be possible to view a repository's policies without necessarily being able to edit it.

Yeah, I think the existing "Edit" page should really be more like the "Manage" page in Projects that anyone who can see the repository can see.

Mar 8 2016, 12:31 AM · Diffusion (v3)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 8 2016, 12:15 AM · Nuance (v1)
cburroughs awarded T10538: Bridge GitHub to Phabricator a Pterodactyl token.
Mar 8 2016, 12:01 AM · Nuance, GitHub
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

If anyone else set up a cron job or similar to keep a staging area with a fresh master, you should be able to throw it away after users upgrade past T10509. That task has some details.

Mar 8 2016, 12:01 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Aha! That makes sense, thanks for digging into it!

Mar 8 2016, 12:00 AM · Harbormaster (v3), Diffusion, Arcanist

Mar 7 2016

epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 7 2016, 11:25 PM · Nuance (v1)
epriestley added a revision to T10537: Nuance Infrastructure: Unknown Object (Differential Revision).
Mar 7 2016, 11:20 PM · Nuance (v1)
epriestley created T10538: Bridge GitHub to Phabricator.
Mar 7 2016, 11:12 PM · Nuance, GitHub
epriestley changed the edit policy for T8783: Unprototype Nuance (v1).
Mar 7 2016, 11:09 PM · Nuance, Restricted Project
epriestley changed the edit policy for T10537: Nuance Infrastructure.
Mar 7 2016, 11:08 PM · Nuance (v1)
epriestley created T10537: Nuance Infrastructure.
Mar 7 2016, 11:08 PM · Nuance (v1)
epriestley added a comment to T10536: Allow members of a project to create subprojects.

If the motivation is primarily social, you might be able to use a social permission:

Mar 7 2016, 10:58 PM · Restricted Project, Projects, Feature Request
epriestley added a comment to T10536: Allow members of a project to create subprojects.

Part of the pathway forward here may also be to reduce the prominence of subprojects in typeaheads/lists, or reduce it conditionally or something.

Mar 7 2016, 10:41 PM · Restricted Project, Projects, Feature Request
epriestley added a comment to T10536: Allow members of a project to create subprojects.

This is currently intended, although I think it's not out of the question that we might relax it or otherwise take another look at it.

Mar 7 2016, 10:32 PM · Restricted Project, Projects, Feature Request
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

Awesome, thanks!

Mar 7 2016, 9:26 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a comment to T10535: Workboard view of tasks should hide Tags that are in the filter to save space.

This is probably at least somewhat reasonable, and we do something vaguely similar in the Maniphest list view.

Mar 7 2016, 8:37 PM · Workboards, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

I'm a little worried that doesn't make for a great out of the box or support experience since almost anything interesting will require extensions, but that is basically the case anyway today.

Mar 7 2016, 7:25 PM · Harbormaster, Restricted Project, Feature Request
epriestley renamed T10517: Make Harbormaster build variables extensible from Permit access to repository "Short Name" from harbormaster. to Make Harbormaster build variables extensible.
Mar 7 2016, 7:08 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

Is it reasonable for this value to be part of the job name?

Mar 7 2016, 7:04 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

Maybe this is a better question: if someone else files a similar task saying that the repository projects or date created or full list of tags or default branch would help them glue to Jenkins/Travis/Hudson, when should I say "yes" or "no"?

Mar 7 2016, 6:44 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

I don't want to add upstream build variables in every case where they'd make things more convenient for someone, since that could get out of hand quickly.

Mar 7 2016, 6:37 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

how to make the job smart enough to call back

Mar 7 2016, 6:34 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

Yeah, my expectation is that whatever's on the Jenkins side needs to know about Phabricator, because it needs to call harbormaster.sendmessage to report results when it's done. So it seems like the job has to be some-harbormaster-aware-build, and like it should be able to look up the repository name without undue work, as it already needs to know how to call Conduit.

Mar 7 2016, 6:14 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

Why is the approach used by Uber's Jenkins/Phabricator Plugin (which does not require repository.name) unsuitable in your situation?

Mar 7 2016, 6:02 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

Since that sounds possibly plausible, I'll confirm that timeouts end up looking like this in the UI, and repurpose this for "make timeouts readable to humans" if they do. I can dig into it some more if that turns out to be a dead end.

Mar 7 2016, 5:56 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

You control that API though, right? And could conceivably expose /harbormaster/job/{repository-phid}/ or whatever?

Mar 7 2016, 5:54 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10517: Make Harbormaster build variables extensible.

If diffusion.search existed, you could call it with repository.phid to pull the short name, callsign, ID, etc. Would this be sufficient?

Mar 7 2016, 5:37 PM · Harbormaster, Restricted Project, Feature Request
epriestley added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

Also known as the far more hilarious CURLE_OPERATION_TIMEOUTED.

Mar 7 2016, 5:35 PM · Restricted Project, Harbormaster, Bug Report
epriestley added a comment to T10510: Harbormaster failing to trigger Jenkins build through HTTP GET and producing abnormal HTTP error code .

This may be cURL 28, CURLE_OPERATION_TIMEDOUT. We have a 60-second timeout on this build step. Is it possible your server requires more than 60s to acknowledge the initial request?

Mar 7 2016, 5:34 PM · Restricted Project, Harbormaster, Bug Report
epriestley renamed T10512: Implement `user.search` Conduit API method from conduit API to search for users based on roles to Implement `user.search` Conduit API method.
Mar 7 2016, 5:33 PM · Prioritized, Restricted Project, People, Conduit, Feature Request
epriestley added a comment to T10520: Allow users to add other users as CC at countdown.

That is, it already supports subscribers, the field just never got built in the UI.

Mar 7 2016, 5:32 PM · Countdown, Feature Request
epriestley added a comment to T10520: Allow users to add other users as CC at countdown.

We probably will build this sooner or later since it's free when Countdown eventually swaps to EditEngine.

Mar 7 2016, 5:32 PM · Countdown, Feature Request
epriestley closed T10523: Herald Differential Diffs rule for "Added files". as Wontfix.

Sounds good. I'm going to close this out since we don't plan to pursue the particular rule it describes and I think other related work is already covered elsewhere.

Mar 7 2016, 5:30 PM · Restricted Project, Herald, Feature Request
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15427, this should be pretty clear for "Land Revision".

Mar 7 2016, 5:27 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley moved T6848: It should be possible to view a repository's policies without necessarily being able to edit it from Backlog to v3 on the Diffusion board.
Mar 7 2016, 5:24 PM · Diffusion (v3)
epriestley closed T6983: Best practices for repository creation as Resolved.

Importing SVN repositories as single repositories is recommended (Facebook's had several million commits in 2011, IIRC).

Mar 7 2016, 5:21 PM · Documentation, Diffusion
epriestley updated subscribers of T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion (v3)
epriestley merged task T10534: No ability to view push permissions without edit rights. into T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Mar 7 2016, 5:19 PM · Diffusion, Feature Request
epriestley closed T5929: User copied a working copy over a Diffusion working copy and nothing worked anymore as Wontfix.

This hasn't happened again and I think it's less reasonable to expect it to work in modern Phabricator.

Mar 7 2016, 5:18 PM · Diffusion
epriestley added a comment to T3607: Diffusion should raise a reasonable error when the default branch does not exist.

I think this was resolved at some point -- this is the behavior at HEAD, which seems broadly reasonable:

Mar 7 2016, 5:17 PM · Diffusion
epriestley added a comment to T8612: Improve handling of "large" changesets.

See also T2225 for a concrete issue caused by showing enormous numbers of paths (unbearably slow page loads because of the raw wire filesize).

Mar 7 2016, 5:14 PM · Restricted Project, Performance, Differential
epriestley closed T2225: Render only the first 1,000 changed paths by default when viewing a commit in Diffusion as Resolved.

This was fixed a couple of years ago in D4730, and works fine on the modern LLVM install: http://reviews.llvm.org/rL170845

Mar 7 2016, 5:13 PM · Differential, Diffusion
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 7 2016, 4:49 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 7 2016, 3:15 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a comment to T10093: When builds fail because the staging area was not pushed, make the cause clear.

After D15424, arc fails when failing to push the staging area.

Mar 7 2016, 2:55 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote, a subtask of T8238: Formally support side-band change handoff in external repositories, as Resolved.
Mar 7 2016, 2:53 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley closed T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote as Resolved by committing Restricted Diffusion Commit.
Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a comment to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote.

I've marked D15424 as fixing this, although I don't have a detailed understanding of exactly what goes on in the git protocol and which heuristics it is using. In particular, I haven't been able to trick it into doing too much work locally (maybe it also looks at parents?).

Mar 7 2016, 2:53 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley added a revision to T10509: When pushing changes to a staging area, also push the nearest ancestor present in the remote: Unknown Object (Differential Revision).
Mar 7 2016, 2:27 PM · Harbormaster (v3), Diffusion, Arcanist
epriestley closed T10528: Option+Click function in Differential doesn't always link to the correct line in Diffusion. as Resolved.

This is on a daily cron, I think you missed the update by a couple of hours. Link works OK for me now.

Mar 7 2016, 1:28 PM · Diffusion, Differential, Bug Report
epriestley added a comment to T10530: Exception: Cursor "11972" does not identify a valid object in query "DiffusionCommitQuery"..

Hi! How can we reproduce this behavior?

Mar 7 2016, 1:27 PM · Audit, Diffusion, Bug Report
epriestley closed T10531: Make workboard column headers into clickable links as Wontfix.

Please describe the root problem you're facing when requesting features. See Contributing Feature Requests and Describing Root Problems for details.

Mar 7 2016, 1:25 PM · Feature Request
epriestley closed T10532: Test 100 as Spite.
Mar 7 2016, 1:23 PM · Bug Report
dans awarded T4103: Implement "Role Profiles" to provide search, homepage and application defaults a Like token.
Mar 7 2016, 4:45 AM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley closed T10527: Almanac User Guide Typo as Resolved.
Mar 7 2016, 12:03 AM · Bug Report

Mar 6 2016

epriestley added a revision to T10093: When builds fail because the staging area was not pushed, make the cause clear: Unknown Object (Differential Revision).
Mar 6 2016, 11:37 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request
epriestley added a revision to T6861: PHP sort function is unpredictable to human minds when dealing with mixed types: Unknown Object (Differential Revision).
Mar 6 2016, 3:57 PM · Infrastructure
featherless awarded T10038: Plan the mid-term pathway for unit-test/linter bindings a Like token.
Mar 6 2016, 2:46 AM · Lint, Arcanist

Mar 5 2016

epriestley closed T10519: no email sent for inline comments on a Diffusion commit as Resolved by committing Restricted Diffusion Commit.
Mar 5 2016, 10:18 PM · Mail, Diffusion, Bug Report
epriestley added a comment to T10519: no email sent for inline comments on a Diffusion commit.

Thanks for the report! This was a bug.

Mar 5 2016, 9:57 PM · Mail, Diffusion, Bug Report
epriestley claimed T10519: no email sent for inline comments on a Diffusion commit.
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
epriestley added a revision to T10519: no email sent for inline comments on a Diffusion commit: Unknown Object (Differential Revision).
Mar 5 2016, 9:55 PM · Mail, Diffusion, Bug Report
epriestley added a comment to T10523: Herald Differential Diffs rule for "Added files"..

I believe this wouldn't solve your problem: I could add two files, A.c and B.c, and add a header to only one. This would pass the rule but fail what you intend to enforce, I think.

Mar 5 2016, 9:12 PM · Restricted Project, Herald, Feature Request
epriestley removed a member for Transactions: • Rockcena.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: joshuaspence.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: btrahan.
Mar 5 2016, 4:20 PM
epriestley removed a member for Transactions: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a watcher for Transactions: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • peter_england.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: murphy.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • altman.jiri.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: joshuaspence.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • aderumier.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: • vipinngupta15.
Mar 5 2016, 4:20 PM
epriestley removed a member for Almanac: epriestley.
Mar 5 2016, 4:19 PM
epriestley removed a watcher for Almanac: • Persona.
Mar 5 2016, 4:19 PM
epriestley removed a watcher for Almanac: • peter_england.
Mar 5 2016, 4:19 PM
epriestley added a comment to T10521: Properties table on Almanac bindings is a little out of wahck.

oh, you also have to put an interface on the device in order to bind it

Mar 5 2016, 4:19 PM · Almanac
epriestley added a comment to T10521: Properties table on Almanac bindings is a little out of wahck.

Create any device, create any service, bind the service to the device, then click "Details":

Mar 5 2016, 4:16 PM · Almanac
epriestley updated subscribers of T10246: Deploy Drydock in the Phacility cluster.

Drydock and Almanac are now available in the cluster. Here's a rough guide to configuring them -- I'll turn this into something formal once things work a little more smoothly.

Mar 5 2016, 3:41 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley created T10522: Build plan page doesn't warn about unapproved Drydock blueprints.
Mar 5 2016, 3:18 PM · Drydock, Restricted Project, Harbormaster (v3)
epriestley created T10521: Properties table on Almanac bindings is a little out of wahck.
Mar 5 2016, 2:58 PM · Almanac
Luke081515.2 awarded Blog Post: Development Notes (2016 Week 10) a Love token.
Mar 5 2016, 11:34 AM
epriestley edited the content of Changelog.
Mar 5 2016, 2:31 AM
epriestley created 2016 Week 10 (Early March).
Mar 5 2016, 2:31 AM
epriestley published Blog Post: Development Notes (2016 Week 10).
Mar 5 2016, 2:30 AM
epriestley created T10518: Adjustments to tags in HeaderView breaks workboard "point" tags.
Mar 5 2016, 2:03 AM · Workboards, Maniphest