Page MenuHomePhabricator
Feed Advanced Search

Feb 13 2016

epriestley published Blog Post: Development Notes (2016 Week 7).
Feb 13 2016, 12:19 AM
epriestley added a comment to T10333: Add groups to workboard columns.

If so, how do I assign something to a member (or whomever) who doesn't yet/right now have a shown task?

Feb 13 2016, 12:05 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

That is, this is a valid column:

Feb 13 2016, 12:01 AM · Restricted Project, Restricted Project, Workboards (v3)

Feb 12 2016

epriestley added a comment to T10333: Add groups to workboard columns.

There's some argument for showing more headers than the actual assignees, so you can assign a task to someone with no tasks currently assigned.

Feb 12 2016, 11:55 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley updated the post content for Blog Post: Updates to Workboards: Dragging, Cover Photos and Points.
Feb 12 2016, 11:49 PM · Workboards, Maniphest
epriestley updated the post content for Blog Post: Updates to Workboards: Dragging, Cover Photos and Points.
Feb 12 2016, 11:44 PM · Workboards, Maniphest
chad awarded Blog Post: Updates to Workboards: Dragging, Cover Photos and Points a Love token.
Feb 12 2016, 11:43 PM · Workboards, Maniphest
epriestley updated the post content for Blog Post: Updates to Workboards: Dragging, Cover Photos and Points.
Feb 12 2016, 11:43 PM · Workboards, Maniphest
epriestley created Blog Post: Updates to Workboards: Dragging, Cover Photos and Points.
Feb 12 2016, 11:42 PM · Workboards, Maniphest
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

Haha. I really do think "suggest a profile picture" might turn out to be pretty fun. Maybe I'll kick out that and {button} if I want to take a break before doing callsigns.

Feb 12 2016, 11:23 PM · Projects (v3)
epriestley added a comment to T6641: Support changing default sort of a workboard.

@kaldari Most of this ticket is asking for "save priority as the default order" and/or "save 'open tasks' as the default filter" or something similar. Those were implemented by D15260, and are now supported. You can see them in action on this install, and D15260 has a couple of screenshots of the feature.

Feb 12 2016, 11:21 PM · Projects, Workboards
epriestley added a comment to T10339: Figure out the UI for Maniphest task search by points.

I suppose that typing Points between [2] and [3.9999999999] is probably an acceptable workaround for expressing the range [2, 4) if anyone does come up with a use case that requires exclusive ranges.

Feb 12 2016, 10:41 PM · Maniphest
epriestley added a comment to T10339: Figure out the UI for Maniphest task search by points.

Thanks, that's helpful. That's pretty much what I figured, and it's reassuring that no one has come up with "exactly 3, 5, or 11 points" use cases, or use cases that require a mixture of inclusive and exclusive ranges, at least so far.

Feb 12 2016, 10:34 PM · Maniphest
epriestley added a comment to T10350: Scripts to migrate old "points" fields and move projects beneath other projects.

My tentative plan here is to write a script that does it and make it available in this task. I want to do this a bit on this install too, mostly so we can have better direct exposure to these features ourselves.

Feb 12 2016, 10:33 PM · Projects (v3)
epriestley added a comment to T10349: Projects v3 Errata.

Yeah, why don't you file a separate task for the importer thing. I saw https://phabricator.wikimedia.org/T123078 on WMF recently, too. I think there will probably be enough demand for this to bring something formal upstream, but maybe only a few installs care (or everyone has different weird requirements) and we can just throw a script up somewhere and not have to maintain it.

Feb 12 2016, 10:20 PM · Restricted Project, Projects (v3)
epriestley updated the task description for T10349: Projects v3 Errata.
Feb 12 2016, 10:08 PM · Restricted Project, Projects (v3)
epriestley added a comment to T10346: Workboards some how have many empty workboards, which did not get added.

At HEAD:

Feb 12 2016, 10:00 PM · Workboards, Bug Report
epriestley closed T10346: Workboards some how have many empty workboards, which did not get added as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 9:59 PM · Workboards, Bug Report
epriestley claimed T10346: Workboards some how have many empty workboards, which did not get added.
Feb 12 2016, 9:59 PM · Workboards, Bug Report
epriestley added a comment to T10346: Workboards some how have many empty workboards, which did not get added.

they never existed before when I originally imported their workboards

Feb 12 2016, 9:59 PM · Workboards, Bug Report
epriestley added a revision to T10346: Workboards some how have many empty workboards, which did not get added: Unknown Object (Differential Revision).
Feb 12 2016, 9:57 PM · Workboards, Bug Report
epriestley moved T10349: Projects v3 Errata from Backlog to Evan on the Projects (v3) board.
Feb 12 2016, 9:52 PM · Restricted Project, Projects (v3)
epriestley closed T10010: Implement Subprojects as Resolved.

This is now substantially complete.

Feb 12 2016, 9:51 PM · Projects (v3)
epriestley closed T3670: Add subprojects as Resolved.

This is now substantially complete.

Feb 12 2016, 9:50 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley closed T3670: Add subprojects, a subtask of T6579: Display hovercards on Tokens in Typeaheads, as Resolved.
Feb 12 2016, 9:50 PM · Hovercards, PHUI
epriestley closed T3670: Add subprojects, a subtask of T6634: Typeahead default should maybe be more than 5, as Resolved.
Feb 12 2016, 9:50 PM · Typeahead, Maniphest
epriestley closed T9378: Build Projects v3 as Resolved.

This is now substantially complete.

Feb 12 2016, 9:49 PM · Projects (v3), Prioritized
epriestley updated the task description for T10349: Projects v3 Errata.
Feb 12 2016, 9:47 PM · Restricted Project, Projects (v3)
epriestley created T10349: Projects v3 Errata.
Feb 12 2016, 9:28 PM · Restricted Project, Projects (v3)
epriestley closed T10347: Have Milestone autocreate be more magical as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 7:04 PM · Projects (v3)
epriestley closed T10285: Can't typeahead a Project Milestone as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 7:03 PM · Projects (v3), Bug Report
epriestley added a revision to T10347: Have Milestone autocreate be more magical: Unknown Object (Differential Revision).
Feb 12 2016, 6:59 PM · Projects (v3)
epriestley added a comment to T10348: "Undefined variable: default_phid" when open Workboard.

If you updated two hours ago, you should be ahead of c2502f1, which is about 50 hours old. We've made about 30 changes between c2502f1 and HEAD, which you can see here:

Feb 12 2016, 6:47 PM · Workboards, Bug Report
epriestley closed T10348: "Undefined variable: default_phid" when open Workboard as Invalid.

Update to HEAD. This was fixed by D15232.

Feb 12 2016, 6:34 PM · Workboards, Bug Report
epriestley added a comment to T10347: Have Milestone autocreate be more magical.

I don't think we can guess right for stuff like "Version 6.5" or "Sprint 4/31" without doing a lot of work, since "add 1 to any numbers" won't work in those cases.

Feb 12 2016, 6:32 PM · Projects (v3)
epriestley added a comment to T4631: Allow Differential to raise warnings on the server side via Conduit.

This may make more sense via whatever comes of T10329.

Feb 12 2016, 5:23 PM · Restricted Project, Arcanist, Differential
epriestley added a revision to T10285: Can't typeahead a Project Milestone: Unknown Object (Differential Revision).
Feb 12 2016, 5:10 PM · Projects (v3), Bug Report
epriestley added a comment to T10285: Can't typeahead a Project Milestone.

For now, I'm just going to do this:

Feb 12 2016, 5:01 PM · Projects (v3), Bug Report
epriestley moved T10285: Can't typeahead a Project Milestone from Backlog to Evan on the Projects (v3) board.
Feb 12 2016, 4:56 PM · Projects (v3), Bug Report
epriestley added a comment to T10310: Column Name is Required exception when trying to hide a Milestone Column.

I think this should all work properly and consistently now, let me know if anyone finds a way to break it.

Feb 12 2016, 4:22 PM · Projects (v3), Bug Report
epriestley closed T10310: Column Name is Required exception when trying to hide a Milestone Column as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 4:10 PM · Projects (v3), Bug Report
epriestley added a comment to T10264: git clone using http hangs after update.

I believe this is now fixed at HEAD of master. It should promote to stable tomorrow morning.

Feb 12 2016, 4:09 PM · Bug Report, Diffusion
epriestley closed T10264: git clone using http hangs after update as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 4:09 PM · Bug Report, Diffusion
epriestley closed T6641: Support changing default sort of a workboard as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 3:47 PM · Projects, Workboards
epriestley added a revision to T6641: Support changing default sort of a workboard: Unknown Object (Differential Revision).
Feb 12 2016, 2:42 PM · Projects, Workboards
epriestley added a comment to T6641: Support changing default sort of a workboard.

Digging into https://phabricator.wikimedia.org/T76913, I think the actual request there was ultimately not per-board stickiness or per-user stickiness ("the menu remembers the last thing you set it to, and remains set to that if you close and reopen the window"), but an option to save particular filters into the filter menu ("Save a particular filter as 'No Patches Yet' and add it as an option to the filter menu for all users").

Feb 12 2016, 2:40 PM · Projects, Workboards
epriestley claimed T10310: Column Name is Required exception when trying to hide a Milestone Column.
Feb 12 2016, 2:20 PM · Projects (v3), Bug Report
epriestley added a revision to T10264: git clone using http hangs after update: Unknown Object (Differential Revision).
Feb 12 2016, 12:25 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Awesome, thanks for testing! I think this should be an easy fix, now.

Feb 12 2016, 12:12 PM · Bug Report, Diffusion
robertkraig awarded T9378: Build Projects v3 a Love token.
Feb 12 2016, 10:58 AM · Projects (v3), Prioritized
epriestley closed T10343: Reconsider autoassign-on-close behavior in Maniphest as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 4:44 AM · Maniphest
epriestley added a revision to T10343: Reconsider autoassign-on-close behavior in Maniphest: Unknown Object (Differential Revision).
Feb 12 2016, 4:33 AM · Maniphest
epriestley added a comment to T10343: Reconsider autoassign-on-close behavior in Maniphest.

Not directly -- I'm just digging through the Phabricator board on WMF to try to catch issues before they happen, since they have a Big Update happening soon.

Feb 12 2016, 3:41 AM · Maniphest
epriestley created T10343: Reconsider autoassign-on-close behavior in Maniphest.
Feb 12 2016, 3:33 AM · Maniphest
epriestley added a comment to T4427: Add formal task points.

That seems reasonable, I filed T10339 to follow up.

Feb 12 2016, 2:39 AM · Wikimedia, Workboards, Maniphest
epriestley created T10339: Figure out the UI for Maniphest task search by points.
Feb 12 2016, 2:39 AM · Maniphest
epriestley edited projects for T10264: git clone using http hangs after update, added: Bug Report; removed Bug Report (Needs Information).
Feb 12 2016, 2:24 AM · Bug Report, Diffusion
epriestley renamed T10337: Implement `diffusion.search` and think about `diffusion.edit` from Supporting custom fields for repositories and/or query projects for repositories and/or vice-versa to Implement `diffusion.search` and think about `diffusion.edit`.
Feb 12 2016, 2:23 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

I'm just going to co-opt this as a subtask for that piece since you already tagged it so nicely.

Feb 12 2016, 2:21 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley closed T10338: test as Invalid.
IMPORTANT: This is not a demo or test install. Please don't make a mess. You can launch a demo install on Phacility if you want to poke around and try things out.
Feb 12 2016, 2:08 AM · Feature Request
epriestley closed T4427: Add formal task points as Resolved.

These now exist. Enable them with maniphest.points.

Feb 12 2016, 2:07 AM · Wikimedia, Workboards, Maniphest
epriestley closed T4427: Add formal task points, a subtask of T5885: Optional limits to Workboard columns (number of cards), as Resolved.
Feb 12 2016, 2:07 AM · Workboards
epriestley added a comment to T10333: Add groups to workboard columns.

We could do the whole-column thing, but I worry it would be confusing / not useful.

Feb 12 2016, 1:49 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

Here's the feature I'm thinking about:

Feb 12 2016, 1:40 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

Oh, wait. Maybe we're talking about different things. Let me draw a picture.

Feb 12 2016, 1:38 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

Absolutely not ever implementing that, because it allows a card to appear multiple times in the same column and requires me to rewrite all the workboard code again.

Feb 12 2016, 1:37 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T4427: Add formal task points: Unknown Object (Differential Revision).
Feb 12 2016, 1:36 AM · Wikimedia, Workboards, Maniphest
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

(This is adjacent to T4245 and should be happening fairly soon -- next big-ticket item I'm currently planning to hit after subprojects/workboards calm down.)

Feb 12 2016, 1:12 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

Oh, and make sure you restart fully after changing the code -- I suspect that might have been the cause of the revert not fixing things earlier. Here's a guide if you aren't sure how:

Feb 12 2016, 1:09 AM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Can anyone who is able to reproduce this let me know if this fixes it?

Feb 12 2016, 1:07 AM · Bug Report, Diffusion
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

This will be supported by diffusion.search out of T5873. See also T10329.

Feb 12 2016, 1:05 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley removed a member for Workboards: saper.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: mikn.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: waynea.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: joshuaspence.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: iPublicis.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: btrahan.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: chad.
Feb 12 2016, 12:13 AM
epriestley removed a member for Workboards: epriestley.
Feb 12 2016, 12:13 AM
epriestley claimed T6641: Support changing default sort of a workboard.
Feb 12 2016, 12:11 AM · Projects, Workboards
epriestley added a comment to T6641: Support changing default sort of a workboard.

I'm think just going to put a "Save Current as Default" or similar at the bottom of the menu (and another one at the bottom of the filter menu) since I think those are sufficient here. Two possible concerns:

Feb 12 2016, 12:11 AM · Projects, Workboards
epriestley moved T6641: Support changing default sort of a workboard from Backlog to Workboards v2 on the Workboards board.
Feb 12 2016, 12:08 AM · Projects, Workboards
epriestley added a comment to T10330: Herald condition for "Affected files does /not/ contain".

No problem, thanks for the detailed request. Let me know if I missed anything or you run into trouble.

Feb 12 2016, 12:05 AM · Herald, Feature Request
epriestley renamed T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint from When a drop on a workboard will edit a task, show an overlay hint to When moving a card on a workboard will edit a task as a side effect, show an overlay hint.
Feb 12 2016, 12:02 AM · Workboards (v3)
epriestley created T10336: Animate changes to workboards.
Feb 12 2016, 12:01 AM · Workboards (v3)

Feb 11 2016

epriestley created T10335: When moving a card on a workboard will edit a task as a side effect, show an overlay hint.
Feb 11 2016, 11:56 PM · Workboards (v3)
epriestley added a subtask for T8135: drag & drop on a workboard sorted by priority behavior is surprising: T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column".
Feb 11 2016, 11:53 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a parent task for T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column": T8135: drag & drop on a workboard sorted by priority behavior is surprising.
Feb 11 2016, 11:53 PM · Workboards (v3)
epriestley created T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column".
Feb 11 2016, 11:52 PM · Workboards (v3)
epriestley added a subtask for T8135: drag & drop on a workboard sorted by priority behavior is surprising: T10333: Add groups to workboard columns.
Feb 11 2016, 11:48 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a parent task for T10333: Add groups to workboard columns: T8135: drag & drop on a workboard sorted by priority behavior is surprising.
Feb 11 2016, 11:48 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley created T10333: Add groups to workboard columns.
Feb 11 2016, 11:48 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T10330: Herald condition for "Affected files does /not/ contain" as Resolved by committing Restricted Diffusion Commit.
Feb 11 2016, 11:29 PM · Herald, Feature Request
epriestley added a comment to T10330: Herald condition for "Affected files does /not/ contain".

Oh, the weird/nonstandard stuff in my regexp, if you or some future reader hasn't seen it before:

Feb 11 2016, 11:29 PM · Herald, Feature Request
epriestley added a comment to T10330: Herald condition for "Affected files does /not/ contain".

After D15254, you should be able to use either "does not contain" or "does not match regexp" against text or list-of-text fields, including "Affected files".

Feb 11 2016, 11:24 PM · Herald, Feature Request
epriestley added a revision to T10330: Herald condition for "Affected files does /not/ contain": Unknown Object (Differential Revision).
Feb 11 2016, 11:21 PM · Herald, Feature Request
epriestley claimed T10330: Herald condition for "Affected files does /not/ contain".
Feb 11 2016, 11:20 PM · Herald, Feature Request
epriestley added a comment to T10330: Herald condition for "Affected files does /not/ contain".

Yeah, I don't think this is possible when matching an expression against a list of possibilities.

Feb 11 2016, 10:45 PM · Herald, Feature Request
epriestley added a comment to T10332: Arcanist: show the list of diffs where the user is a reviewer.

Sounds good -- that change looks reasonable and safe to me, and I'd expect it to work well until we get T7715 done.

Feb 11 2016, 10:41 PM · Feature Request
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Feb 11 2016, 10:33 PM · Restricted Project, FreeBSD, Arcanist