Page MenuHomePhabricator
Feed Advanced Search

Jun 17 2015

epriestley closed T8575: Reap easy performance improvements as Resolved.

I think I got all the incredibly dumb, incredibly easy stuff. Plenty of room left, but this install is feeling responsive to me again.

Jun 17 2015, 6:35 PM · Performance
epriestley added a comment to T8586: getting notification + email recently on this install.

(I think this is fixed, but yell if it happens again.)

Jun 17 2015, 5:51 PM
epriestley closed T8586: getting notification + email recently on this install as Resolved by committing Restricted Diffusion Commit.
Jun 17 2015, 5:43 PM
epriestley claimed T8586: getting notification + email recently on this install.
Jun 17 2015, 4:16 PM
epriestley added a comment to T7148: Allow users to export their data from Phacility.

Manual runbook on this until we formalize the process, for hypothetical instance turtle:

Jun 17 2015, 4:14 PM · Phacility
epriestley added a revision to T8586: getting notification + email recently on this install: Unknown Object (Differential Revision).
Jun 17 2015, 4:03 PM
epriestley closed T8587: ewqewq as Invalid.
Jun 17 2015, 4:00 PM
epriestley added a comment to T8585: PhabricatorBot failing with Attempt to write to undeclared property .

Do you have rPc2a29338?

Jun 17 2015, 3:59 PM
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Unknown Object (Differential Revision).
Jun 17 2015, 2:30 PM · Harbormaster
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 17 2015, 1:14 PM · Spaces, Wikimedia, Policy, Prioritized
• aHa awarded T8549: Feedback on 2015 Redesign a Dislike token.
Jun 17 2015, 1:06 PM · Design
vinzent awarded T8549: Feedback on 2015 Redesign a Like token.
Jun 17 2015, 12:45 PM · Design
epriestley added a comment to T8576: Indexing search documents uses a lot of memory.

That stack trace is bonkers, I think we're calling tput cols every time we update a progress bar.

Jun 17 2015, 12:22 PM · Search
epriestley closed T8580: Phame blog post preview rendered badly as Invalid.

Phame is a prototype application. See this guide for more information:

Jun 17 2015, 12:17 PM · Remarkup, Phame
epriestley added a comment to T8582: Can't create projects.

I can not reproduce this.

Jun 17 2015, 12:16 PM · Projects
epriestley closed T8579: With HHVM 3.7.1: ERROR 8: Undefined index: mem_size at [/opt/phabricator/phabricator/src/applications/cache/spec/PhabricatorDataCacheSpec.php:80] as Wontfix.

We don't support HHVM. If you can't reproduce this problem on Zend PHP, you should report this compatibility issue to HHVM.

Jun 17 2015, 12:11 PM
epriestley closed T8517: "Column 'title' cannot be null" when changing CustomField as Wontfix.

We aren't interested in pursuing changes with no upstream impact.

Jun 17 2015, 12:10 PM · Custom Fields
tiguchi awarded T8549: Feedback on 2015 Redesign a Love token.
Jun 17 2015, 5:28 AM · Design
epriestley added a revision to T8575: Reap easy performance improvements: Unknown Object (Differential Revision).
Jun 17 2015, 3:03 AM · Performance
epriestley added a revision to T8575: Reap easy performance improvements: Unknown Object (Differential Revision).
Jun 17 2015, 2:45 AM · Performance
epriestley added a comment to T8575: Reap easy performance improvements.

Feed is doing some pretty silly stuff where it loads transactions, then loads their objects, then loads their handles (which loads their objects again), then loads the objects, then loads handles, which loads the objects again. In some cases, this loads objects about 6x more often than necessary. However, I think this is mostly specific to Feed, and it's not trivial to disentangle. I may take another look tomorrow.

Jun 17 2015, 2:36 AM · Performance
epriestley added a revision to T8575: Reap easy performance improvements: Unknown Object (Differential Revision).
Jun 17 2015, 2:13 AM · Performance
epriestley added a revision to T8575: Reap easy performance improvements: Unknown Object (Differential Revision).
Jun 17 2015, 2:03 AM · Performance
joshuaspence awarded T8575: Reap easy performance improvements a Mountain of Wealth token.
Jun 17 2015, 1:19 AM · Performance
epriestley added a revision to T8575: Reap easy performance improvements: Unknown Object (Differential Revision).
Jun 17 2015, 1:11 AM · Performance
epriestley created T8575: Reap easy performance improvements.
Jun 17 2015, 1:07 AM · Performance
epriestley added a comment to T8573: All reviewers should be allowed to mark a comment as done.

Can you describe the problem you're facing, not just your desired solution? See discussion here for why we consider this to be important:

Jun 17 2015, 12:17 AM · Restricted Project, Differential, Restricted Project
epriestley closed T8574: Users receiving many duplicate emails as Resolved.

I believe this is now resolved. Thanks for the report, and sorry for the duplicate mail. I've issued your instance a service credit for the last 48 hours, which will be reflected on your next bill.

Jun 17 2015, 12:03 AM · Phacility Support

Jun 16 2015

epriestley added a revision to T8574: Users receiving many duplicate emails: Unknown Object (Differential Revision).
Jun 16 2015, 11:22 PM · Phacility Support
epriestley added a comment to T8574: Users receiving many duplicate emails.

Repository tier is restarting now with D13319, so this should be fixed in about a minute.

Jun 16 2015, 11:09 PM · Phacility Support
epriestley added a comment to T8574: Users receiving many duplicate emails.

D13319 should fix this specific issue.

Jun 16 2015, 11:02 PM · Phacility Support
epriestley added a revision to T8574: Users receiving many duplicate emails: Unknown Object (Differential Revision).
Jun 16 2015, 10:56 PM · Phacility Support
epriestley added a comment to T8574: Users receiving many duplicate emails.

The issue is roughly:

Jun 16 2015, 10:49 PM · Phacility Support
tycho.tatitscheff awarded T8089: Unprototype Harbormaster (v1) a Love token.
Jun 16 2015, 10:39 PM · Prioritized, Harbormaster
epriestley added a comment to T8574: Users receiving many duplicate emails.

Here's the immediate trace:

Jun 16 2015, 10:37 PM · Phacility Support
epriestley added a comment to T8574: Users receiving many duplicate emails.

(Looking into this now...)

Jun 16 2015, 10:34 PM · Phacility Support
epriestley closed T8559: Remove emails from Herald action description for adding CCs as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 10:33 PM · Herald
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

I'm suspicious that this and T8522 may share a root cause (something else being slow) -- unless T8522 evaporated after the database recovery and seems attributable to corruption or ghosts or something.

Jun 16 2015, 9:51 PM · Restricted Project, Workboards
epriestley moved T5791: Write Herald rules for outbound mail from Backlog to The Queue on the Prioritized board.
Jun 16 2015, 9:41 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley added a project to T5791: Write Herald rules for outbound mail: Prioritized.
Jun 16 2015, 9:40 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley moved T8089: Unprototype Harbormaster (v1) from Backlog to The Queue on the Prioritized board.
Jun 16 2015, 9:39 PM · Prioritized, Harbormaster
epriestley moved T8376: Develop Spaces (v1) from Backlog to The Queue on the Prioritized board.
Jun 16 2015, 9:39 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8570: Improve browsability of directories which change name frequently.

I'm not sure I understand this problem. What would the "UI option" do? Specifically, I don't know how to implement this option:

Jun 16 2015, 9:34 PM · Diffusion (v3), Restricted Project, Restricted Project
epriestley added a comment to T5791: Write Herald rules for outbound mail.

I think T6367 effectively made the "logical" vs "physical" separation irrelevant: we can just operate on "physical" messages, since we no longer do any of the weird/bad stuff we used to do when splitting messages. We'll run rules on each "physical" message, but that's desirable and expected. Possibly we'll put some kind of new field on them to tie them all together, but I'm not sure we even need that.

Jun 16 2015, 9:24 PM · Restricted Project, Restricted Project, FreeBSD, Mail
SalmonKiller awarded T8549: Feedback on 2015 Redesign a Yellow Medal token.
Jun 16 2015, 9:08 PM · Design
epriestley added a comment to T8541: Domain Exception on trying to write to undefined property mailer.

Thanks! Should be fixed in HEAD.

Jun 16 2015, 8:57 PM · Mail
epriestley closed T8541: Domain Exception on trying to write to undefined property mailer as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 8:56 PM · Mail
epriestley closed T8481: Storing secret file in paste as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 8:47 PM · Passphrase, Paste
epriestley closed T8460: Might be helpful for all ghost events (generated and concrete) to show what instance number they are. as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 8:43 PM · Calendar
epriestley added a comment to T8376: Develop Spaces (v1).

Just to keep this up to date, I had a bunch of other personal/company stuff for the last couple of days so this hasn't moved forward much during that time, although clicking a policy link does show space information now. I have made it most of the way through the "show the strongest policy" thing above, at least, and that'll probably land today.

Jun 16 2015, 8:22 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Odd button alignment on "Notifications":

Jun 16 2015, 8:15 PM · Design
epriestley added a comment to T8566: Specify branch in commit email.

Here's what I get at HEAD:

Jun 16 2015, 8:06 PM · Diffusion, Restricted Project
johnny-bit awarded T8549: Feedback on 2015 Redesign a Manufacturing Defect? token.
Jun 16 2015, 6:09 PM · Design
johnny-bit awarded T8089: Unprototype Harbormaster (v1) a Love token.
Jun 16 2015, 5:59 PM · Prioritized, Harbormaster
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

@yelirekim, this task has some discussion of why arc land doesn't try to restore state somewhere up above, I'm pretty sure.

Jun 16 2015, 5:32 PM · Restricted Project, Arcanist
epriestley updated subscribers of T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jun 16 2015, 5:31 PM · Restricted Project, Arcanist
epriestley merged task T8567: Recover from failures in `arc land` by actually recovering from them into T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Jun 16 2015, 5:31 PM
epriestley added a comment to T8555: Fix static publishing for Diviner.

I don't expect it to actually "work", per se, today, so this is probably more like "Finish building..."

Jun 16 2015, 4:58 PM · Diviner
epriestley added a comment to T8557: Pull of repo failed after deleting branch on GitHub + pushing commits.

This is almost certainly a disk error with file permissions. Check the user you're running the daemons as, the repo permissions, etc.

Jun 16 2015, 4:58 PM · Diffusion
epriestley assigned T8559: Remove emails from Herald action description for adding CCs to lpriestley.

This action should read "Add Subscribers".

Jun 16 2015, 4:56 PM · Herald
epriestley closed T8563: Typeahead search button should permit the selection of multiple items as Wontfix.

This interaction would be less clear in the general case. This problem is better solved through T3670.

Jun 16 2015, 4:55 PM · Typeahead
epriestley added a comment to T7030: Application mail body sections are not consistently marked up.

T8561 is another case of this, specifically with "Task Description" in Maniphest. Same basic principle as other description fields in other applications.

Jun 16 2015, 4:52 PM · Mail
epriestley merged T8561: Code block not nicely formatted in task description into T7030: Application mail body sections are not consistently marked up.
Jun 16 2015, 4:52 PM · Mail
epriestley merged task T8561: Code block not nicely formatted in task description into T7030: Application mail body sections are not consistently marked up.
Jun 16 2015, 4:52 PM · Mail
epriestley assigned T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes to lpriestley.

When you have text selected in a Remarkup text area and click this button:

Jun 16 2015, 4:50 PM · Remarkup
epriestley triaged T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes as Normal priority.
Jun 16 2015, 4:46 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Sorry, I misunderstood and was using the " Quote menu item on a comment.

Jun 16 2015, 4:46 PM · Remarkup
epriestley renamed T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes from Quote text button on comments does not work for multiply nested quotes to Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.
Jun 16 2015, 4:46 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Oh! You mean the " symbol above the remarkup text box, right?

Jun 16 2015, 4:45 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

I can't reproduce this.

Jun 16 2015, 4:44 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Test.

Test.

Jun 16 2015, 4:44 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Test.

Jun 16 2015, 4:44 PM · Remarkup
epriestley added a comment to T8565: Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.

Test.

Jun 16 2015, 4:44 PM · Remarkup
epriestley added a comment to T4558: Make Diviner useful for third-parties.

some well-defined set of "extends" or "inherits" relationships

Jun 16 2015, 4:41 PM · Diviner
epriestley added a comment to T4558: Make Diviner useful for third-parties.

The vision is for it to be full-featured (e.g., support a variety of languages and input and output formats -- but also support integrations, policies, cheap setup via Harbormaster, easy document preview via arc, etc), but there isn't much demand so progress is likely to be slow. I doubt we'll ever have a superset of Sphinx's features (e.g., I don't know what "ePub" format is and would be slightly surprised to peer into the future and learn that we support it), but the architecture is (mostly) generic.

Jun 16 2015, 4:36 PM · Diviner
epriestley added a project to T8089: Unprototype Harbormaster (v1): Prioritized.

Development Log

Jun 16 2015, 4:17 PM · Prioritized, Harbormaster
epriestley closed T5138: Show unit and lint status messages at each diff as Resolved by committing Restricted Diffusion Commit.
Jun 16 2015, 3:53 PM · Differential
epriestley closed T5138: Show unit and lint status messages at each diff, a subtask of T8095: Let Harbormaster own Lint and Unit results, as Resolved.
Jun 16 2015, 3:53 PM · Harbormaster
epriestley added a comment to T6091: Support for Git's `.mailmap` author mapping.

@ostraaten, see T1731 for general mapping of VCS usernames. This is a much more attractive feature than supporting .mailmap, specifically, given the very limited use of .mailmap.

Jun 16 2015, 1:49 PM · Haskell.org, People

Jun 15 2015

epriestley added a comment to T8554: PHPUnit tests cause failure.

Ah, you're right. Those classes are a little unconventional (we usually don't let subclasses touch properties on the parent class).

Jun 15 2015, 9:00 PM · Arcanist
epriestley closed T8547: Fatal error in Diviner: Call to a member function getLanguage() on a non-object as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 8:52 PM · Diviner
epriestley closed T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 8:51 PM · Calendar, Conpherence
joshuaspence awarded T8549: Feedback on 2015 Redesign a Baby Tequila token.
Jun 15 2015, 8:48 PM · Design
epriestley added a comment to T8554: PHPUnit tests cause failure.

Thanks!

Jun 15 2015, 8:39 PM · Arcanist
epriestley closed T8554: PHPUnit tests cause failure as Resolved by committing Restricted Diffusion Commit.
Jun 15 2015, 8:39 PM · Arcanist
epriestley added a comment to T8549: Feedback on 2015 Redesign.
  • I'm definitely missing advanced search defaulting open, especially on global search. My filter is set to "Open Tasks", which is what I want about 80% of the time, but the other 20% of the time I scroll up to edit the constraints. With the new behavior, I have to open the query interface to do this.
Jun 15 2015, 6:33 PM · Design
epriestley added a comment to T8552: Increase user control over document hierarchy in Phriction.

I think these kinds of changes are generally things we're aligned with pursuing.

Jun 15 2015, 6:30 PM · Phriction, Restricted Project
epriestley removed a reviewer for D13301: test commit: Blessed Reviewers.
Jun 15 2015, 6:20 PM
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Oh! Sorry -- I pushed it to this install and put a "give us feedback here" thing on the home page. I can pull it back for now if it's not ready for feedback quite yet, it just looked like most of the internal feedback had been sorted and master was in a pretty good state to merge over.

Jun 15 2015, 4:09 PM · Design
epriestley added a comment to T8376: Develop Spaces (v1).

On the second part, from IRC:

Jun 15 2015, 4:03 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Oh, hovercards have double status, too (note double "Open").

Jun 15 2015, 3:58 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.
  • Line height in Feed and Conpherence feels a little tighter than in comments / descriptions? Maybe I'm imagining this or it's just a size/font/rendering issue, but this feels a touch tighter (mostly vertically, I think?) than I expect:
Jun 15 2015, 3:43 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

At first blush:

Jun 15 2015, 3:37 PM · Design
epriestley updated the task description for T8549: Feedback on 2015 Redesign.
Jun 15 2015, 3:10 PM · Design
epriestley created T8549: Feedback on 2015 Redesign.
Jun 15 2015, 3:09 PM · Design
epriestley added a revision to T8547: Fatal error in Diviner: Call to a member function getLanguage() on a non-object: Unknown Object (Differential Revision).
Jun 15 2015, 3:03 PM · Diviner
epriestley added a revision to T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object: Unknown Object (Differential Revision).
Jun 15 2015, 2:54 PM · Calendar, Conpherence
epriestley claimed T8547: Fatal error in Diviner: Call to a member function getLanguage() on a non-object.
Jun 15 2015, 2:53 PM · Diviner
epriestley added a project to T8547: Fatal error in Diviner: Call to a member function getLanguage() on a non-object: Diviner.
Jun 15 2015, 2:46 PM · Diviner
epriestley created T8548: Fatal error in Conpherence: Call to a member function getName() on a non-object.
Jun 15 2015, 2:46 PM · Calendar, Conpherence