Page MenuHomePhabricator
Create Task
Maniphest T8559

Remove emails from Herald action description for adding CCs
Closed, ResolvedPublic
Actions

Description

In src/applications/herald/adapter/HeraldAdapter.php, ln 853:

self::ACTION_ADD_CC       => pht('Add emails to CC'),

Herald uses the description "Add emails to CC" which isn't uniform with the way that Phabricator indicates someone is subscribed to a task. In Phabricator users are added to a CC not the email itself. In fact the user could choose to not get emails. This action description should be updated to "Add to CC %username%" to be more consistent with the interface.

Revisions and Commits

rP Phabricator
D13317rP42170ab151a9 Change text ADD_CC and REMOVE_CC actions

Event Timeline

jdloft created this task.Jun 16 2015, 3:32 AM
jdloft raised the priority of this task from to Wishlist.
jdloft updated the task description. (Show Details)
jdloft added a project: Herald.
jdloft added a subscriber: jdloft.
epriestley assigned this task to lpriestley.Jun 16 2015, 4:56 PM
epriestley added a subscriber: epriestley.

This action should read "Add Subscribers".

The corresponding "REMOVE_CC" action should read "Remove Subscribers".

Only the text labels need to change (the constants are fine as ADD_CC, even though this is out of date).

eadler added a revision: D13317: Change text ADD_CC and REMOVE_CC actions.Jun 16 2015, 10:31 PM
epriestley closed this task as Resolved by committing rP42170ab151a9: Change text ADD_CC and REMOVE_CC actions.Jun 16 2015, 10:33 PM
epriestley added a commit: rP42170ab151a9: Change text ADD_CC and REMOVE_CC actions.
Phabricator · Built by Phacility