Page MenuHomePhabricator
Create Task
Maniphest T8565

Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes
Closed, ResolvedPublic
Actions

Description

Right now, if you click the quote button to quote an already-quoted section of text like > Text you get

> > Text

Which renders as:

Text

It would be awesome if instead you got it without intervening spaces:

>> Text

Which is "correct" Remarkup for doubly quoted text:

Text

My use case is pasting crap from Outlook and fixing it up to look okay in Phabricator. Because Outlook doesn't appear to have a sane means to guarantee > in quotes when other users in the thread have different quoting styles, I end up using the quote button a bunch and it would be cool if it could help me out!

Revisions and Commits

rP Phabricator
D13334rP46a225c7b1cb Quoted text remarkup should be smart enough to know when to add a '>' and…

Event Timeline

dgfitch created this task.Jun 16 2015, 4:25 PM
dgfitch raised the priority of this task from to Needs Triage.
dgfitch updated the task description. (Show Details)
dgfitch added a project: Remarkup.
dgfitch added a subscriber: dgfitch.
epriestley added a subscriber: epriestley.Jun 16 2015, 4:44 PM

Test.

epriestley added a comment.Jun 16 2015, 4:44 PM
In T8565#121036, @epriestley wrote:

Test.

Test.

epriestley added a comment.Jun 16 2015, 4:44 PM
In T8565#121037, @epriestley wrote:
In T8565#121036, @epriestley wrote:

Test.

Test.

Test.

epriestley added a comment.Jun 16 2015, 4:44 PM

I can't reproduce this.

epriestley added a comment.Jun 16 2015, 4:45 PM

Oh! You mean the " symbol above the remarkup text box, right?

epriestley renamed this task from Quote text button on comments does not work for multiply nested quotes to Quote text button [”] in header bar of Remarkup text areas does not work for multiply nested quotes.Jun 16 2015, 4:46 PM

Sorry, I misunderstood and was using the " Quote menu item on a comment.

epriestley triaged this task as Normal priority.Jun 16 2015, 4:46 PM
epriestley assigned this task to lpriestley.Jun 16 2015, 4:50 PM

When you have text selected in a Remarkup text area and click this button:

the_button.png (194×1 px, 7 KB)

...we prepend > to each line. Instead, we should do this:

  • If the line begins with >, prepend only > (no space).
  • Otherwise, prepend > (as we do currently).

So What do you think? should turn into > What do you think? (current behavior), but > What do you think? should turn into >> What do you think? (no space between >>, correct behavior, different from current behavior).

eadler added a subscriber: eadler.Jun 16 2015, 10:20 PM
lpriestley added a revision: D13334: Quoted text remarkup should be smart enough to know when to add a '>' and when to add '> '.Jun 18 2015, 12:47 AM
lpriestley closed this task as Resolved by committing rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and….Jun 18 2015, 1:34 AM
lpriestley added a commit: rP46a225c7b1cb: Quoted text remarkup should be smart enough to know when to add a '>' and….
Phabricator · Built by Phacility