Page MenuHomePhabricator
Feed Advanced Search

Apr 22 2015

epriestley added a comment to T7882: Fatal when viewing commit or searching.

~~ psychic powers ~~

Apr 22 2015, 3:05 AM · Search, Diffusion
epriestley added a comment to T7882: Fatal when viewing commit or searching.

Restart apache or php-fpm and let me know if that fixes it?

Apr 22 2015, 2:59 AM · Search, Diffusion
epriestley closed T7881: Undefined variable when viewing diff as Resolved by committing Restricted Diffusion Commit.
Apr 22 2015, 2:28 AM · Differential
epriestley added a revision to T7881: Undefined variable when viewing diff: Unknown Object (Differential Revision).
Apr 22 2015, 2:26 AM · Differential
epriestley added a comment to T7880: Notifications are broken.

haha

Apr 22 2015, 2:16 AM · Aphlict
epriestley added a comment to T7880: Notifications are broken.

Do you have the durable chat column open?

Apr 22 2015, 2:15 AM · Aphlict
epriestley added a comment to T7880: Notifications are broken.

of course, it is the best

Apr 22 2015, 1:21 AM · Aphlict
epriestley added a comment to T7880: Notifications are broken.

I can't immediately reproduce this (see lower left corner):

Apr 22 2015, 1:16 AM · Aphlict
epriestley created T7879: Profile pictures should have policy settings forced to public/most-open.
Apr 22 2015, 12:35 AM · Files

Apr 21 2015

epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 10:50 PM · Inline Comments, Restricted Project, Differential
epriestley removed a subtask for T7447: Bring inline comments forward across revision updates: T1460: Add "Done" link to an inline comment.
Apr 21 2015, 10:36 PM · Prioritized, Differential
epriestley removed a parent task for T1460: Add "Done" link to an inline comment: T7447: Bring inline comments forward across revision updates.
Apr 21 2015, 10:36 PM · User Delight, Differential
epriestley added a comment to T5030: Improve behavior when jumping to inline comments.

D12497 doesn't directly fix any of this, but it makes links to other diffs much less common.

Apr 21 2015, 8:34 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T5030: Improve behavior when jumping to inline comments: Unknown Object (Differential Revision).
Apr 21 2015, 8:33 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 8:32 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 8:31 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 8:31 PM · Prioritized, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 8:14 PM · Prioritized, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 8:01 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 7:57 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 7:57 PM · Prioritized, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 7:22 PM · Inline Comments, Restricted Project, Differential
epriestley renamed T7877: Default remarkup indented code blocks to lang=<type_of_current_file> from [Feature request] Default remarkup indented code blocks to lang=<type_of_current_file> to Default remarkup indented code blocks to lang=<type_of_current_file>.
Apr 21 2015, 6:49 PM · Paste, Differential, Remarkup
epriestley added a comment to T7877: Default remarkup indented code blocks to lang=<type_of_current_file>.

See some earlier discussion in T6823. At that time, we opted not to give contexts where we can infer a language (pastes, inline comments) any special behavior and wait for feedback.

Apr 21 2015, 6:48 PM · Paste, Differential, Remarkup
epriestley added a comment to T7164: "Resolved" should be the first (default) option in "Change Status" action.

Sorry I can't offer more help, I'm sure it's a pain on your end and that was a very nice meme.

Apr 21 2015, 6:24 PM · Maniphest
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Most of the obvious/easy cases for this are implemented now, and the changes are pushed to this server. You can see an example on D12489.

Apr 21 2015, 6:22 PM · Prioritized, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Ah, I really like the "rewind" arrow.

Apr 21 2015, 6:14 PM · Prioritized, Differential
epriestley closed T7872: Multicommand test as Invalid.
Apr 21 2015, 4:33 PM · Mail
epriestley created T7872: Multicommand test.
Apr 21 2015, 4:14 PM · Mail
epriestley closed T7871: Test Bug #2 as Invalid.
Apr 21 2015, 4:07 PM · Mail
epriestley created T7871: Test Bug #2.
Apr 21 2015, 4:06 PM · Mail
chad awarded T7870: List of cases where ghost comments end up somewhere confusing or unexpected a The World Burns token.
Apr 21 2015, 4:03 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 3:35 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 3:34 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 3:34 PM · Prioritized, Differential
epriestley added a comment to T7164: "Resolved" should be the first (default) option in "Change Status" action.

Every option other than the status quo is worse for us and human users (more complex, more error prone, requires more code, harder to debug or support, etc). We aren't interested in upstreaming a workaround which benefits installs emitting JSON from Puppet scripts to the detriment of all other installs.

Apr 21 2015, 3:32 PM · Maniphest
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 3:19 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 2:48 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 2:47 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 2:30 PM · Prioritized, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 2:09 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 2:04 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 2:01 PM · Prioritized, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 2:01 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 1:24 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 1:19 PM · Prioritized, Differential
epriestley added a revision to T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Unknown Object (Differential Revision).
Apr 21 2015, 1:07 PM · Inline Comments, Restricted Project, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 1:07 PM · Prioritized, Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 21 2015, 12:51 PM · Prioritized, Differential
epriestley created T7870: List of cases where ghost comments end up somewhere confusing or unexpected.
Apr 21 2015, 12:46 PM · Inline Comments, Restricted Project, Differential
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Apr 21 2015, 11:33 AM · Restricted Project, Typeahead
epriestley added a comment to T7164: "Resolved" should be the first (default) option in "Change Status" action.

I don't want to add an explicit "order" parameter because then it becomes possible to get wrong (e.g., you can specify meaningless orders, specify the same order twice, etc). It has to fall back to object order anyway, or we'd break every existing install. So this would introduce a new option that's way worse for humans which almost no install would ever use.

Apr 21 2015, 11:31 AM · Maniphest

Apr 20 2015

epriestley added a subtask for T7869: Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously): T1049: Implement Harbormaster.
Apr 20 2015, 11:15 PM · Phacility
epriestley added a parent task for T1049: Implement Harbormaster: T7869: Support CircleCI webhooks for Test results (so that one can run unit tests asynchronously).
Apr 20 2015, 11:15 PM · Harbormaster
epriestley added a revision to T7573: Ship Quicksand: Unknown Object (Differential Revision).
Apr 20 2015, 11:07 PM · Quicksand, Conpherence
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 20 2015, 10:12 PM · Prioritized, Differential
epriestley closed T7868: Use system-wide ws nodeJS module as Wontfix.

Just like how global variables are kind of gross, but also necessary in some cases, global packages are important, but best avoided if not needed.
In general, the rule of thumb is:
If you’re installing something that you want to use in your program, using require('whatever'), then install it locally, at the root of your project.

Apr 20 2015, 10:08 PM · Aphlict
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
Apr 20 2015, 9:36 PM · Prioritized, Differential
epriestley claimed T7447: Bring inline comments forward across revision updates.
Apr 20 2015, 8:44 PM · Prioritized, Differential
epriestley added a comment to M1433: Global Search.

I have this partially implemented but am shifting off this for a bit and probably won't get back to it for a couple of days:

Apr 20 2015, 8:43 PM · Search
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 20 2015, 7:37 PM · Typeahead, User Delight, Maniphest
epriestley closed T7866: Diffusion repository with custom policies do not load the custom policies when modifying as Resolved.
Apr 20 2015, 3:17 PM
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Apr 20 2015, 3:17 PM · Restricted Project, Typeahead
epriestley added a revision to T7866: Diffusion repository with custom policies do not load the custom policies when modifying: Unknown Object (Differential Revision).
Apr 20 2015, 3:16 PM
epriestley added a comment to T7864: In UIExamples, separate company logo icons from wholesome normal icons.

Happy to accept a diff. :3

Apr 20 2015, 2:14 PM
epriestley closed T7864: In UIExamples, separate company logo icons from wholesome normal icons as Resolved.

Good enough.

Apr 20 2015, 1:48 PM
epriestley moved T7785: Build a Phacility cluster service tier to sandbox Graphviz and Cowsay from Backlog to Future Work on the Phacility Support board.
Apr 20 2015, 1:23 PM · Phacility, Phacility Support
epriestley closed T7818: Make "making other users instance administrators" workflow more clear as Resolved.

I held the update back a little bit because some of the typeahead changes were in flux, but this is now live:

Apr 20 2015, 1:22 PM · Documentation, Phacility, Phacility Support
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

More broadly:

Apr 20 2015, 1:13 PM · Phacility
epriestley added a comment to T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

My sysop philosophy values having the smallest possible number of moving parts, so I'm very hesitant to add systemd to the mix.

Apr 20 2015, 1:07 PM · Phacility
epriestley created T7865: After restarting, repository daemons all do a lot of work.
Apr 20 2015, 12:50 PM · Phacility
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 20 2015, 12:40 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T5523: Make bulk moves easier on Workboards: Unknown Object (Differential Revision).
Apr 20 2015, 12:13 PM · Restricted Project, Workboards
epriestley created T7864: In UIExamples, separate company logo icons from wholesome normal icons.
Apr 20 2015, 11:34 AM
epriestley closed T7861: CC/project autocompletion suggests items already added as Resolved.

At HEAD, you can use the new "Browse" dialog to browse through a long list of similarly-named items -- you can try it on this install by clicking the new icon inside the tokenizer control:

Apr 20 2015, 11:27 AM · Wikimedia, Search
epriestley closed T7862: Click-Jacking attacks. High! as Invalid.

Please report security vulnerabilities via our HackerOne program: https://hackerone.com/phabricator

Apr 20 2015, 11:19 AM
epriestley closed T7863: PHP as Invalid.

Please report security vulnerabilities via our HackerOne program: https://hackerone.com/phabricator

Apr 20 2015, 11:17 AM

Apr 19 2015

epriestley closed T5746: Phabricator does not show project color in Projects Typeahead field as Resolved.
Apr 19 2015, 6:21 PM · Projects
epriestley added a comment to T5746: Phabricator does not show project color in Projects Typeahead field.

We're still looking at possibly tweaking things a bit here (e.g., see T7858) but project tokens/tags now have consistent coloring.

Apr 19 2015, 6:21 PM · Projects
epriestley updated the task description for T7858: Typeahead/Tokenizer Errata.
Apr 19 2015, 6:21 PM · Restricted Project, Typeahead
epriestley added a revision to T5746: Phabricator does not show project color in Projects Typeahead field: Unknown Object (Differential Revision).
Apr 19 2015, 6:20 PM · Projects
epriestley created T7858: Typeahead/Tokenizer Errata.
Apr 19 2015, 6:02 PM · Restricted Project, Typeahead
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 19 2015, 3:36 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 19 2015, 2:33 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 19 2015, 2:16 PM · Typeahead, User Delight, Maniphest
epriestley added a comment to T2849: Implement alternate markup engines (Markdown, reStructuredText, ...).

Another behavioral difference which came up recently is this:

Apr 19 2015, 1:17 PM · Remarkup
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 19 2015, 1:12 PM · Typeahead, User Delight, Maniphest
epriestley added a comment to T2849: Implement alternate markup engines (Markdown, reStructuredText, ...).

When you write ![alt text](path/to/readme.txt) and the resource is not an image we have to handle that sensibly.

Apr 19 2015, 12:47 PM · Remarkup
epriestley added a comment to T2849: Implement alternate markup engines (Markdown, reStructuredText, ...).

That's blocked on T4190.

Apr 19 2015, 2:16 AM · Remarkup

Apr 18 2015

epriestley awarded T7841: Improve the design of the tokenizer browse control a Piece of Eight token.
Apr 18 2015, 6:41 PM · Design
epriestley added a comment to T7841: Improve the design of the tokenizer browse control.

itsawesome

Apr 18 2015, 6:41 PM · Design
epriestley added a revision to T5595: Allow all applications to filter results by project: Restricted Differential Revision.
Apr 18 2015, 6:39 PM · Projects, ApplicationSearch
epriestley added a revision to T4100: Support query parameterization in typeaheads: Restricted Differential Revision.
Apr 18 2015, 6:39 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 18 2015, 6:17 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T5595: Allow all applications to filter results by project: Unknown Object (Differential Revision).
Apr 18 2015, 6:17 PM · Projects, ApplicationSearch
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 18 2015, 5:23 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T5595: Allow all applications to filter results by project: Unknown Object (Differential Revision).
Apr 18 2015, 5:23 PM · Projects, ApplicationSearch
epriestley added a revision to T4100: Support query parameterization in typeaheads: Unknown Object (Differential Revision).
Apr 18 2015, 4:30 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Restricted Differential Revision.
Apr 18 2015, 4:16 PM · Typeahead, User Delight, Maniphest
epriestley added a revision to T4100: Support query parameterization in typeaheads: Restricted Differential Revision.
Apr 18 2015, 3:57 PM · Typeahead, User Delight, Maniphest