Page MenuHomePhabricator

CC/project autocompletion suggests items already added
Closed, ResolvedPublic

Description

When I type a project or user name, I expect the dropdown not to suggest things I already added. Otherwise, especially when the list of options is long and only the top 4 are shown, I have no way to add new items.

PhabricatorAutocompletion.png (258×598 px, 28 KB)

Event Timeline

nemobis raised the priority of this task from to Needs Triage.
nemobis updated the task description. (Show Details)
nemobis added projects: Search, Wikimedia.
nemobis added a subscriber: nemobis.
epriestley claimed this task.
epriestley added a subscriber: epriestley.

At HEAD, you can use the new "Browse" dialog to browse through a long list of similarly-named items -- you can try it on this install by clicking the new icon inside the tokenizer control:

browse.png (150×924 px, 28 KB)

See also T6974 (discussion of preventing duplicates in the Action selectors) and T7858 (discussion of making it easier to get to this dialog from the bottom of a long result list).

I'd hesitate to implement the solution exactly as described because I worry it would be confusing to type an item which you know has matches and get nothing back. This isn't insurmountable, but I think it's significantly more clear to always show the match (ideally, perhaps we would visually indicate that it has already been selected in the dropdown, though).

When I type a project or user name, I expect the dropdown not to suggest things I already added.

I note that StackExchange doesn't suggest duplicates, either.