Page MenuHomePhabricator

Improve the design of the tokenizer browse control
Closed, ResolvedPublic

Assigned To
Authored By
epriestley
Apr 16 2015, 8:41 PM
Referenced Files
F374071: Screen_Shot_2015-04-16_at_1.38.30_PM.png
Apr 16 2015, 8:41 PM
F374069: Screen_Shot_2015-04-16_at_1.37.33_PM.png
Apr 16 2015, 8:41 PM
Subscribers
Tokens
"Piece of Eight" token, awarded by epriestley.

Description

The browse control has two components, the actual browse button:

Screen_Shot_2015-04-16_at_1.37.33_PM.png (186×974 px, 28 KB)

...and the browse dialog:

Screen_Shot_2015-04-16_at_1.38.30_PM.png (434×611 px, 47 KB)

You can get to examples of both via DifferentialEdit Revision.

These are both kind of ugly.

The browse button should probably be integrated into the tokenizer, like the mock in T5750, and just be an icon instead of an icon + text. I wasn't immediately able to get this working cleanly with bare PHUIButtonView.

The dialog probably just needs some tuning and cleanup.

(The dialog title also needs to use an actual human-facing string.)

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Design.
epriestley added subscribers: epriestley, chad.

D12441 actually implements this beautiful, elegant control.

I think we're in pretty good shape here now, some minor possible followups in T7858 and elsewhere.