Page MenuHomePhabricator

Correct Diffusion browse behavior when visiting a path URI with no trailing slash
ClosedPublic

Authored by epriestley on Jan 28 2021, 12:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 29, 12:04 AM
Unknown Object (File)
Tue, Jan 24, 2:32 PM
Unknown Object (File)
Thu, Jan 19, 12:24 PM
Unknown Object (File)
Sun, Jan 8, 6:34 PM
Unknown Object (File)
Sat, Jan 7, 4:33 PM
Unknown Object (File)
Dec 16 2022, 5:37 AM
Unknown Object (File)
Dec 12 2022, 12:08 AM
Unknown Object (File)
Dec 5 2022, 4:55 AM
Subscribers
None

Details

Summary

See PHI1983. Ref T13599. Ref T13589. Currently, if you browse to a path browse URI in Diffusion without a trailing slash (/browse/master/src), you get a nonsensical view (the directory as a single item).

Be more precise in how "git ls-tree" arguments are constructed.

Test Plan

Visited files and directories in the browse view, with and without trailing slashes. Saw improved behavior for directories with no trailing slash and reasonable behavior in all other cases.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable