Page MenuHomePhabricator
Feed Advanced Search

Sun, Nov 1

epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Sun, Nov 1, 1:02 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Sun, Nov 1, 1:01 PM · Security, Phacility

Fri, Oct 23

epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Fri, Oct 23, 4:30 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

Found one, creating a new project returns:

Fri, Oct 23, 4:26 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Fri, Oct 23, 4:23 PM · Security, Phacility
holmboe added a comment to T13704: PHP2Shell.

Found one, creating a new project returns:

Fri, Oct 23, 3:30 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

I suspect a lot of behavior is still broken, but at least some things should be working now. I'm working on restoring SSH access to repositories (which I suspect is just an ops/config issue) and then I'll fix whatever shows up in the error log.

Fri, Oct 23, 3:23 PM · Security, Phacility
holmboe added a comment to T13704: PHP2Shell.

We are live! Thank you Evan for your relentless work. 🙏

Fri, Oct 23, 3:17 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Fri, Oct 23, 3:16 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.
  • Restoring MySQL from backup took a very long time (partly because I didn't realize the volume was an ancient gp2 volume with a tight limit on iops) but succeeded.
  • admin is back up and cluster directory services are mostly working.
  • I'm working on redeploying web now; this tier is stateless and doesn't need to load backups.
  • The most recent available backup was slightly out of date (Oct 16th IIRC). If this caused issues (e.g., double-billing or deleting recently-invited user accounts) I'll sort everything out once services are back up.
Fri, Oct 23, 3:01 PM · Security, Phacility

Thu, Oct 22

epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 11:21 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 11:18 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 11:14 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

One issue I'm struggling with is that some daemon parsing is failing...

Thu, Oct 22, 11:08 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 10:23 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 10:17 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

One issue I'm struggling with is that some daemon parsing is failing:

Thu, Oct 22, 10:13 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

Actually, Phabricator uses static::class since D21744 and it works in older PHP per 3v4l.org, so I think I'm incorrect that this requires PHP 8.

Thu, Oct 22, 9:35 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 9:32 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

See T13637. See T13588. In PHP 8.1, the behavior of static variables in methods changed, per this snippet from the PHP Documentation:

Thu, Oct 22, 9:19 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 8:59 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 8:44 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 8:25 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

I do want $array[null] to kill the server in the general case so all the high-quality Phabricator code I write in the future can't do it, but I realize I may need to concede and silence the error. I am going to give up on this one:

Thu, Oct 22, 7:09 PM · Security, Phacility
avivey added a comment to T13704: PHP2Shell.

also maybe copy https://we.phorge.it/D25387, which makes it so deprecation
messages don't kill the server.

Thu, Oct 22, 7:04 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.
  • AWS now has over 800 instance types???
  • I believe I've launched a new admin with a patched PHP that is surviving a least some of the deployment process. MySQL can't upgrade databases across major versions, so I'm restoring from backup now.
  • @jmeador oh hi there
  • @avivey Yeah, like half the pages are working for me while logged in but things are still pretty rough.
Thu, Oct 22, 7:04 PM · Security, Phacility
avivey added a comment to T13704: PHP2Shell.

Hi Evan,

Thu, Oct 22, 6:52 PM · Security, Phacility
jmeador added a comment to T13704: PHP2Shell.

A wild epriestley appears!

Thu, Oct 22, 6:33 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

Typical state-of-the-art software upgrade process:

Thu, Oct 22, 5:52 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 3:46 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 3:20 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 3:11 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 3:09 PM · Security, Phacility
epriestley added a comment to T13704: PHP2Shell.

General state of affairs:

Thu, Oct 22, 2:46 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 2:28 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 9:58 AM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 9:20 AM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 2:13 AM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Thu, Oct 22, 12:46 AM · Security, Phacility

Wed, Oct 21

epriestley added a comment to T13704: PHP2Shell.

Recent versions of Ubuntu default to a sudo implemented in Rust which doesn't support -E to pass the entire environment. A quick fix for this is to select sudo.ws as an alternative:

Wed, Oct 21, 11:09 PM · Security, Phacility
epriestley added a revision to T13704: PHP2Shell: Restricted Differential Revision.
Wed, Oct 21, 11:06 PM · Security, Phacility
epriestley triaged T13704: PHP2Shell as High priority.
Wed, Oct 21, 10:44 PM · Security, Phacility
epriestley triaged T13704: PHP2Shell as High priority.
Wed, Oct 21, 10:44 PM · Security, Phacility

Oct 26 2022

epriestley closed T13683: Security Guidance: References to Files in Remarkup as Resolved.

There are some remaining non-security bugs with this that I'll follow up on in T13682. I believe the security side of this is now resolved.

Oct 26 2022, 8:03 PM · Guides, Files, Security
epriestley added a comment to T13683: Security Guidance: References to Files in Remarkup .

The details of this attack will be disclosed at a later date, once installs have had some sort of plausible chance to upgrade.

Oct 26 2022, 8:01 PM · Guides, Files, Security

May 27 2022

epriestley triaged T13683: Security Guidance: References to Files in Remarkup as Normal priority.
May 27 2022, 6:13 PM · Guides, Files, Security

May 17 2022

epriestley closed T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Resolved.
May 17 2022, 11:31 PM · Security, Feed
epriestley added a revision to T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable: Restricted Differential Revision.
May 17 2022, 11:29 PM · Security, Feed
epriestley triaged T13681: Ancient "feed.publish" API is (at best) long obsolete, and arguably exploitable as Normal priority.
May 17 2022, 11:27 PM · Security, Feed

May 9 2022

epriestley closed T13679: Non-administrators can incorrectly edit default global settings as Resolved.

I believe D21811 covers this completely.

May 9 2022, 10:19 PM · Security
epriestley updated the task description for T13679: Non-administrators can incorrectly edit default global settings.
May 9 2022, 10:18 PM · Security
epriestley added a revision to T13679: Non-administrators can incorrectly edit default global settings: Restricted Differential Revision.
May 9 2022, 10:10 PM · Security
epriestley triaged T13679: Non-administrators can incorrectly edit default global settings as Normal priority.
May 9 2022, 10:08 PM · Security

Apr 29 2022

mormegil added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

Just for visibility, this is I believe the change that broke Diffusion (which was fixed in rP52df4ff515b7), where the error message is something like

Apr 29 2022, 8:19 AM · Git, Security

Apr 20 2022

epriestley closed T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Resolved.

I believe these were all hunted down.

Apr 20 2022, 7:15 PM · Security, Git
epriestley added a revision to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation: Restricted Differential Revision.
Apr 20 2022, 4:31 PM · Git, Security

Apr 14 2022

epriestley closed T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Resolved.

I deployed this everywhere in the Phacility cluster yesterday and things have been quiet, so I'm assuming it worked until evidence arises to the contrary.

Apr 14 2022, 1:49 PM · Git, Security
epriestley updated the task description for T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.
Apr 14 2022, 1:47 PM · Git, Security

Apr 13 2022

epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

D21756 effectively makes all Git pathways call setSudoAsDaemon(true).

Apr 13 2022, 6:31 PM · Git, Security
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

Just for visibility, the error messages you'll see if you're affected by this issue look something like this:

Apr 13 2022, 6:06 PM · Git, Security
epriestley added a comment to T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation.

...maybe this is an actual bug in Phabricator where some pathways are just missing the "sudo" wrapper?

Apr 13 2022, 6:06 PM · Git, Security
epriestley triaged T13673: CVE-2022-24765 - Multi-user Git Privilege Escalation as Normal priority.
Apr 13 2022, 5:48 PM · Git, Security

Dec 2 2021

epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

I'm satisfied that we aren't violating our commitment to our customers by continuing to use Mailgun as a service provider...

Dec 2 2021, 10:39 PM · Phacility, Security, Mail

Aug 19 2021

epriestley updated the task description for T13664: SSRF and Phabricator.
Aug 19 2021, 5:07 PM · Security, Guides
epriestley triaged T13664: SSRF and Phabricator as Low priority.
Aug 19 2021, 4:41 PM · Security, Guides

Apr 8 2021

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Yes. I closed down registration on this install (secure.phabricator.com) several years ago because the overwhelming majority of users who registered accounts here didn't read or follow the rules. Access to secure.phabricator.com is now invite-only.

Apr 8 2021, 12:53 PM · Security, Git
holmboe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Please use Discourse to report bugs.

Apr 8 2021, 9:47 AM · Security, Git

Jan 28 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 28 2021, 12:34 AM · Security, Git

Jan 25 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 25 2021, 5:10 PM · Security, Git

Jan 20 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 20 2021, 11:04 PM · Security, Git
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 20 2021, 7:44 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 20 2021, 6:47 PM · Security, Git

Jan 19 2021

epriestley added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

Please use Discourse to report bugs. See https://discourse.phabricator-community.org/t/repository-view-git-command-failed-error/4510/.

Jan 19 2021, 3:34 PM · Security, Git
Abbe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

It works with Git 2.1.4 (shipped with Debian Wheezy), but not with Git 2.20.1 (shipped with Debian Buster), or Git 2.30.0 (latest version).

Jan 19 2021, 12:00 PM · Security, Git
Abbe added a comment to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.

My apologies if this is not the right place to post about this, but seems like due to ea9cb0b625fb6922c45aecbfdebacc60788ed92d we now get following error message when visiting diffusion repository page, i.e. URL /diffusion/$REPOID/:

Jan 19 2021, 11:44 AM · Security, Git

Jan 15 2021

epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:45 PM · Security, Git
epriestley changed the visibility for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 15 2021, 6:44 PM · Security, Git

Jan 12 2021

epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 12 2021, 8:11 PM · Security, Git
epriestley updated the task description for T13589: Git may interpret refnames as flags in some commands which accept both refs and paths.
Jan 12 2021, 8:10 PM · Security, Git
epriestley added a revision to T13589: Git may interpret refnames as flags in some commands which accept both refs and paths: Restricted Differential Revision.
Jan 12 2021, 8:09 PM · Security, Git
epriestley triaged T13589: Git may interpret refnames as flags in some commands which accept both refs and paths as Normal priority.
Jan 12 2021, 6:26 PM · Security, Git

Aug 5 2020

epriestley updated the task description for T13241: Guide: SMS is Insecure.
Aug 5 2020, 7:22 PM · Security, Guides

Apr 30 2020

adrelanos added a watcher for Security: adrelanos.
Apr 30 2020, 7:59 PM

Jul 31 2019

epriestley closed T13350: Ancient "slowvote.info" API method bypasses policy checks as Resolved by committing Restricted Diffusion Commit.
Jul 31 2019, 6:28 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Restricted Differential Revision.
Jul 31 2019, 6:26 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Restricted Differential Revision.
Jul 31 2019, 6:22 PM · Slowvote, Security
epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Restricted Differential Revision.
Jul 31 2019, 6:17 PM · Slowvote, Security

Jul 30 2019

epriestley added a revision to T13350: Ancient "slowvote.info" API method bypasses policy checks: Restricted Differential Revision.
Jul 30 2019, 6:53 PM · Slowvote, Security
epriestley triaged T13350: Ancient "slowvote.info" API method bypasses policy checks as Low priority.
Jul 30 2019, 6:46 PM · Slowvote, Security

Jul 15 2019

amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI, a subtask of T6755: Allow more granular configuration of `security.allow-outbound-http`, as Resolved.
Jul 15 2019, 6:53 PM · Security
amckinley closed T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI as Resolved by committing Restricted Diffusion Commit.
Jul 15 2019, 6:53 PM · Auth, Security

Jul 10 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Jul 10 2019, 3:05 PM · Auth, Security

Apr 18 2019

epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Apr 18 2019, 2:05 PM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

This could be made slightly cleaner with a setSummary() to set a shorter summary:

Apr 18 2019, 2:02 PM · Auth, Security
epriestley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Apr 18 2019, 12:24 AM · Auth, Security
epriestley added a comment to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI.

hmmmmmm

Apr 18 2019, 12:21 AM · Auth, Security

Apr 11 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Apr 11 2019, 8:16 PM · Auth, Security

Apr 10 2019

amckinley added a revision to T7667: Provide `auth lock` and `auth unlock` to restrict authentication provider management to the CLI: Restricted Differential Revision.
Apr 10 2019, 10:35 PM · Auth, Security

Feb 2 2019

epriestley renamed T13245: Improve MFA security by using replacing SMS code digits with emoji from Improve MFA security by using replacing digits with emoji to Improve MFA security by using replacing SMS code digits with emoji.
Feb 2 2019, 6:46 PM · Security
epriestley triaged T13245: Improve MFA security by using replacing SMS code digits with emoji as Low priority.
Feb 2 2019, 6:46 PM · Security