Page MenuHomePhabricator

Make "arc land" complain if builds are still executing or have failed
Closed, ResolvedPublic

Description

Before landing a revision, we should check if the primary corresponding buildable is building or failed and make the user confirm if it is, i.e.:

Build plans for this revision failed!

  (BUILDING) Run Long Tests
  ( FAILED!) Run Unit Tests

Land anyway? [y/N]

Revisions and Commits

Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision
Restricted Differential Revision

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Harbormaster.
epriestley added subscribers: epriestley, zeeg.

it should be nice to create an event listener "before landing"

Closed by commit rARC6e597b292ad1.

epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.
epriestley edited this Maniphest Task.