Page MenuHomePhabricator

Create the event listener "before landing"
Closed, ResolvedPublic


It should be nice to have an event listener "before landing" to process some checks before landing and close the revision

Event Timeline

benjamin.cohen-solal raised the priority of this task from to Needs Triage.
benjamin.cohen-solal updated the task description. (Show Details)
benjamin.cohen-solal added a project: Arcanist.

What checks do you want to perform, specifically?

We use to run jenkins build (in waiting for harbormaster :)) after each diff creation (we implemented the event TYPE_DIFF_WASCREATED).
When jenkins finishes its build it will add a comment on the revision or reject it if a problem occured.

We want to check that jenkins had enough time to process before the revision is accepted and landed.


Have you tried to do so?
It's not simple but working way for use jenkins and phabricator together.

I actually followed this tutorial (very good tutorial) and it worked perfectly.
But the problem has never been to make work Jenkins and phabricator together but to avoid developers to land their branch while Jenkins is run

austinkelleher closed this task as Resolved.EditedMay 1 2014, 2:31 PM
austinkelleher claimed this task.
This comment has been deleted.
austinkelleher added a subscriber: austinkelleher.

Sorry, I was testing the the meme feature and accidentally submitted my comment, and somehow I got assigned to this task.