Page MenuHomePhabricator

Give the parameter diff_ID to TYPE_LAND_WILLPUSHREVISION event
Closed, ResolvedPublic


I would like to force the developers to wait for a Jenkins successful build before landing their revision. So I created an event listener listening the event TYPE_LAND_WILLPUSHREVISION but the differential ID could be found from the event.

I noticed in the ArcanistLandWorkflow class the following lines :


No parameter being provided to the "arc land" event, the event is completely useless for me...

Event Timeline

benjamin.cohen-solal raised the priority of this task from to Needs Triage.
benjamin.cohen-solal updated the task description. (Show Details)
benjamin.cohen-solal added a project: Arcanist.
benjamin.cohen-solal updated the task description. (Show Details)
btrahan triaged this task as Low priority.

There is a 'workflow' object. If you call


You'll get a nice dictionary of revision data, including the revision ID.