Page MenuHomePhabricator
Create Task
Maniphest T4565

Give the parameter diff_ID to TYPE_LAND_WILLPUSHREVISION event
Closed, ResolvedPublic
Actions

Description

I would like to force the developers to wait for a Jenkins successful build before landing their revision. So I created an event listener listening the event TYPE_LAND_WILLPUSHREVISION but the differential ID could be found from the event.

I noticed in the ArcanistLandWorkflow class the following lines :

$this->dispatchEvent(
        ArcanistEventType::TYPE_LAND_WILLPUSHREVISION,
        array());

No parameter being provided to the "arc land" event, the event is completely useless for me...

Revisions and Commits

rARC Arcanist
ClosedD8484 Arcanist - add revision data to TYPE_LAND_WILLPUSHREVISION event

Related Objects

Event Timeline

benjamin.cohen-solal created this task.Mar 6 2014, 4:37 PM
benjamin.cohen-solal raised the priority of this task from to Needs Triage.
benjamin.cohen-solal updated the task description. (Show Details)
benjamin.cohen-solal added a project: Arcanist.
benjamin.cohen-solal updated the task description. (Show Details)
benjamin.cohen-solal added a subscriber: benjamin.cohen-solal.
btrahan edited this Maniphest Task.Mar 10 2014, 8:50 PM
btrahan claimed this task.Mar 10 2014, 8:50 PM
btrahan triaged this task as Low priority.
btrahan added a comment.Mar 11 2014, 10:22 PM

There is a 'workflow' object. If you call

$workflow->getRevisionDict()

You'll get a nice dictionary of revision data, including the revision ID.

btrahan closed this task as Resolved.Mar 11 2014, 10:23 PM
epriestley mentioned this in T10329: Implement internal workflows / a build engine in Arcanist.Jul 24 2016, 1:07 PM
Phabricator · Built by Phacility