Couple of years ago the furnace wasn't working so well. Light comes on, three reds. Pressure switch stuck open. I take off a panel, pull the pressure switches. The contacts close properly. No clue what's wrong. Call an HVAC guy. He's pretty busy. No problem, we got plenty of sweaters. Ha. He makes it out early the next week.

all my drains are belong to PVC

... condensate drain ...

...there's enough absorbent material underneath the sink...

(You don't actually need a leak detector, I think there's enough absorbent material underneath the sink to last a long while before it damages the floor)

Here is my bathroom sink. The right-most pipe coming out of the wall is the condensate drain from HVAC. The tailpiece is most definitely 1 1/4 and the rest of the piping is 1 1/2, at least to the naked eye.

I can't see a way to make the trap be any less garbage than it is because the 4" flanged tailpipe (the shortest flanged 1-1/4" tailpipe I could find) plus an additional 8" of tailpipe underneath it (the only 1-1/4" branch tailpipe I could find, which is only available with a slip fitting) means that the bottom of the lower tailpipe is super low. It looks like I left an extra 6" of flexible pipe on the drain side for fun, but that's just the rigid bottom of the tailpipe plus the minimum bend radius without making the flexible pipe start to crimp -- the bottom of the tailpipe is like 1-1/2" below the black plastic retainer clip.

A few more thoughts:

Since there's no fresh water supply to the dehumidifier I don't think there's much benefit to an air gap, as there's no way backflow could ever contaminate a supply line. A clogged sink drain could possibly drain sink water out through the dehumidifier bucket, but the top of the drain line is only ~1"-2" below the top of the sink so it would overflow the basin onto the floor before very long anyway.

My terminology might be wrong throughout this but a couple thoughts:

Other options I explored and rejected:

• Inline Comments: See PHI2217. See PHI2206. Inline comments don't currently attach images.
• Destroying Edges: See PHI2201. See PHI2217. Destroying files that have old edge types may raise warnings. The destruction still works, although it doesn't hit the edges.
• Destroying Files: See PHI2217. Destroying an object doesn't destroy corresponding FileAttachment objects, so you can end up with ghosts in the UI.

There are some remaining non-security bugs with this that I'll follow up on in T13682. I believe the security side of this is now resolved.

The details of this attack will be disclosed at a later date, once installs have had some sort of plausible chance to upgrade.

An earlier patch here (rCORE6d6170f76463) swapped binlogs to MIXED and set a 24-hour retention policy. This issue has not reoccurred in the cluster since that patch went out, but the root causes remain unresolved.

I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).

I patched and partially deployed this in early August. Another unattended MySQL upgrade went out on Monday night, also didn't restart MySQL on affected hosts, and caused some downtime on hosts that didn't have the patch (to "disable unattended upgrades"). I've now deployed this everywhere, and am presuming this is fixed until evidence arises to the contrary.

See also PHI2219, PHI2220.

That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).

I believe we may be hitting either the problem one of the above commit fixes, or suffering from a similar caused as side-effect from it.

...ideally this sort of thing should fail loudly at serialization time...

• The drydock_resource table could use a (status, ...) key to satisfy common/default queries.

• Update some file/class names.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.