Page MenuHomePhabricator

Allow arc patch to keep empty commits
AbandonedPublic

Authored by vm on Sep 8 2014, 6:22 PM.
Tags
None
Referenced Files
F19077005: D10443.diff
Dec 1 2025, 2:10 PM
F18905030: D10443.id.diff
Nov 8 2025, 12:32 PM
F18892559: D10443.diff
Nov 7 2025, 12:04 PM
F18846118: D10443.id25115.diff
Oct 29 2025, 4:46 PM
F18828710: D10443.diff
Oct 24 2025, 5:46 PM
F18761113: D10443.id.diff
Oct 6 2025, 12:19 PM
F18756597: D10443.diff
Oct 5 2025, 12:17 PM
F18712172: D10443.id.diff
Sep 29 2025, 5:17 AM

Details

Summary

This is in an effort to simplify test automation around dependent diffs workflow.
If you have dependent diffs where some of the dependencies have already landed into HEAD, a arc patch --nobranch on the dependent diff fails since 'get cherry-pick' does not allow empty commits.
This lets you set a flag that gets passed down to git cherry-pick which allows and keeps empty commits around.

Fixes one of the problems mentioned in T5986

Test Plan

arc patch --nobranch D1 fails, but arc patch --nobranch --keep-redundant-commits D1 runs successfully and adds a empty commit to the working copy.

Diff Detail

Repository
rARC Arcanist
Branch
kec
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2464
Build 2468: [Placeholder Plan] Wait for 30 Seconds