Page MenuHomePhabricator

Fix more PHP 8.1 "strlen(null)" callsites
Needs ReviewPublic

Authored by vm on Jun 7 2022, 7:48 PM.
Tags
None
Referenced Files
F12194277: D21853.id.diff
Sun, Sep 24, 7:28 PM
F12194222: D21853.id52085.diff
Sun, Sep 24, 6:09 PM
F12194040: D21853.diff
Sun, Sep 24, 12:13 PM
F12193982: D21853.id52085.diff
Sun, Sep 24, 10:33 AM
F12192727: D21853.diff
Sat, Sep 23, 2:58 AM
F12187262: D21853.diff
Sun, Sep 17, 12:51 PM
F12180097: D21853.diff
Tue, Sep 12, 9:05 AM
F12162426: D21853.diff
Wed, Sep 6, 8:15 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T13588: PHP 8 Compatibility
Summary

Noticed some failures with a custom UnitEngine after upgrading to
PHP 8.1
Was able to work around it by setting empty strings but this should fix the
underlying problem.

Test Plan

arc unit no longer fails with no namespace set on UnitTestResult

Diff Detail

Repository
rARC Arcanist
Branch
fix_8.1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25761
Build 35589: arc lint + arc unit