PHP 8.1 disallows strlen(null).

• Also fix some unit test behaviors.

This was resolved by D21452. PHI1880 has some unrelated additional plans.

I deployed this and it seems to be working properly.

Hey, it worked once. Good enough for me!

No dice. We need bin/upgrade to run before mysql because it has to mount the data volume. So now I'm trying this:

... service ... start rather than service ... restart ...

...probably tested...

I deployed this everywhere in the Phacility cluster yesterday and things have been quiet, so I'm assuming it worked until evidence arises to the contrary.

With max_connections at 1024, the server above still looks fine after ~14 days:

D21756 effectively makes all Git pathways call setSudoAsDaemon(true).

Just for visibility, the error messages you'll see if you're affected by this issue look something like this:

...maybe this is an actual bug in Phabricator where some pathways are just missing the "sudo" wrapper?

Elsewhere, I compacted Phacility free instances onto a small number of database servers. I attempted to "fill up" these servers, and succeeded, sort of, but maybe too much -- they eventually fall over and need to be rebooted.

This has some rough edges that I'm not going to deal with for now:

• Found a few more.

Will this work will with Phabricator?

We came up with a flow in Phorge we think would work well, to progress this task (https://we.phorge.it/E1):

• We'll have a bunch of diffs, on a per-application basis, along the style established here and in D21712.
• We'll review each diff on the Phorge
• When it matures, we'll copy it here for for your review and landing in Phabricator.

Ah thank you!

GitHub was refusing mirror pushes with a credential issue (see also T12896, vaguely). I'm not entirely sure which side of things changed, but the config was set up in a previous-generation way anyway (through a "bot" account instead of a "Deploy Key") so I updated things. Looks like mirroring is back online now and this change has propagated.

@epriestley - the fix for this landed in the master branch but it doesn't look like that has carried over yet into the GitHub mirror which is used as the install location for most users, and is the current recommendation on https://secure.phabricator.com/book/phabricator/article/arcanist_quick_start/. Is there a delay before the mirror observes the changes or does something need poked for it to propagate?

• Fix problem with strlen on newest php