Differential D21757

Improve some PHP 8.1 behavior in "bin/auth recover"
ClosedPublic
Actions

Authored by epriestley on Apr 19 2022, 9:48 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover"

Summary

Ref T13588. Fix a couple of argument parsing issues here.

Test Plan

Ran "bin/auth recover" under PHP 8.1.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Apr 19 2022, 9:48 PM

epriestley created this revision.

Harbormaster completed remote builds in B25641: Diff 51866.Apr 19 2022, 9:48 PM

Also fix some unit test behaviors.

Harbormaster completed remote builds in B25642: Diff 51867.Apr 19 2022, 9:54 PM

epriestley mentioned this in D21758: Fix a PHP 8.1 issue with "phutil_console_strlen()".Apr 19 2022, 9:55 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2022, 9:55 PM

Closed by commit rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in rARC1fc4439ca5ff: Fix a PHP 8.1 issue with "phutil_console_strlen()".

epriestley added a commit: rP21b1a304b60a: Improve some PHP 8.1 behavior in "bin/auth recover".

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

management/

PhabricatorAuthManagementRevokeWorkflow.php

4 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

4 lines

Diff 51870

View Options

src/applications/auth/management/PhabricatorAuthManagementRevokeWorkflow.php