Introduce PHP8.1 replacement functions for string tests which may take multiple types
ClosedPublic
Actions

Authored by epriestley on Apr 20 2022, 5:45 PM.

Tags

None

Referenced Files

	F15560620: D21762.id51874.diff
	Tue, Apr 29, 3:38 PM

	F15514210: D21762.id51874.diff
	Fri, Apr 18, 1:05 AM

	F15509227: D21762.id51875.diff
	Wed, Apr 16, 10:44 AM

	F15505652: D21762.id51875.diff
	Tue, Apr 15, 4:40 AM

	F15500086: D21762.id51874.diff
	Sun, Apr 13, 4:00 PM

	F15498536: D21762.id51875.diff
	Sun, Apr 13, 1:10 PM

	F15492721: D21762.id.diff
	Sat, Apr 12, 5:39 PM

	F15489454: D21762.diff
	Fri, Apr 11, 9:16 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARCf098e8d86373: Introduce PHP8.1 replacement functions for string tests which may take multiple…

Summary

Ref T13588. Adds "phutil_nonempty_string()" and similar methods to support PHP8.1 compatibility.

Test Plan

Added unit tests, ran unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley requested review of this revision.Apr 20 2022, 5:45 PM

epriestley created this revision.

Harbormaster completed remote builds in B25647: Diff 51874.Apr 20 2022, 5:46 PM

epriestley mentioned this in T13588: PHP 8 Compatibility.Apr 20 2022, 6:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2022, 6:12 PM

Closed by commit rARCf098e8d86373: Introduce PHP8.1 replacement functions for string tests which may take multiple… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rARCf098e8d86373: Introduce PHP8.1 replacement functions for string tests which may take multiple….

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

unit/

engine/

phutil/

PhutilTestCase.php

141 lines

utils/

__tests__/

PhutilUtilsTestCase.php

70 lines

utils.php

125 lines

Diff 51875

View Options

src/__phutil_library_map__.php

View Options

src/unit/engine/phutil/PhutilTestCase.php

View Options

src/utils/tests/PhutilUtilsTestCase.php

View Options

Introduce PHP8.1 replacement functions for string tests which may take multiple typesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51875

src/__phutil_library_map__.php

src/unit/engine/phutil/PhutilTestCase.php

src/utils/__tests__/PhutilUtilsTestCase.php

src/utils/utils.php

Introduce PHP8.1 replacement functions for string tests which may take multiple types
ClosedPublic
Actions

Revision Contents
Changeset List

src/utils/tests/PhutilUtilsTestCase.php