Page MenuHomePhabricator

Fix an issue where Herald may fail to extract content from an empty commit
ClosedPublic

Authored by epriestley on Apr 20 2022, 4:53 PM.

Details

Summary

Ref T13667. The Herald "content added" rule (and other similar rules) do not correctly extract content from empty commits.

When we load an empty raw diff, return an empty changed content map.

Ref T13588. Also fix some PHP8.1 null/string stuff

Test Plan
  • Ran "bin/repository reparse --publish <commit>", with an empty commit hash and a nonempty commit hash.
  • Reviewed Herald transcripts for general sanity.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable