Page MenuHomePhabricator
Feed All Stories

Sep 5 2020

epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:32 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:26 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Restricted Differential Revision.
Sep 5 2020, 12:09 AM · Arcanist
epriestley added a comment to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path.

Check if arc lint catches this.

Sep 5 2020, 12:09 AM · Arcanist
epriestley added a revision to T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path: Unknown Object (Differential Revision).
Sep 5 2020, 12:07 AM · Arcanist

Sep 4 2020

epriestley added a revision to T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()": Unknown Object (Differential Revision).
Sep 4 2020, 11:39 PM · Daemons
epriestley triaged T13579: Overseer may fatal when trying to write to "pid" property in "annihilateProcessGroup()" as Normal priority.
Sep 4 2020, 11:38 PM · Daemons
epriestley added a revision to T13573: When printing, render dates in an absolute, context-free format: Unknown Object (Differential Revision).
Sep 4 2020, 11:25 PM · Infrastructure
epriestley renamed T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting from Include "Moved/Copied" gutter in 1-up diffs, and add aural cues to Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting.
Sep 4 2020, 5:56 PM · Accessibility, Differential
epriestley triaged T13578: Provide `bin/user approve` to approve an account from the CLI as Wishlist priority.
Sep 4 2020, 5:52 PM · Setup, Auth
epriestley triaged T13577: HTTPSFuture has a missing parameter in an exception message when overwriting a download path as Low priority.
Sep 4 2020, 5:49 PM · Arcanist
epriestley triaged T13576: When "arc land" selects a commit range with merge commits, it may fail to slice them from history as Normal priority.
Sep 4 2020, 5:46 PM · Arcanist

Sep 1 2020

20after4 added a comment to T13478: Fix various policy issues with project member materialization around interactions between "Project Members" policies and Subprojects/Milestones.

Probably related: According to https://phabricator.wikimedia.org/T261642, it seems that when leaving a project, phabricator leaves behind some cruft in the form of materialized memberships for milestones of that project.

Sep 1 2020, 9:42 PM · Policy, Projects
mavit added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

MYSQL_PWD can be observed always

Sep 1 2020, 8:02 PM · Bug Report
• IgoSha added a comment to T11433: MySQL "-p<password>" flag produces a warning in recent versions of MySQL.

The main problem here is that command "./bin/storage dump" exposes password on system process list in clear text. It happens due to way the storage tool calls mysqldump command. In my opinion this is universally applicable to every Linux distribution Phabricator can run on.

Sep 1 2020, 1:44 PM · Bug Report

Aug 29 2020

• MagicInventor added a comment to T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate.
Aug 29 2020, 12:19 AM · Arcanist
• MagicInventor updated • MagicInventor.
Aug 29 2020, 12:11 AM

Aug 24 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

New user is told "install dinosaurs, you can trust epriestley.

Aug 24 2020, 4:49 PM · Arcanist

Aug 22 2020

avivey added a comment to T5055: Distribution mechanism for arc extensions.

The public key won't necessarily be available to Phabricator (because it's kinda funny to have the public key and signature in the same place). We'll just register the fingerprints I guess?

I think the public key has to be available -- you can't verify signatures otherwise.

Aug 22 2020, 6:28 AM · Arcanist

Aug 21 2020

epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Distribution would just be zip/tgz files for each package

Aug 21 2020, 5:01 PM · Arcanist
avivey added a comment to T5055: Distribution mechanism for arc extensions.

I think I'm going to start working on the Arcanist side of this soon...

Aug 21 2020, 12:15 PM · Arcanist
alexnb awarded Blog Post: Quick Look: Suggesting Edits with Inline Comments a Love token.
Aug 21 2020, 8:31 AM · Differential, Quick Look

Aug 20 2020

Firehed added a comment to T13575: PHP built-in webserver fails on POST.

For what it's worth, the only reason I was trying to figure out stuff with the built-in server was because at the time trying to get Phabricator running in Docker correctly was... not nearly as easy as I would have liked. Quickly skimming online suggests that's improved in the interim.

Aug 20 2020, 8:06 PM · Infrastructure
avivey added a comment to T13575: PHP built-in webserver fails on POST.

Yeah, it might make sense to drop it; I use it because it's easier to setup then Apache and the error log is right in my console, but setting up a real server isn't that much of a bother, except for Apple changing the rugs on you every other day (Soon with both x86 and ARM versions!)

Aug 20 2020, 7:39 PM · Infrastructure
epriestley added a project to T13575: PHP built-in webserver fails on POST: Infrastructure.
Aug 20 2020, 6:48 PM · Infrastructure
epriestley added a comment to T13575: PHP built-in webserver fails on POST.

I wonder if maintaining support for the builtin webserver is worthwhile -- I never use it, and I feel like I only see it referenced when users report bugs like this in the vein of "PHP builtin webserver has been completely broken for 13 years", which suggests it's probably not seeing very much use in the wild, either.

Aug 20 2020, 6:47 PM · Infrastructure
avivey created T13575: PHP built-in webserver fails on POST.
Aug 20 2020, 5:43 PM · Infrastructure

Aug 17 2020

epriestley added a subtask for T13574: Make responsive UI elements respond to container width, not window width: T13521: FormationView could do more Javascript magic around device layouts and header elements.
Aug 17 2020, 3:52 PM · Design
epriestley added a parent task for T13521: FormationView could do more Javascript magic around device layouts and header elements: T13574: Make responsive UI elements respond to container width, not window width.
Aug 17 2020, 3:52 PM · Differential
epriestley triaged T13574: Make responsive UI elements respond to container width, not window width as Low priority.
Aug 17 2020, 3:52 PM · Design
epriestley added a comment to T13573: When printing, render dates in an absolute, context-free format.

See also T9854: Support date/time reformatting in Remarkup for a related change, although I think neither feature directly impacts the other.

Aug 17 2020, 3:34 PM · Infrastructure
epriestley updated the task description for T13573: When printing, render dates in an absolute, context-free format.
Aug 17 2020, 3:33 PM · Infrastructure
epriestley triaged T13573: When printing, render dates in an absolute, context-free format as Normal priority.
Aug 17 2020, 3:32 PM · Infrastructure
epriestley triaged T13572: Daemon overseers may have a slow memory leak, possibly in FuturePool as Low priority.
Aug 17 2020, 3:17 PM · Daemons

Aug 14 2020

Krinkle renamed T5270: Allow creation of a Parent task (new task with a preset dependency) from Allow adding dependencies directly when creating a Maniphest (sub-)task to Allow creation of a Parent task (new task with a preset dependency).
Aug 14 2020, 6:15 PM · Maniphest

Aug 13 2020

epriestley triaged T13571: When viewing LFS files in Differential or Diffusion, show blob content where reasonable as Normal priority.
Aug 13 2020, 8:12 PM · Diffusion, Differential
epriestley claimed T13570: Amazon is retiring SMTP V3 Signatures.

I think every other AWS interaction already uses v4, since D14978 (January 2016).

Aug 13 2020, 4:00 PM · Mail
aeiser updated the task description for T13570: Amazon is retiring SMTP V3 Signatures.
Aug 13 2020, 1:55 PM · Mail
aeiser created T13570: Amazon is retiring SMTP V3 Signatures.
Aug 13 2020, 1:54 PM · Mail

Aug 12 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 9:19 PM · Differential
epriestley triaged T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail as Wishlist priority.
Aug 12 2020, 8:32 PM · Daemons
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 8:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:42 PM · Differential
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

Internally, see also PHI1785.

Aug 12 2020, 7:22 PM · Diffusion, Bug Report
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:11 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:08 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 7:02 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 6:41 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 6:32 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 4:31 PM · Differential
epriestley triaged T13568: In "arc land --incremental", rebased branches are not repeatedly rebased as changes iterate as Low priority.
Aug 12 2020, 4:02 PM · Arcanist
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Aug 12 2020, 3:54 PM · Differential

Aug 11 2020

epriestley triaged T13567: Arcanist does not decode unicode filenames in Git before passing them to linters as Low priority.
Aug 11 2020, 6:38 PM · Arcanist
epriestley renamed T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits from Improve fallback behavior for "arc branches/bookmarks" to Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13566: Improve fallback behavior for "arc branches/bookmarks" when unpublished local state appears to have >1K commits as Normal priority.
Aug 11 2020, 6:34 PM · Arcanist
epriestley triaged T13565: Filesystem write failure error messages lack tailoring, notably in DeferredLog as Normal priority.
Aug 11 2020, 6:04 PM · Infrastructure
epriestley updated the task description for T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions.
Aug 11 2020, 5:47 PM · Windows, Arcanist
epriestley added a comment to T13564: Remarkup tables should show all content when printed to PDF.

Adding overflow-wrap: anywhere appears to fix this without breaking anything.

Aug 11 2020, 5:35 PM · Google Chrome, Remarkup
epriestley triaged T13564: Remarkup tables should show all content when printed to PDF as Normal priority.
Aug 11 2020, 5:17 PM · Google Chrome, Remarkup
epriestley triaged T13563: On Windows, Arcanist tries and fails to set stdin nonblocking while reading the stream as Low priority.
Aug 11 2020, 5:06 PM · Windows, Arcanist
epriestley triaged T13562: Windows may have irregular behaviors in unusual cases when copying a file to preserve attributes/permissions as Normal priority.
Aug 11 2020, 5:02 PM · Windows, Arcanist
epriestley added a revision to T9924: Add support for git worktree: Unknown Object (Differential Revision).
Aug 11 2020, 4:45 PM · FreeBSD, Restricted Project, Arcanist, Feature Request
epriestley updated the task description for T13561: Allow the daemons to generate tasks dynamically at runtime.
Aug 11 2020, 3:26 PM · Daemons
epriestley triaged T13561: Allow the daemons to generate tasks dynamically at runtime as Normal priority.
Aug 11 2020, 3:15 PM · Daemons
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1816 would also like dimensional coverage: coverage by language; coverage by team/owner. This is perhaps worth considering in how coverage is aggregated.

Aug 11 2020, 2:54 PM · Diffusion, Plans
epriestley triaged T11372: Multiple coverage columns for different types of code coverage as Wishlist priority.
Aug 11 2020, 2:49 PM · Diffusion, Restricted Project
epriestley updated the task description for T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:48 PM · Diffusion, Plans
epriestley added subtasks for T13125: Plans: Code coverage reporting: T11372: Multiple coverage columns for different types of code coverage, T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Aug 11 2020, 2:47 PM · Diffusion, Plans
epriestley added a parent task for T9524: Show aggregate subdirectory coverage in Diffusion browse views: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project
epriestley added a parent task for T11372: Multiple coverage columns for different types of code coverage: T13125: Plans: Code coverage reporting.
Aug 11 2020, 2:47 PM · Diffusion, Restricted Project

Aug 10 2020

epriestley triaged T13560: "Large number of changes" transaction timeline banner may hide a single change as Wishlist priority.
Aug 10 2020, 8:38 PM · Design
epriestley added a project to T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting: Accessibility.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting as Wishlist priority.
Aug 10 2020, 8:18 PM · Accessibility, Differential
epriestley triaged T13558: Duration computation on user profiles is silly as Wishlist priority.
Aug 10 2020, 8:15 PM · Design

Aug 8 2020

epriestley edited the content of Changelog.
Aug 8 2020, 2:39 AM
epriestley created an object: 2020 Week 31 (Early August).
Aug 8 2020, 2:38 AM

Aug 5 2020

epriestley updated the task description for T13241: Guide: SMS is Insecure.
Aug 5 2020, 7:22 PM · Security, Guides
epriestley triaged T13557: Unified diffs could do a better job of rendering omitted trailing newlines as Wishlist priority.
Aug 5 2020, 5:07 PM · Differential

Jul 28 2020

epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 28 2020, 6:15 PM · Differential
epriestley added a revision to T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch: Unknown Object (Differential Revision).
Jul 28 2020, 5:08 PM · Differential

Jul 27 2020

epriestley updated the task description for T13548: Upgrading: Mid 2020 Changes to "arc feature" / "arc branch" / "arc bookmark".
Jul 27 2020, 6:06 PM · Guides, Arcanist

Jul 25 2020

epriestley edited the content of Changelog.
Jul 25 2020, 3:26 PM
epriestley created an object: 2020 Week 29 (Late July).
Jul 25 2020, 3:25 PM
avivey added a comment to T13550: Strip markup from project descriptions displayed in the "Browse Projects" dialog.

related to T3278, probably?

Jul 25 2020, 10:57 AM · Typeahead, Feature Request

Jul 24 2020

epriestley added a comment to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.

In D21426, I removed phd.trace and phd.verbose.

Jul 24 2020, 12:18 AM · Daemons

Jul 23 2020

epriestley added a revision to T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes: Unknown Object (Differential Revision).
Jul 23 2020, 7:22 PM · Daemons
epriestley claimed T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes.
Jul 23 2020, 6:05 PM · Daemons
epriestley triaged T13556: Setting "phd.trace" may cause TTY testing with "posix_isatty()" against closed pipes as Wishlist priority.
Jul 23 2020, 6:05 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:40 PM · Daemons
epriestley added a comment to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall.

The call sequence here is approximately:

Jul 23 2020, 5:11 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:09 PM · Daemons
epriestley added a revision to T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall: Unknown Object (Differential Revision).
Jul 23 2020, 5:07 PM · Daemons
epriestley triaged T13555: In "ExecFuture", "proc_get_status()" may be passed NULL, possibly leading to a daemon stall as Normal priority.
Jul 23 2020, 2:58 PM · Daemons
epriestley closed T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Resolved by committing Restricted Diffusion Commit.
Jul 23 2020, 2:46 PM · Infrastructure
epriestley added a revision to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()": Unknown Object (Differential Revision).
Jul 23 2020, 2:40 PM · Infrastructure
epriestley added a comment to T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()".

This is a PCRE backtracking issue. It reproduces on an input corpus of length 3,277 bytes with only "x", " " (space), and "\n" (newline) characters, and disappears if I increase pcre.backtrack_limit.

Jul 23 2020, 2:36 PM · Infrastructure
epriestley triaged T13554: Undefined offset exception in "PhutilProseDifferenceEngine::stitchPieces()" as Low priority.
Jul 23 2020, 1:41 PM · Infrastructure

Jul 22 2020

epriestley added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

Please use Discourse to discuss Phabricator.

Jul 22 2020, 11:49 PM · Arcanist, Guides
jbrownEP added a comment to T13545: Upgrading: Mid 2020 Changes to "arc diff".

This task references more details on "Excuses" and "Prompts", but there isn't any. Is there any way to provide context around lint issues?

Jul 22 2020, 11:46 PM · Arcanist, Guides

Jul 21 2020

ipalencar updated ipalencar.
Jul 21 2020, 6:42 PM