Page MenuHomePhabricator
Feed All Stories

Jan 29 2016

chad added a revision to T10244: Exception in Differential on b8139e6946eac: Unknown Object (Differential Revision).
Jan 29 2016, 8:40 PM · Bug Report
chad added a comment to T10244: Exception in Differential on b8139e6946eac.

thanks, fixing.

Jan 29 2016, 8:34 PM · Bug Report
rbalik created T10244: Exception in Differential on b8139e6946eac.
Jan 29 2016, 8:17 PM · Bug Report
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

This may actually be not-too-terrible. I think there's a good chance that db005 really does have less than 22% of a volume of "actual" data, since the compressed size of backups for all active instances on the shard is only about 300MB. We had a bunch of heavy test instance churn on that shard for whatever reason.

Jan 29 2016, 8:06 PM · Phacility
epriestley added a comment to T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.

I'm going to do this tonight/tomorrow, but this is going to be fairly involved. Current utilization is:

Jan 29 2016, 7:49 PM · Phacility
cburroughs created T10243: pants unit test engine.
Jan 29 2016, 7:29 PM · Restricted Project, Restricted Project, Unit, Feature Request
chad renamed T10242: Images uploaded to user profile descriptions unviewable from Images upload to user profile descriptions unviewable to Images uploaded to user profile descriptions unviewable.
Jan 29 2016, 7:17 PM · People, Bug Report
avivey edited the content of Community Resources.
Jan 29 2016, 7:09 PM
cburroughs edited P1934 PantsTestEngine.php.
Jan 29 2016, 7:09 PM
chad added a project to T10242: Images uploaded to user profile descriptions unviewable: People.
Jan 29 2016, 7:04 PM · People, Bug Report
chad created T10242: Images uploaded to user profile descriptions unviewable.
Jan 29 2016, 7:04 PM · People, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Works for me on the iPad Pro. Thank you!

Jan 29 2016, 7:02 PM · Safari, Mobile, Bug Report
cburroughs created P1934 PantsTestEngine.php.
Jan 29 2016, 6:58 PM
benfiola added a comment to T9334: Improve documentation for differential.setdiffproperty.

Sorry to necro an old thread, but I, too, am looking for information about this particular API method.

Jan 29 2016, 6:22 PM · Conduit
epriestley awarded T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials a Evil Spooky Haunted Tree token.
Jan 29 2016, 6:00 PM · Passphrase, Diffusion, Bug Report
cspeckmim updated the task description for T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials.
Jan 29 2016, 5:58 PM · Passphrase, Diffusion, Bug Report
cspeckmim updated the task description for T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials.
Jan 29 2016, 5:57 PM · Passphrase, Diffusion, Bug Report
cspeckmim created T10241: Modifying an externally-hosted repository's URL/path can unintentionally change the credentials.
Jan 29 2016, 5:56 PM · Passphrase, Diffusion, Bug Report
epriestley added a comment to T10239: Ability to pass more info to custom linters.

what the heck

Jan 29 2016, 5:18 PM · Feature Request
jlebar added a comment to T10239: Ability to pass more info to custom linters.

Yeah, I checked before writing that last post, and I thought the same thing, but it's not split up the way we want. e.g.

Jan 29 2016, 5:15 PM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

Maybe clang-format could be changed to give an output that's properly "split up" -- I don't know how feasible it would be, but given how fiddly it is (the whole tool is a collection of special cases), I expect that would be Hard.

Jan 29 2016, 5:11 PM · Feature Request
jlebar added a comment to T10239: Ability to pass more info to custom linters.

I think the piece of information that differs between your model and the actual behavior of arc is that the linter does not (and must not) emit three separate corrections to fix foo(a, b, ...) one line at a time. It should emit a single correction for the entire block.

Jan 29 2016, 4:59 PM · Feature Request
chad added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Seems OK for me on a physical iPhone 4s.

Jan 29 2016, 4:02 PM · Safari, Mobile, Bug Report
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Jan 29 2016, 3:01 PM
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

This is live on this server (secure.phabricator.com) -- let us know if you're still seeing issues. Seems OK for me on a physical iPhone 4s.

Jan 29 2016, 2:59 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

This is now deployed to this server (secure.phabricator.com) -- let me know if you're still seeing issues? Behavior seems OK in the simulator and with my physical iPhone 4s, but I don't have a fancy physical 6s to test.

Jan 29 2016, 2:57 PM · Safari, Differential, Bug Report
epriestley closed T10229: In iOS Safari, buttons must be tapped twice to fire. as Resolved by committing Restricted Diffusion Commit.
Jan 29 2016, 2:55 PM · Safari, Mobile, Bug Report
epriestley closed T9969: Differential 1-up render doesn't trigger on iOS as Resolved by committing Restricted Diffusion Commit.
Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Specifically, this is my best guess at what's going on:

Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley claimed T9969: Differential 1-up render doesn't trigger on iOS.
Jan 29 2016, 2:48 PM · Safari, Differential, Bug Report
epriestley claimed T10229: In iOS Safari, buttons must be tapped twice to fire..
Jan 29 2016, 2:47 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yep and to be honest this huge iPad is fairly desktop-y. The first time I saw it I kind of had to look twice to make sure it wasn't some run away item from Alice in Wonderland that had snuck into my reality.

Jan 29 2016, 2:20 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I've marked D15135 as fixing this out of a general abundance of sunny optimism.

Jan 29 2016, 1:58 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I think D15135 actually fixes this. I can't reproduce it in iOS Simulator after applying that patch.

Jan 29 2016, 1:57 PM · Safari, Differential, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

D15136 distinguishes between "touch-device" mouseovers and "mouse-device" mouseovers rather than relying on device detection, since the screen resolution of the iPad Pro is apparently a billion pixels by a trillion pixels and device detection is clearly increasingly hopeless.

Jan 29 2016, 1:51 PM · Safari, Mobile, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: Unknown Object (Differential Revision).
Jan 29 2016, 1:49 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I gave this solution a quick whirl and it works. It preserves mouse over behaviour in regular browsers, and removes the need for double tapping in iOS (while still getting the selection highlights). Let me know if you'd like a patch or if you prefer your device detection approach.

Jan 29 2016, 1:31 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Yeah. On a pure touch device, mouseover is not the most useful event to listen for when it comes to highlighting rows.

Jan 29 2016, 1:15 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Nice work! I arrived at the same conclusion shortly after you did.

Jan 29 2016, 1:09 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

I have found the bug. For iOS Safari to send a click event, the handlers of mouseover and mousemove must not change the document content. (Presumably to allow a touch user to reveal things that require mousing over, without actually clicking things.)

Jan 29 2016, 1:02 PM · Safari, Mobile, Bug Report
epriestley added a revision to T9969: Differential 1-up render doesn't trigger on iOS: Unknown Object (Differential Revision).
Jan 29 2016, 1:00 PM · Safari, Differential, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: Unknown Object (Differential Revision).
Jan 29 2016, 1:00 PM · Safari, Mobile, Bug Report
epriestley reopened T10229: In iOS Safari, buttons must be tapped twice to fire. as "Open".

I can reproduce this on my iPhone 4s which correctly selects 1-up mode, so I agree that this is probably not a duplicate of T9969.

Jan 29 2016, 12:57 PM · Safari, Mobile, Bug Report
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Okay I don't think it's related to the 1up vs 2up renderer. Reading the source code I found out that the "1up" renderer seems to be triggered for certain screen widths. So I used an iOS Split View to reduce the width of my browser until it was fairly narrow, and as result I got a unified diff instead, which I believe is the "1up" view.

Jan 29 2016, 12:04 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10239: Ability to pass more info to custom linters.

(Oh, there's a missing comma after e in some of the output above, but that's just because I typed the replacement text for the patch wrong in my "linter".)

Jan 29 2016, 11:53 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

Here's what I did:

Jan 29 2016, 11:52 AM · Feature Request
flippingtables added a comment to T8072: Get en exception when set policy.allow-public to true.

I got the same issue. Fixed it by manually updating the database entry for the ui.custom-header file.

Jan 29 2016, 10:05 AM
aljungberg added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Not sure what the "1-up renderer" is but if it's 1 vs 2 columns, that's not the problem really. The formatting of the diff is fine (it's a large, desktop size screen).

Jan 29 2016, 10:02 AM · Safari, Mobile, Bug Report
hartman added a comment to T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".

@epriestley this is already a vast improvement, thanx for {D15093}.

Jan 29 2016, 8:37 AM · Projects, Wikimedia, Workboards
chad added a comment to T10240: Copy Comment.

"View Raw" is our solution to the problem you describe. It allows you to review the Remarkup in any comment and paste wherever you like. "Edit" is only available to the comment owner.

Jan 29 2016, 7:36 AM · Feature Request (Needs Information)
• oysterFAKE added a comment to T10240: Copy Comment.

Unless I'm overlooking something, view raw leads to the same workflow as edit: still need to select and paste into comment box

Jan 29 2016, 6:59 AM · Feature Request (Needs Information)
chad added a comment to T10240: Copy Comment.

View Raw

Jan 29 2016, 6:06 AM · Feature Request (Needs Information)
• oysterFAKE updated the task description for T10240: Copy Comment.
Jan 29 2016, 6:03 AM · Feature Request (Needs Information)
• oysterFAKE created T10240: Copy Comment.
Jan 29 2016, 6:02 AM · Feature Request (Needs Information)
jlebar added a comment to T10239: Ability to pass more info to custom linters.

I haven't tried to write this rule, and you've almost convinced me to try, but -- forgive me -- I don't quite believe it's possible to do this correctly (or, as correctly as clang-format) in the context of formatting C++.

Jan 29 2016, 3:04 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

(Where "XYZ" and "QWERTY" can be arbitrarily long sequences and may each contain zero or more newlines, and may each be of arbitrary length -- you can replace a single character with a huge block, or vice versa, etc. -- lint is not line-oriented internally.)

Jan 29 2016, 2:18 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

The expectation is that this will just work properly already. We have a number of similar rules in the upstream.

Jan 29 2016, 2:17 AM · Feature Request
jlebar added a comment to T10239: Ability to pass more info to custom linters.

Thank you for your quick response.

Jan 29 2016, 1:16 AM · Feature Request
jdforrester added a comment to T10238: File remains 'attached' to a ticket even once removed from any current comment.

Should the user be warned that invisible files are still attached when they remove them?

Jan 29 2016, 1:10 AM · Maniphest, Files, Bug Report
epriestley added a comment to T10239: Ability to pass more info to custom linters.
  • Emit messages for every line with a problem.
  • If you raise them at "warning" severity, they will only be shown if the user modified the line.
Jan 29 2016, 1:02 AM · Feature Request
cspeckmim added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.
In T10233#155967, @chad wrote:

Well it was mandatory.

happycat.jpg (740×600 px, 190 KB)

Jan 29 2016, 12:59 AM · Restricted Project, Bug Report
jlebar created T10239: Ability to pass more info to custom linters.
Jan 29 2016, 12:57 AM · Feature Request

Jan 28 2016

epriestley closed T10238: File remains 'attached' to a ticket even once removed from any current comment as Wontfix.

This is intentional. The file is visible in the UI in the edit history of the comment, and still part of the object in that sense.

Jan 28 2016, 10:45 PM · Maniphest, Files, Bug Report
avivey added a project to T10237: Pylint Linter fails on some specific python cases: Lint.
Jan 28 2016, 10:21 PM · Lint, Bug Report
jdforrester created T10238: File remains 'attached' to a ticket even once removed from any current comment.
Jan 28 2016, 10:20 PM · Maniphest, Files, Bug Report
eadler moved T4184: API does not contain user.create from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 28 2016, 10:09 PM · Restricted Project, FreeBSD, Auth, Conduit
eadler added a project to T4184: API does not contain user.create: Restricted Project.
Jan 28 2016, 10:09 PM · Restricted Project, FreeBSD, Auth, Conduit
DheerendraRathor updated the task description for T10237: Pylint Linter fails on some specific python cases.
Jan 28 2016, 10:04 PM · Lint, Bug Report
DheerendraRathor added a comment to T10237: Pylint Linter fails on some specific python cases.

For now I've modified my local copy of this file and did few changes like:

Jan 28 2016, 10:04 PM · Lint, Bug Report
DheerendraRathor created T10237: Pylint Linter fails on some specific python cases.
Jan 28 2016, 9:50 PM · Lint, Bug Report
epriestley added a comment to T5240: Dragging items (cards, panels) could be better in Workboards.

I think we can do the background drag thing too, that shouldn't interact poorly with anything else (I think? Probably?).

Jan 28 2016, 9:21 PM · Projects (v3), Workboards
chad added a comment to T5240: Dragging items (cards, panels) could be better in Workboards.

We're probably going to do per column scrolling, or at least see how it feels in testing. Will have to see where we end up.

Jan 28 2016, 9:20 PM · Projects (v3), Workboards
cspeckmim added a comment to T5240: Dragging items (cards, panels) could be better in Workboards.

In a semi-related topic, I find myself constantly expecting Trello-style behavior where a user can click + drag outside of cards to scroll vertically/horizontally.

Jan 28 2016, 9:17 PM · Projects (v3), Workboards
• cardsat added a comment to T4853: A "tracked time per project" would be really usefull for project manager..

i totally agree we need a time tracking in phabricator

Jan 28 2016, 7:48 PM · Phrequent
epriestley closed T10226: diffusion blame: Only first line number is highlighted as Resolved by committing Restricted Diffusion Commit.
Jan 28 2016, 7:17 PM · Diffusion, Bug Report
epriestley added a revision to T10226: diffusion blame: Only first line number is highlighted: Unknown Object (Differential Revision).
Jan 28 2016, 7:10 PM · Diffusion, Bug Report
avivey closed T10176: JIRA links sorted by count of lines as Resolved by committing Restricted Diffusion Commit.
Jan 28 2016, 6:48 PM · Restricted Project, Doorkeeper
avivey added a comment to Q293: How to reorder Revision Update History in Differential (Answer 317).

You can't edit the revision history; However, only the latest diff is "active" - that's what shown in the UI, and those are the changes that will be committed when you arc land.

Jan 28 2016, 6:09 PM
epriestley created P1933 WMFLockTaskController.php.
Jan 28 2016, 6:06 PM
epriestley created P1932 WMFLockTaskEventListener.php.
Jan 28 2016, 6:05 PM
epriestley created P1931 WMFExtensionsApplication.php.
Jan 28 2016, 6:05 PM
• claudiomelis added a comment to Q293: How to reorder Revision Update History in Differential (Answer 317).

Which la what I tried to do but i was not able to replace the wrong one both the revisions are there :(

Jan 28 2016, 6:02 PM
avivey added Q293: How to reorder Revision Update History in Differential (Answer 317).
Jan 28 2016, 5:53 PM
epriestley closed T7160: Allow administrators to irrevocably destroy all data for a cancelled instance as Resolved.

bin/host destroy exists now and no one has specifically asked for this, so I think it's OK to leave it as an "email us" option until the workload justifies making it explicit.

Jan 28 2016, 5:37 PM · Phacility
epriestley closed T10166: Build a permanent destruction workflow for Phacility instances as Resolved.

I've implemented this and relieved pressure on db005, although see followup in T10236.

Jan 28 2016, 5:37 PM · Phacility
epriestley created T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
Jan 28 2016, 5:36 PM · Phacility
• claudiomelis updated Q293: How to reorder Revision Update History in Differential from to How to reorder Revision Update History in Differential.
Jan 28 2016, 4:53 PM · Differential
mliberty awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Jan 28 2016, 3:14 PM · Calendar
epriestley added a revision to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails: Unknown Object (Differential Revision).
Jan 28 2016, 2:40 PM · Phacility, Diffusion
joshuaspence added a project to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Remarkup.
Jan 28 2016, 9:51 AM · Remarkup, Bug Report
Luke081515.2 updated the question details for Q291: Which lint script is it....?.
Jan 28 2016, 9:36 AM · Lint
art_reviewer added a comment to Q292: MySQL Config.

Chad, thanks a lot for your help. I will check out the install script.

Jan 28 2016, 6:42 AM
chad closed T10235: Test Feature Task as Spite.

sadpanda

Jan 28 2016, 6:41 AM · Infrastructure, Feature Request
• prasannashr added a member for Feature Request: • prasannashr.
Jan 28 2016, 6:40 AM
chad added a comment to Q292: MySQL Config.

I did read that Oracle Linux is essentially RHEL, so maybe our install script will provide some additional insight. https://github.com/phacility/phabricator/blob/master/scripts/install/install_rhel-derivs.sh

Jan 28 2016, 6:37 AM
• prasannashr updated subscribers of T10235: Test Feature Task.
Jan 28 2016, 6:37 AM · Infrastructure, Feature Request
• prasannashr created T10235: Test Feature Task.
Jan 28 2016, 6:36 AM · Infrastructure, Feature Request
chad added a comment to Q292: MySQL Config.

I've never heard of anyone having similar issues. My guess is something is wrong, mis-compiled, or misconfigured at the PHP / OS level and we're not going to be able to help you figure that one out. In general, our expectation is Phabricator will be installed on a normal computer, and one that a user has normal (admin) rights to.

Jan 28 2016, 6:35 AM
• prasannashr added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

ds fd fddgfdhgh

Jan 28 2016, 6:33 AM · Restricted Project, Bug Report
art_reviewer added a comment to Q292: MySQL Config.

Please find the command i ran an the output i got. it doesn't show all config variables as you said.

Jan 28 2016, 6:24 AM