Page MenuHomePhabricator
Feed All Stories

Apr 29 2023

cspeckmim added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

I was ready to suggest that after further investigation was made, recalling the "recent" refactor work of the mercurial command-with-extensions changes we looked at 馃槃

Apr 29 2023, 7:46 PM 路 Infrastructure
epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

For https://we.phorge.it/T15281, consider modifying DiffusionGitCommandEngine->newFormattedCommand() to pass explicit configuration to Git (as we do in Mercurial) rather than requiring administrators correctly configure Git via .gitconfig via $HOME.

Apr 29 2023, 7:39 PM 路 Infrastructure
cspeckmim added a comment to T13588: PHP 8 Compatibility.

Gotcha. I'm going to take a swing at updating past 8.0 and see what crops up. Also thanks for the tip with PHPAST. I haven't looked too much into it other than trying to get it working on Windows a year or so back

Apr 29 2023, 4:49 PM 路 Infrastructure
epriestley added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

With the caveat that I mostly dig holes in the dirt now and no longer remember how computers work:

Apr 29 2023, 2:45 PM 路 Infrastructure
cspeckmim added a comment to T12071: Require "E" be defined in variables_order so $_ENV is correctly populated.

Would this be reasonable to address with a new server-side setup check, similar to the checks for post_max_size and op_cache values?

Apr 29 2023, 2:04 PM 路 Infrastructure

Apr 26 2023

epriestley added a comment to T13588: PHP 8 Compatibility.

I favor dealing with them on a case-by-case basis since they don't seem especially pervasive and I think in most of the cases where I've fixed the issue, the fix I chose wasn't just to swap the call. I think these strlen() errors are often a correct/useful symptom of undesirable slop in type handling.

Apr 26 2023, 7:29 PM 路 Infrastructure
cspeckmim added a comment to T13588: PHP 8 Compatibility.

PHP 8.1 disallows strlen(null).
...
Broadly, Phabricator likely will not pass the empty string as a constraint in these cases...
...
D21762 introduces phutil_nonempty_string(), which is like this test but slightly stricter (it raises an exception for wonky values) and easier to revisit later (i.e., use of this function is a hint that the code can be made more strict about value types).
...
Upshot:

  • if (strlen($maybe_null)) may be replaced in all cases with if (phutil_nonempty_string($maybe_null)) to work in PHP 8.1 and not break any code which wasn't already extremely suspicious (...stringlike() may be required if the value may be an object, usually a URI object).
  • This is usually not the most desirable replacement, but probably 95% of these aren't realistically worth being surgical about.
  • In new code, prefer increasing type strictness over these more-flexible tests.
Apr 26 2023, 7:05 PM 路 Infrastructure

Apr 25 2023

cspeckmim added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Apr 25 2023, 2:53 PM 路 Infrastructure

Apr 6 2023

sekimura updated sekimura.
Apr 6 2023, 12:34 AM

Apr 1 2023

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it?

Apr 1 2023, 1:58 PM 路 Hardware
avivey added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

If the small pipe needs to drain into the big one, how about taking a large pvc end-cap, drilling a 1/4" hold and forcing the smaller pipe in it? Maybe seal the whole thing with some silicone.

Apr 1 2023, 10:14 AM 路 Hardware

Mar 31 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

I've been using Fusion 360, which I'd say is "not bad". (See also T13697, perhaps.)

Mar 31 2023, 10:41 PM 路 Hardware
Korvin added a comment to T13689: A Considered Review: 3D Printing.

I'm curious what 3d modeling software you use, I've had success making simple boxes and things like that with sketchup but I've been a little intimidated by more advanced modeling software.

Mar 31 2023, 9:11 PM 路 Hardware

Mar 2 2023

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

...I suspect that's a difficult geometry for FDM in PLA.

Mar 2 2023, 5:46 PM 路 Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

These sewing machine shaft collars are kind of tricky: thread unspools around them, so the inward face must have a completely smooth edge that can't catch or snag. This rules out a simple clamping-style shaft collar with a slit in it.

Mar 2 2023, 6:33 AM 路 Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Spool Cap (Small)

Mar 2 2023, 6:13 AM 路 Hardware

Feb 17 2023

epriestley edited the content of Changelog.
Feb 17 2023, 6:49 PM
epriestley renamed 2023 Week 7 (Mid February) from 2023 Week 7 to 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley created an object: 2023 Week 7 (Mid February).
Feb 17 2023, 6:47 PM
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
Feb 17 2023, 6:35 PM 路 Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
Feb 17 2023, 6:30 PM 路 Remarkup

Feb 7 2023

epriestley closed T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Resolved.

ADPClientService is a (currently) non-essential background service that collects juicy user data to send to Autodesk, since there's no way they could be expected to make ends meet on just $545/year licenses alone. You can find lots of threads about how to disable it in various Autodesk products, but none of these instructions appear to work in the current version of Fusion 360.

Feb 7 2023, 5:36 AM 路 Hardware

Feb 5 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.
...
Focus taken by Safari.
Focus taken by ADPClientService.
Focus taken by Safari.
...
Feb 5 2023, 3:54 PM 路 Hardware

Feb 4 2023

epriestley added a comment to T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS.

It stopped doing it as soon as I started watching it. But just wait, I'll catch it in the act. >_> <_<

Feb 4 2023, 10:03 PM 路 Hardware
epriestley triaged T13697: Stop Fusion360 from arbitrarily stealing focus on MacOS as Low priority.
Feb 4 2023, 3:49 PM 路 Hardware
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Feb 4 2023, 1:50 PM 路 Infrastructure
epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Feb 4 2023, 1:03 PM 路 Infrastructure

Jan 23 2023

epriestley added a comment to T13689: A Considered Review: 3D Printing.

They sell "broken" Ender 3 printers on eBay for like $75 shipped. I ordered two. One had a bad board (a $40 part); one had a bad Y limit switch (a $3 part) -- so the actual cost per printer seems to be around ~$100 if you're familiar with how they work and can identify which parts aren't working.

Jan 23 2023, 7:36 PM 路 Hardware

Dec 22 2022

epriestley updated the task description for T13696: FAQ: Pocket Hole Joinery.
Dec 22 2022, 9:02 PM 路 Hardware

Dec 21 2022

epriestley triaged T13696: FAQ: Pocket Hole Joinery as Normal priority.
Dec 21 2022, 9:37 PM 路 Hardware
epriestley closed T13694: Create a "BRK/First Alert" smoke detector connector adapter as Resolved.

I traced the alarms back to Breaker #8 in Panel #2 (the detector tool actually worked okay this time). I disconnected the breaker and verified that killed the circuit. I swapped the alarms and updated the map of known breakers with this new information:

Dec 21 2022, 4:42 AM 路 Hardware

Dec 20 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

No great surprise, but the blue boards seem about the same as the red boards and have the same problems:

Dec 20 2022, 5:29 AM 路 Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

The genuine article is not a JST-VH 4-pin connector -- the connecting clip is a little different, and there's no hole in the housing for (unused) pin #2. However, the pin size and spacing is right, so you can cut the connecting clip off a JST-VH and melt one of the pins out and the connector will fit well enough.

Dec 20 2022, 12:46 AM 路 Hardware

Dec 16 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

I bought an oscilloscope and tested the speed signal of one of the new red boards once it arrived. The scope showed the perfectly sensible signal I expected, and the signal came off the board fine once I hooked it up. So maybe the first couple boards were legitimately bad?

Dec 16 2022, 10:35 PM 路 Hardware
epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

This connector has a 4mm pin pitch, but I had a great deal of difficulty finding a likely-seeming bare connector with a 4mm pitch. After resigning myself to a Digikey quest for a connector that will fit a board on T13692, which also has a "4mm" pitch I realize the pitch is probably not 4mm but 3.96mm -- a wonderful pitch for which many connectors are readily available.

Dec 16 2022, 10:13 PM 路 Hardware
epriestley closed T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Resolved.

Here's the updated lightbar:

Dec 16 2022, 1:19 AM 路 Hardware

Dec 14 2022

epriestley added a comment to T13694: Create a "BRK/First Alert" smoke detector connector adapter.

Here's my nice safe smoke detector power adapter:

Dec 14 2022, 11:23 PM 路 Hardware
epriestley added a comment to T13695: Improve performance of "MAXX Action Police Pursuit" vehicle.

There doesn't seem to be anything mechanically wrong with the toy, although the motor and gearbox don't seem to be accessible without breaking something.

Dec 14 2022, 12:46 AM 路 Hardware
epriestley triaged T13695: Improve performance of "MAXX Action Police Pursuit" vehicle as Normal priority.
Dec 14 2022, 12:06 AM 路 Hardware

Dec 13 2022

epriestley triaged T13694: Create a "BRK/First Alert" smoke detector connector adapter as Normal priority.
Dec 13 2022, 11:46 PM 路 Hardware

Dec 5 2022

epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

The capacitors on both boards arrived pretty banged up.

Dec 5 2022, 8:05 PM 路 Hardware
ggodlewski updated ggodlewski.
Dec 5 2022, 10:48 AM

Dec 3 2022

epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

String Shelf

Dec 3 2022, 7:36 AM 路 Hardware
epriestley attached a referenced file: F11291992: Screen Shot 2022-11-03 at 4.23.07 PM.png.
Dec 3 2022, 7:07 AM 路 Hardware
epriestley added a comment to T13693: Address various issues with Bernina B740 Sewing Machine.

Turny Thing

Dec 3 2022, 7:07 AM 路 Hardware
epriestley triaged T13693: Address various issues with Bernina B740 Sewing Machine as Normal priority.
Dec 3 2022, 6:52 AM 路 Hardware
epriestley added a comment to T13692: Build a portable motorized vehicle for a 3 year old.

Motor Drivers

Dec 3 2022, 6:18 AM 路 Hardware

Dec 1 2022

epriestley triaged T13692: Build a portable motorized vehicle for a 3 year old as Normal priority.
Dec 1 2022, 4:02 PM 路 Hardware

Nov 22 2022

epriestley triaged T13691: Prevent 2015 Audi Q3 radio from playing music on vehicle start as Normal priority.
Nov 22 2022, 9:51 PM 路 Hardware

Nov 20 2022

kaidowei updated kaidowei.
Nov 20 2022, 10:19 PM

Nov 4 2022

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Couple of years ago the furnace wasn't working so well. Light comes on, three reds. Pressure switch stuck open. I take off a panel, pull the pressure switches. The contacts close properly. No clue what's wrong. Call an HVAC guy. He's pretty busy. No problem, we got plenty of sweaters. Ha. He makes it out early the next week.

Nov 4 2022, 4:04 AM 路 Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

all my drains are belong to PVC

Nov 4 2022, 2:28 AM 路 Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

... condensate drain ...

Nov 4 2022, 12:28 AM 路 Hardware
epriestley triaged T13690: A Considered Review: PCB Manufacturing as Wishlist priority.
Nov 4 2022, 12:21 AM 路 Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

...there's enough absorbent material underneath the sink...

Nov 4 2022, 12:05 AM 路 Hardware

Nov 3 2022

epriestley updated the task description for T13689: A Considered Review: 3D Printing.
Nov 3 2022, 11:44 PM 路 Hardware
epriestley triaged T13689: A Considered Review: 3D Printing as Wishlist priority.
Nov 3 2022, 11:43 PM 路 Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

(You don't actually need a leak detector, I think there's enough absorbent material underneath the sink to last a long while before it damages the floor)

Nov 3 2022, 10:01 PM 路 Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Here is my bathroom sink. The right-most pipe coming out of the wall is the condensate drain from HVAC. The tailpiece is most definitely 1 1/4 and the rest of the piping is 1 1/2, at least to the naked eye.

Nov 3 2022, 9:41 PM 路 Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

I can't see a way to make the trap be any less garbage than it is because the 4" flanged tailpipe (the shortest flanged 1-1/4" tailpipe I could find) plus an additional 8" of tailpipe underneath it (the only 1-1/4" branch tailpipe I could find, which is only available with a slip fitting) means that the bottom of the lower tailpipe is super low. It looks like I left an extra 6" of flexible pipe on the drain side for fun, but that's just the rigid bottom of the tailpipe plus the minimum bend radius without making the flexible pipe start to crimp -- the bottom of the tailpipe is like 1-1/2" below the black plastic retainer clip.

Nov 3 2022, 9:09 PM 路 Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

A few more thoughts:

Nov 3 2022, 8:31 PM 路 Hardware
epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Since there's no fresh water supply to the dehumidifier I don't think there's much benefit to an air gap, as there's no way backflow could ever contaminate a supply line. A clogged sink drain could possibly drain sink water out through the dehumidifier bucket, but the top of the drain line is only ~1"-2" below the top of the sink so it would overflow the basin onto the floor before very long anyway.

Nov 3 2022, 8:14 PM 路 Hardware
jmeador added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

My terminology might be wrong throughout this but a couple thoughts:

Nov 3 2022, 4:51 PM 路 Hardware

Oct 26 2022

epriestley added a comment to T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe?.

Other options I explored and rejected:

Oct 26 2022, 8:42 PM 路 Hardware
epriestley triaged T13688: How do you reasonably plumb a 1/4" drain line into a 1-1/4" drain pipe? as Wishlist priority.
Oct 26 2022, 8:34 PM 路 Hardware
epriestley created Hardware.
Oct 26 2022, 8:32 PM
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
  • Inline Comments: See PHI2217. See PHI2206. Inline comments don't currently attach images.
  • Destroying Edges: See PHI2201. See PHI2217. Destroying files that have old edge types may raise warnings. The destruction still works, although it doesn't hit the edges.
  • Destroying Files: See PHI2217. Destroying an object doesn't destroy corresponding FileAttachment objects, so you can end up with ghosts in the UI.
Oct 26 2022, 8:08 PM 路 Remarkup
epriestley closed T13683: Security Guidance: References to Files in Remarkup as Resolved.

There are some remaining non-security bugs with this that I'll follow up on in T13682. I believe the security side of this is now resolved.

Oct 26 2022, 8:03 PM 路 Guides, Files, Security
epriestley added a comment to T13683: Security Guidance: References to Files in Remarkup .

The details of this attack will be disclosed at a later date, once installs have had some sort of plausible chance to upgrade.

Oct 26 2022, 8:01 PM 路 Guides, Files, Security
epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.

An earlier patch here (rCORE6d6170f76463) swapped binlogs to MIXED and set a 24-hour retention policy. This issue has not reoccurred in the cluster since that patch went out, but the root causes remain unresolved.

Oct 26 2022, 7:58 PM 路 Drydock
epriestley closed T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Resolved.

I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).

Oct 26 2022, 7:56 PM 路 EditEngine, Files
epriestley triaged T13687: Consider implementing "JsonSerializable" in Phobject to forbid serialization as Wishlist priority.
Oct 26 2022, 7:56 PM 路 Infrastructure
epriestley closed T13686: Disable Ubuntu unattended upgrades as Resolved.

I patched and partially deployed this in early August. Another unattended MySQL upgrade went out on Monday night, also didn't restart MySQL on affected hosts, and caused some downtime on hosts that didn't have the patch (to "disable unattended upgrades"). I've now deployed this everywhere, and am presuming this is fixed until evidence arises to the contrary.

Oct 26 2022, 7:53 PM 路 Phacility

Oct 25 2022

epriestley added a comment to T13686: Disable Ubuntu unattended upgrades.

See also PHI2219, PHI2220.

Oct 25 2022, 12:17 PM 路 Phacility

Aug 8 2022

epriestley added a comment to T13652: Notes on Ardunio CNC drivers.
FeatureDimension
Barrel6.8mm
Divot Size2.5mm H x 1.15mm W x 1.6mm D
Divot Distance7mm
Shaft~3mm
Aug 8 2022, 5:17 PM

Aug 1 2022

garoevans updated garoevans.
Aug 1 2022, 12:44 PM

Jul 29 2022

epriestley triaged T13686: Disable Ubuntu unattended upgrades as Normal priority.
Jul 29 2022, 12:16 PM 路 Phacility

Jul 8 2022

epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).

Jul 8 2022, 3:57 AM 路 EditEngine, Files
Krinkle added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

I believe we may be hitting either the problem one of the above commit fixes, or suffering from a similar caused as side-effect from it.

Jul 8 2022, 3:35 AM 路 EditEngine, Files

Jun 14 2022

epriestley added a revision to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization: Unknown Object (Differential Revision).
Jun 14 2022, 4:32 PM 路 EditEngine, Files
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.

...ideally this sort of thing should fail loudly at serialization time...

Jun 14 2022, 4:29 PM 路 EditEngine, Files
epriestley triaged T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Normal priority.
Jun 14 2022, 1:09 PM 路 EditEngine, Files

Jun 13 2022

epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.
  • The drydock_resource table could use a (status, ...) key to satisfy common/default queries.
Jun 13 2022, 1:16 PM 路 Drydock

Jun 9 2022

bagashe updated bagashe.
Jun 9 2022, 11:29 PM

Jun 7 2022

vm abandoned D15124: Add linter to support eslint.
Jun 7 2022, 9:42 PM
vm added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jun 7 2022, 7:48 PM 路 Infrastructure
epriestley triaged T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable as Normal priority.
Jun 7 2022, 3:04 AM 路 Drydock

Jun 3 2022

epriestley added a revision to T13588: PHP 8 Compatibility: Unknown Object (Differential Revision).
Jun 3 2022, 10:00 PM 路 Infrastructure

May 28 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 28 2022, 1:29 PM 路 Remarkup

May 27 2022

epriestley edited the content of Changelog.
May 27 2022, 6:33 PM
epriestley created an object: 2022 Week 21 (Late May).
May 27 2022, 6:14 PM
epriestley triaged T13683: Security Guidance: References to Files in Remarkup as Normal priority.
May 27 2022, 6:13 PM 路 Guides, Files, Security
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 27 2022, 5:14 PM 路 Remarkup

May 26 2022

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Restricted Differential Revision.
May 26 2022, 5:46 PM 路 Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 26 2022, 5:24 PM 路 Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 26 2022, 5:09 PM 路 Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 26 2022, 4:58 PM 路 Remarkup
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 26 2022, 4:40 PM 路 Remarkup
epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.

May 26 2022, 12:13 AM 路 Mail
epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": Unknown Object (Differential Revision).
May 26 2022, 12:10 AM 路 Remarkup