All Stories
Use Results
Edit Query
Hide Query

epriestley committed rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley).

Update Slowvote poll status to use sensible string constants

epriestley committed rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley).

Separate Slowvote poll status onto a dedicated object

epriestley closed D21847: Separate Slowvote poll status onto a dedicated object.

epriestley closed D21846: Update Slowvote voting methods to use sensible string constants.

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21848: Update Slowvote poll status to use sensible string constants.

May 27 2022, 5:14 PM · Remarkup

epriestley requested review of D21848: Update Slowvote poll status to use sensible string constants.

May 27 2022, 5:14 PM

May 26 2022

epriestley requested review of D21847: Separate Slowvote poll status onto a dedicated object.

May 26 2022, 5:46 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21847: Separate Slowvote poll status onto a dedicated object.

May 26 2022, 5:46 PM · Remarkup

May 26 2022, 5:27 PM

epriestley committed rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants (authored by epriestley).

Update Slowvote voting methods to use sensible string constants

May 26 2022, 5:27 PM

epriestley requested review of D21846: Update Slowvote voting methods to use sensible string constants.

May 26 2022, 5:24 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21846: Update Slowvote voting methods to use sensible string constants.

May 26 2022, 5:24 PM · Remarkup

epriestley closed D21845: Move Slowvote vote types to a separate object.

May 26 2022, 5:17 PM

epriestley committed rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley).

Move Slowvote vote types to a separate object

May 26 2022, 5:17 PM

epriestley updated the diff for D21845: Move Slowvote vote types to a separate object.

Update some file/class names.

May 26 2022, 5:09 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21845: Move Slowvote vote types to a separate object.

May 26 2022, 5:09 PM · Remarkup

epriestley requested review of D21845: Move Slowvote vote types to a separate object.

May 26 2022, 5:09 PM

epriestley committed rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley).

Update Slowvote to use sensible string constants for response visibility

May 26 2022, 4:59 PM

epriestley closed D21844: Update Slowvote to use sensible string constants for response visibility.

epriestley closed D21843: Move Slowvote response visibility to a separate object.

epriestley committed rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley).

Move Slowvote response visibility to a separate object

epriestley requested review of D21844: Update Slowvote to use sensible string constants for response visibility.

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21844: Update Slowvote to use sensible string constants for response visibility.

May 26 2022, 4:58 PM · Remarkup

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21843: Move Slowvote response visibility to a separate object.

May 26 2022, 4:40 PM · Remarkup

epriestley requested review of D21843: Move Slowvote response visibility to a separate object.

May 26 2022, 4:40 PM

epriestley committed rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley).

Migrate "SlowvotePoll" to modern mailkey storage

epriestley closed D21842: Migrate "SlowvotePoll" to modern mailkey storage.

epriestley closed D21841: Update nonstandard PHID key on "SlowvotePoll".

epriestley committed rPd91727e66ceb: Update nonstandard PHID key on "SlowvotePoll" (authored by epriestley).

Update nonstandard PHID key on "SlowvotePoll"

epriestley closed D21840: Update "Files" attachment table to show more attachment details and support detachment.

epriestley added a comment to T13065: Move storage for `mailKey` to the Mail application.

After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.

May 26 2022, 12:13 AM · Mail

epriestley requested review of D21842: Migrate "SlowvotePoll" to modern mailkey storage.

May 26 2022, 12:10 AM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21842: Migrate "SlowvotePoll" to modern mailkey storage.

May 26 2022, 12:10 AM · Remarkup

epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: D21842: Migrate "SlowvotePoll" to modern mailkey storage.

May 26 2022, 12:10 AM · Mail

epriestley requested review of D21841: Update nonstandard PHID key on "SlowvotePoll".

May 26 2022, 12:00 AM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21841: Update nonstandard PHID key on "SlowvotePoll".

May 26 2022, 12:00 AM · Remarkup

May 25 2022

May 25 2022, 7:56 PM

epriestley committed rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley).

Update "Files" attachment table to show more attachment details and support…

May 25 2022, 7:56 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21840: Update "Files" attachment table to show more attachment details and support detachment.

May 25 2022, 7:53 PM · Remarkup

epriestley requested review of D21840: Update "Files" attachment table to show more attachment details and support detachment.

May 25 2022, 7:53 PM

epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...

May 25 2022, 5:33 PM · Remarkup

epriestley closed D21839: Pass "object" to modular transaction methods explicitly.

May 25 2022, 5:25 PM

epriestley committed rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley).

Pass "object" to modular transaction methods explicitly

May 25 2022, 5:25 PM

epriestley requested review of D21839: Pass "object" to modular transaction methods explicitly.

May 25 2022, 5:18 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21839: Pass "object" to modular transaction methods explicitly.

May 25 2022, 5:18 PM · Remarkup

Undedist updated Undedist.

May 25 2022, 8:08 AM

May 24 2022

epriestley closed D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".

May 24 2022, 5:19 PM

epriestley committed rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley).

Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"

May 24 2022, 5:19 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".

May 24 2022, 5:08 PM · Remarkup

epriestley requested review of D21838: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery".

May 24 2022, 5:08 PM

epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

May 24 2022, 4:56 PM · Remarkup

epriestley closed D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.

May 24 2022, 4:50 PM

epriestley committed rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not… (authored by epriestley).

Provide a simple "Attach File" explicit workflow for files referenced but not…

May 24 2022, 4:50 PM

epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.

Rebuild Celerity map.

May 24 2022, 1:13 AM

epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.

Correct some translation strings.

May 24 2022, 1:13 AM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.

May 24 2022, 1:12 AM · Remarkup

epriestley requested review of D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.

May 24 2022, 1:12 AM

May 23 2022

epriestley closed D21836: Provide a rudimentary "Attached Files" curtain UI panel.

epriestley closed D21835: Give "FileAttachment" policy support and a query object.

epriestley committed rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel (authored by epriestley).

Provide a rudimentary "Attached Files" curtain UI panel

epriestley committed rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley).

Give "FileAttachment" policy support and a query object

epriestley committed rP631c36aee326: Don't consider file references inside quoted text blocks to grant "attachment… (authored by epriestley).

Don't consider file references inside quoted text blocks to grant "attachment…

epriestley closed D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".

epriestley closed D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.

epriestley committed rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit… (authored by epriestley).

Only attach files that are both referenced in Remarkup and attached by explicit…

epriestley closed D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".

epriestley requested review of D21836: Provide a rudimentary "Attached Files" curtain UI panel.

May 23 2022, 6:13 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21836: Provide a rudimentary "Attached Files" curtain UI panel.

May 23 2022, 6:13 PM · Remarkup

epriestley updated the diff for D21835: Give "FileAttachment" policy support and a query object.

Further improve unit test coverage and test "reference doesn't grant view permission".

May 23 2022, 6:11 PM

epriestley updated the diff for D21835: Give "FileAttachment" policy support and a query object.

Also fix indirect reference attachment/scrambling test.

May 23 2022, 5:49 PM

epriestley updated the diff for D21835: Give "FileAttachment" policy support and a query object.

Fix unit test.

May 23 2022, 5:33 PM

epriestley requested review of D21835: Give "FileAttachment" policy support and a query object.

May 23 2022, 5:24 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21835: Give "FileAttachment" policy support and a query object.

May 23 2022, 5:24 PM · Remarkup

epriestley closed D21834: Provide missing default attachment list for Files transactions.

May 23 2022, 4:24 PM

epriestley committed rP8cd02e6727e3: Provide missing default attachment list for Files transactions (authored by epriestley).

Provide missing default attachment list for Files transactions

May 23 2022, 4:24 PM

epriestley requested review of D21834: Provide missing default attachment list for Files transactions.

May 23 2022, 4:24 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21834: Provide missing default attachment list for Files transactions.

May 23 2022, 4:24 PM · Remarkup

May 20 2022

epriestley requested review of D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".

May 20 2022, 6:23 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21833: Don't consider file references inside quoted text blocks to grant "attachment intent".

May 20 2022, 6:23 PM · Remarkup

epriestley requested review of D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.

May 20 2022, 5:48 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21832: Only attach files that are both referenced in Remarkup and attached by explicit metadata.

May 20 2022, 5:48 PM · Remarkup

May 20 2022, 5:27 PM

epriestley committed rPcc44ae32c546: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl" (authored by epriestley).

Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl"

May 20 2022, 5:27 PM

epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".

May 20 2022, 5:24 PM · Remarkup

epriestley requested review of D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".

May 20 2022, 5:12 PM

epriestley added a revision to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default": D21831: Remove obsolete "setDisableMacros()" on "PhabricatorRemarkupControl".

May 20 2022, 5:12 PM · Remarkup

May 19 2022

epriestley closed D21830: Generate file attachment transactions for explicit Remarkup attachments on common edit pathways.

epriestley committed rP42876de60d28: Generate file attachment transactions for explicit Remarkup attachments on… (authored by epriestley).

Generate file attachment transactions for explicit Remarkup attachments on…

epriestley committed rPfee8297121f0: Remove file attachment edge types, including API access (authored by epriestley).

Remove file attachment edge types, including API access

epriestley committed rPb872640c160a: Remove all "FileHasObject" edge reads and writes (authored by epriestley).

Remove all "FileHasObject" edge reads and writes

epriestley closed D21823: Remove file attachment edge types, including API access.

epriestley closed D21820: Remove all "FileHasObject" edge reads and writes.

epriestley closed D21818: Copy file attachment edges to new storage.