Page MenuHomePhabricator
Feed All Stories

Mar 16 2021

epriestley renamed T13641: Support "Disabled" devices in Almanac from Support "Archived" devices in Almanac to Support "Disabled" devices in Almanac.
Mar 16 2021, 6:03 PM · Almanac
epriestley triaged T13641: Support "Disabled" devices in Almanac as Normal priority.
Mar 16 2021, 6:02 PM · Almanac
epriestley added a project to T13630: Move Phacility provisioning to Piledriver: Almanac.
Mar 16 2021, 5:45 PM · Almanac, Infrastructure, Phacility
epriestley moved T13287: Build general healthcheck infrastructure for monitoring services from Backlog to Health / Statistics on the Almanac board.
Mar 16 2021, 5:44 PM · Clusters, Almanac
epriestley moved T7338: Build more status tools for monitoring Phacility cluster health from Backlog to Health / Statistics on the Almanac board.
Mar 16 2021, 5:44 PM · Almanac, Phacility
epriestley archived Almanac (v2).
Mar 16 2021, 5:44 PM
epriestley closed T10246: Deploy Drydock in the Phacility cluster as Resolved.

At least some installs have been using Drydock in production for a while. This could be made easier -- and this task still has the best guide for it -- but I think nothing actionable here remains.

Mar 16 2021, 5:44 PM · Harbormaster (v3), Drydock (v3), Almanac (v2), Phacility
epriestley abandoned D21492: Fix php code example for conduit calls.

This isn't the most modern path, but I included a similar change in D21624.

Mar 16 2021, 5:31 PM
epriestley commandeered D21492: Fix php code example for conduit calls.
Mar 16 2021, 5:30 PM
epriestley committed rP42c0c0e3d23a: Remove or correct various "phabricator/" references to "libphutil" (authored by epriestley).
Remove or correct various "phabricator/" references to "libphutil"
Mar 16 2021, 5:28 PM
epriestley closed D21624: Remove or correct various "phabricator/" references to "libphutil".
Mar 16 2021, 5:28 PM
epriestley requested review of D21624: Remove or correct various "phabricator/" references to "libphutil".
Mar 16 2021, 5:27 PM
epriestley added a revision to T13395: Strip libphutil for parts: D21624: Remove or correct various "phabricator/" references to "libphutil".
Mar 16 2021, 5:26 PM · libphutil
epriestley triaged T13640: Improve sequencing of Futures in "--trace" output as Low priority.
Mar 16 2021, 5:24 PM · Infrastructure
epriestley closed D21623: Update Paste help to include missing "--".
Mar 16 2021, 4:29 PM
epriestley committed rARCcc23551a7de8: Update Paste help to include missing "--" (authored by epriestley).
Update Paste help to include missing "--"
Mar 16 2021, 4:29 PM
epriestley abandoned D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.

Please file bug reports via Discourse or, if applicable, your organization's support channel.

Mar 16 2021, 4:27 PM
epriestley commandeered D20855: Add index on dateCreated database field because it is used by Feed->Transactions functionality.
Mar 16 2021, 4:27 PM
epriestley abandoned D20856: Allow partial response of transaction history if it is overheating.

Please file bug reports via Discourse or, if applicable, your organization's support channel.

Mar 16 2021, 4:27 PM
epriestley commandeered D20856: Allow partial response of transaction history if it is overheating.
Mar 16 2021, 4:26 PM
epriestley abandoned D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.

Presumably mooted by T13552. If you believe there is still a bug here, please file it via Discourse or your organization's support channel.

Mar 16 2021, 4:26 PM
epriestley commandeered D20880: Force `PhabricatorRepositoryGitCommitMessageParserWorker` to be executed when changing commit from non permanent to permanent which ensures that corresponding Differential Revision is closed.
Mar 16 2021, 4:25 PM
epriestley abandoned D20936: Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class.

I'm not sure if this is a feature request, a bug report, or something else. Please file via Discourse and/or your support channel, don't send patches.

Mar 16 2021, 4:24 PM
epriestley commandeered D20936: Pass context object to PhabricatorMetaMTAMailBody as this is done in parent class.
Mar 16 2021, 4:24 PM
epriestley abandoned D21048: Do not count hidden changesets as changed changesets during diff comparison.

Please file bug reports via Discourse or, if applicable, your organization's support channel.

Mar 16 2021, 4:24 PM
epriestley commandeered D21048: Do not count hidden changesets as changed changesets during diff comparison.
Mar 16 2021, 4:23 PM
epriestley abandoned D21049: Add Email command to mute notifications for object.

Please file feature requests via your organization's support channel only.

Mar 16 2021, 4:23 PM
epriestley commandeered D21049: Add Email command to mute notifications for object.
Mar 16 2021, 4:22 PM
epriestley abandoned D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.

Please report this issue via Discourse, or, if applicable, your organization's support channel, rather than sending a patch.

Mar 16 2021, 4:21 PM
epriestley commandeered D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 4:19 PM
epriestley requested review of D21623: Update Paste help to include missing "--".
Mar 16 2021, 4:08 PM
epriestley created P2147 Command-Line Input.
Mar 16 2021, 4:04 PM
epriestley created P2146 Command-Line Input.
Mar 16 2021, 4:04 PM
artms added inline comments to D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:51 AM
artms updated the summary of D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:49 AM
artms requested review of D21622: Avoid possible HarbormasterBuildCommand leaks during job restarts.
Mar 16 2021, 11:49 AM

Mar 15 2021

Harbormaster failed to build B25267: rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query" for rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query"!
Mar 15 2021, 11:27 PM
Harbormaster failed to build B25266: rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer for rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer!
Mar 15 2021, 11:27 PM
Harbormaster failed to build B25270: rP38ef910da8ca: Move "Affected Path" index updates to a separate class for rP38ef910da8ca: Move "Affected Path" index updates to a separate class!
Mar 15 2021, 11:27 PM
Harbormaster failed to build B25272: rP01ea84029d88: Update table schema for "AffectedPath" table for rP01ea84029d88: Update table schema for "AffectedPath" table!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25273: rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the… for rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the…!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25271: rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove… for rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25275: rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes for rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25274: rP30d58de1bc22: Expose "affectedPaths" to "differential.revision.search" Conduit API method for rP30d58de1bc22: Expose "affectedPaths" to "differential.revision.search" Conduit API method!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25268: rPe730f55e8857: Retitle "Recently Open Revisions" panel to "Recent Open Revisions" for rPe730f55e8857: Retitle "Recently Open Revisions" panel to "Recent Open Revisions"!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25269: rPe919b4c35a2a: Add a debug view of the "Affected Path" index to Differential for rPe919b4c35a2a: Add a debug view of the "Affected Path" index to Differential!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25267: rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query" for rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query"!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25266: rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer for rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer!
Mar 15 2021, 11:20 PM
Harbormaster failed to build B25270: rP38ef910da8ca: Move "Affected Path" index updates to a separate class for rP38ef910da8ca: Move "Affected Path" index updates to a separate class!
Mar 15 2021, 11:20 PM
epriestley committed rP925c9a71e7ea: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the… (authored by epriestley).
Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the…
Mar 15 2021, 11:16 PM
epriestley committed rP26c68942bd00: Update "AffectedPath" table when a revision's repository changes (authored by epriestley).
Update "AffectedPath" table when a revision's repository changes
Mar 15 2021, 11:16 PM
epriestley committed rP30d58de1bc22: Expose "affectedPaths" to "differential.revision.search" Conduit API method (authored by epriestley).
Expose "affectedPaths" to "differential.revision.search" Conduit API method
Mar 15 2021, 11:16 PM
epriestley closed D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 11:16 PM
epriestley committed rP6d33ba7dc401: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove… (authored by epriestley).
Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…
Mar 15 2021, 11:16 PM
epriestley committed rP01ea84029d88: Update table schema for "AffectedPath" table (authored by epriestley).
Update table schema for "AffectedPath" table
Mar 15 2021, 11:16 PM
epriestley closed D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:16 PM
epriestley closed D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 11:16 PM
epriestley committed rP38ef910da8ca: Move "Affected Path" index updates to a separate class (authored by epriestley).
Move "Affected Path" index updates to a separate class
Mar 15 2021, 11:16 PM
epriestley closed D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 11:16 PM
epriestley closed D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 11:16 PM
epriestley committed rPe919b4c35a2a: Add a debug view of the "Affected Path" index to Differential (authored by epriestley).
Add a debug view of the "Affected Path" index to Differential
Mar 15 2021, 11:16 PM
epriestley closed D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 11:16 PM
epriestley committed rPe730f55e8857: Retitle "Recently Open Revisions" panel to "Recent Open Revisions" (authored by epriestley).
Retitle "Recently Open Revisions" panel to "Recent Open Revisions"
Mar 15 2021, 11:16 PM
epriestley closed D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 11:16 PM
epriestley committed rPc317d16bdd56: Lift peculiar side effect of path indexing out of indexer (authored by epriestley).
Lift peculiar side effect of path indexing out of indexer
Mar 15 2021, 11:16 PM
epriestley committed rPbcd592cf7e15: Remove support for "paths" parameter in "differential.query" (authored by epriestley).
Remove support for "paths" parameter in "differential.query"
Mar 15 2021, 11:16 PM
epriestley closed D21613: Remove support for "paths" parameter in "differential.query".
Mar 15 2021, 11:16 PM
epriestley closed D21612: Retitle "Recently Open Revisions" panel to "Recent Open Revisions".
Mar 15 2021, 11:16 PM
epriestley closed D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 11:16 PM
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:13 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley updated the task description for T13639: Allow revisions to be queried by affected path via the API.
Mar 15 2021, 11:12 PM · Conduit, Differential
epriestley requested review of D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:03 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21621: Expose "affectedPaths" to "differential.revision.search" Conduit API method.
Mar 15 2021, 11:02 PM · Conduit, Differential
epriestley requested review of D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 10:58 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21620: Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove "withPath()" from DifferentialRevisionQuery.
Mar 15 2021, 10:57 PM · Conduit, Differential
epriestley requested review of D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 10:53 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21619: Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the revision view.
Mar 15 2021, 10:52 PM · Conduit, Differential
epriestley requested review of D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 10:48 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21618: Update "AffectedPath" table when a revision's repository changes.
Mar 15 2021, 10:47 PM · Conduit, Differential
epriestley requested review of D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 10:38 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21617: Update table schema for "AffectedPath" table.
Mar 15 2021, 10:37 PM · Conduit, Differential
epriestley requested review of D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 9:00 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21616: Move "Affected Path" index updates to a separate class.
Mar 15 2021, 8:59 PM · Conduit, Differential
epriestley requested review of D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 8:45 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21615: Add a debug view of the "Affected Path" index to Differential.
Mar 15 2021, 8:44 PM · Conduit, Differential
epriestley added a comment to D21614: Lift peculiar side effect of path indexing out of indexer.

After this change, we always execute this code for any update. This is sort-of a functional change, but likely moot or moot-adjacent in practice. Previously:

Mar 15 2021, 5:53 PM
epriestley requested review of D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 5:51 PM
epriestley added a revision to T13639: Allow revisions to be queried by affected path via the API: D21614: Lift peculiar side effect of path indexing out of indexer.
Mar 15 2021, 5:50 PM · Conduit, Differential
epriestley closed T4401: Linking to lines in a diff as Wontfix.

(Internally, see PHI2020.)

Mar 15 2021, 5:30 PM · Differential
epriestley added a comment to T10219: Show suggested lint autofix in Differential web view.

This is relatively ripe for implementation now that inline comments support suggested edits.

Mar 15 2021, 5:15 PM · Lint, Differential
epriestley removed projects from T10219: Show suggested lint autofix in Differential web view: Restricted Project, Feature Request.
Mar 15 2021, 5:15 PM · Lint, Differential
epriestley closed T11608: Make it easier to review stacks of diffs as Wontfix.

This is very old, fairly vague, and doesn't have any clear modern customer interest. I'm open to implementing it, but would like a more clear/modern customer request before pursuing it.

Mar 15 2021, 5:14 PM · Restricted Project, Differential, Feature Request
epriestley moved T7333: Empty commits get same revision as parent from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential
epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Files, Differential, Diffusion
epriestley moved T13110: Plans: Hefty Differential revisions, draft state transitions, and exotic interactions from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Plans, Differential
epriestley moved T13161: Plans: Improve Differential diff display behaviors from Backlog to Next on the Differential board.
Mar 15 2021, 5:11 PM · Differential, Plans
epriestley moved T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Diffusion, Differential
epriestley moved T13425: Support diffs between abstract block lists in the UI from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Differential
epriestley moved T13513: Make schema changes to inlines to prepare for new inline features from Backlog to Next on the Differential board.
Mar 15 2021, 5:10 PM · Inline Comments, Diffusion, Differential