Page MenuHomePhabricator
Feed All Stories

Feb 14 2020

epriestley closed T13395: Strip libphutil for parts as Resolved.

I have another patch on top of D20998 which brings unit over, but it's currently so broken that it can't diff itself.

Feb 14 2020, 9:38 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 14 2020, 9:04 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 14 2020, 5:12 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 5:07 PM · Arcanist, Installing & Upgrading
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 4:50 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 14 2020, 4:47 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 4:46 PM · Arcanist, Installing & Upgrading
epriestley edited the content of Changelog.
Feb 14 2020, 4:45 PM
epriestley created an object: 2020 Week 7 (Mid February).
Feb 14 2020, 4:44 PM
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 4:41 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 14 2020, 4:38 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 4:33 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 14 2020, 4:30 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 14 2020, 12:21 PM · Arcanist, Installing & Upgrading

Feb 13 2020

epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 11:12 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 10:58 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 13 2020, 10:57 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 10:32 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 13 2020, 10:16 PM · Arcanist, Installing & Upgrading
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 13 2020, 10:09 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13098: Plans: Arcanist toolsets and extensions: Unknown Object (Differential Revision).
Feb 13 2020, 9:54 PM · Arcanist, Plans
epriestley added a revision to T13203: Arcanist Wilds Patch Notes (Ongoing): Unknown Object (Differential Revision).
Feb 13 2020, 9:54 PM · Arcanist, Plans
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 9:54 PM · libphutil
epriestley closed T13489: Fix implicit "XMLWriter" requirement when loading lint sinks, a subtask of T13395: Strip libphutil for parts, as Resolved.
Feb 13 2020, 9:38 PM · libphutil
epriestley closed T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Resolved by committing Restricted Diffusion Commit.
Feb 13 2020, 9:38 PM · Lint, libphutil
epriestley added a revision to T13489: Fix implicit "XMLWriter" requirement when loading lint sinks: Unknown Object (Differential Revision).
Feb 13 2020, 9:37 PM · Lint, libphutil
epriestley triaged T13489: Fix implicit "XMLWriter" requirement when loading lint sinks as Low priority.
Feb 13 2020, 9:32 PM · Lint, libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 3:59 PM · libphutil
avivey awarded T13488: Upgrading: Early 2020 Changes to Arcanist a Party Time token.
Feb 13 2020, 2:11 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 2:03 PM · libphutil
epriestley updated the task description for T13488: Upgrading: Early 2020 Changes to Arcanist.
Feb 13 2020, 2:01 PM · Arcanist, Installing & Upgrading
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 13 2020, 1:51 PM · libphutil
epriestley added a comment to T13395: Strip libphutil for parts.

I'm also going to collapse as much of experimental into master as I can here, make the minimum required PHP version 5.5 (see T11968), and attempt to collapse wilds.

Feb 13 2020, 1:51 PM · libphutil
epriestley triaged T13488: Upgrading: Early 2020 Changes to Arcanist as Low priority.
Feb 13 2020, 1:49 PM · Arcanist, Installing & Upgrading
epriestley added a comment to T11968: Decide the fate of FutureGraph.

Probably require PHP 5.4 regardless.

Feb 13 2020, 1:29 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

A problem in moving forward here is that we ultimately do very little complex data access in Phabricator, and what complex data access we do perform can often be faked. We likely have more use cases in Arcanist and provisioning code: API calls are slower, workflows are more parallel/interactive, and we can't just fake it all with AJAX.

Feb 13 2020, 3:59 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T13010: Upgrading: Differential Draft State: Unknown Object (Differential Revision).
Feb 13 2020, 12:36 AM · Installing & Upgrading
epriestley updated the task description for T13010: Upgrading: Differential Draft State.
Feb 13 2020, 12:31 AM · Installing & Upgrading
epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential, a subtask of T9123: Build Phabricator in Harbormaster (v2), as Resolved.
Feb 13 2020, 12:20 AM · Prioritized, Harbormaster
epriestley closed T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential as Resolved by committing Restricted Diffusion Commit.
Feb 13 2020, 12:20 AM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential

Feb 12 2020

epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 11:58 PM · libphutil
epriestley added a revision to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential: Unknown Object (Differential Revision).
Feb 12 2020, 11:48 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 11:45 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 11:11 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 11:06 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 10:37 PM · libphutil
epriestley updated the description for U47 "libphutil" Library Now Deprecated.
Feb 12 2020, 10:30 PM
epriestley created U47 "libphutil" Library Now Deprecated.
Feb 12 2020, 10:30 PM
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 8:30 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 8:01 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 7:58 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 7:48 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Feb 12 2020, 7:47 PM · libphutil
epriestley edited the content of Changelog.
Feb 12 2020, 7:35 PM
epriestley created an object: 2020 Week 6 (Early February).
Feb 12 2020, 7:34 PM

Feb 7 2020

epriestley added a comment to T2383: Run PHP environment checks from CLI.

https://discourse.phabricator-community.org/t/activities-notifications-spam/3286/ is likely a case where curl was not installed on the CLI, but was installed in the web SAPI.

Feb 7 2020, 8:52 PM · Setup
epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

A saved state is likely something like this:

Feb 7 2020, 4:54 PM · Harbormaster, Drydock, Arcanist
epriestley added a comment to T11402: Garbage collect and/or compress/archive harbormaster build unit messages.

I'd like to leave behind a "Results were GC'd on X/Y/Z" message when we GC these so it's clear what's going on.

Feb 7 2020, 2:07 PM · Restricted Project, Harbormaster, Feature Request

Feb 6 2020

epriestley closed T5427: Force a line break in a table cell as Resolved by committing Restricted Diffusion Commit.
Feb 6 2020, 11:01 PM · Remarkup
epriestley added a revision to T5427: Force a line break in a table cell: Unknown Object (Differential Revision).
Feb 6 2020, 10:53 PM · Remarkup
epriestley added a comment to T5427: Force a line break in a table cell.

(See also T13160, and D20568 for additional rationale.)

Feb 6 2020, 10:50 PM · Remarkup
epriestley reopened T5427: Force a line break in a table cell as "Open".

See also PHI1630.

Feb 6 2020, 10:49 PM · Remarkup

Feb 5 2020

epriestley added a revision to T10635: Loading differential revision slow when lots of unit test messages exist: Unknown Object (Differential Revision).
Feb 5 2020, 3:45 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley triaged T10635: Loading differential revision slow when lots of unit test messages exist as Wishlist priority.
Feb 5 2020, 3:41 PM · Restricted Project, Haskell.org, Harbormaster, Performance

Feb 4 2020

epriestley closed T13487: Improve performance of remarkup block splitting as Resolved by committing Restricted Diffusion Commit.
Feb 4 2020, 11:07 PM · Remarkup
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: Unknown Object (Differential Revision).
Feb 4 2020, 11:06 PM · Design
epriestley added a revision to T13487: Improve performance of remarkup block splitting: Unknown Object (Differential Revision).
Feb 4 2020, 10:37 PM · Remarkup
epriestley added a comment to T13487: Improve performance of remarkup block splitting.

To attempt to justify micro-optimizing this loop:

Feb 4 2020, 9:45 PM · Remarkup
epriestley triaged T13487: Improve performance of remarkup block splitting as Wishlist priority.
Feb 4 2020, 9:23 PM · Remarkup
epriestley added a comment to T10635: Loading differential revision slow when lots of unit test messages exist.

See also PHI1628, which reports that a 4MB blob of test details is slow to render.

Feb 4 2020, 8:48 PM · Restricted Project, Haskell.org, Harbormaster, Performance
epriestley closed T13486: Dates in curtain bylines may be hidden by long usernames as Resolved.

I might make some more tweaks to the UI, but this looks like it's in better shape now.

Feb 4 2020, 8:44 PM · Design
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: Unknown Object (Differential Revision).
Feb 4 2020, 8:29 PM · Design
epriestley added a revision to T13486: Dates in curtain bylines may be hidden by long usernames: Unknown Object (Differential Revision).
Feb 4 2020, 5:25 PM · Design
epriestley triaged T13486: Dates in curtain bylines may be hidden by long usernames as Wishlist priority.
Feb 4 2020, 4:18 PM · Design
epriestley closed T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup as Resolved by committing Restricted Diffusion Commit.
Feb 4 2020, 4:09 PM · Remarkup
epriestley added a revision to T13335: Paragraphs are collapsed incorrectly in quoted blocks in remarkup: Unknown Object (Differential Revision).
Feb 4 2020, 4:05 PM · Remarkup
epriestley closed T13485: Update GitHub integration for "access_token" deprecation changes as Resolved by committing Restricted Diffusion Commit.
Feb 4 2020, 3:58 PM · Auth
epriestley added a revision to T13485: Update GitHub integration for "access_token" deprecation changes: Unknown Object (Differential Revision).
Feb 4 2020, 3:51 PM · Auth
epriestley added a comment to T13485: Update GitHub integration for "access_token" deprecation changes.

The actual replacement is Authorization: token <token>, I believe:

Feb 4 2020, 3:47 PM · Auth
epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx", a subtask of T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships, as Resolved.
Feb 4 2020, 3:05 PM · Customer Impact, Differential, Maniphest
epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Resolved by committing Restricted Diffusion Commit.
Feb 4 2020, 3:05 PM · Maniphest, Differential, Diffusion
epriestley triaged T13485: Update GitHub integration for "access_token" deprecation changes as Low priority.
Feb 4 2020, 2:39 PM · Auth

Feb 3 2020

epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

I just wanted to hold it across the release cut, it's headed to master shortly.

Feb 3 2020, 7:02 PM · Maniphest, Differential, Diffusion
swisspol added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

@epriestley what's blocking landing this diff?

Feb 3 2020, 6:46 PM · Maniphest, Differential, Diffusion
epriestley added a revision to T13484: Allow the policy layer to mark objects as damaged when filtering them: Unknown Object (Differential Revision).
Feb 3 2020, 4:45 PM · Policy
epriestley triaged T13484: Allow the policy layer to mark objects as damaged when filtering them as Wishlist priority.
Feb 3 2020, 4:40 PM · Policy
epriestley closed T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2) as Resolved.

Both of these hosts restarted cleanly.

Feb 3 2020, 2:19 PM · Phacility, Ops
epriestley added a comment to T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2).

AWS is also rebooting web007.

Feb 3 2020, 1:22 PM · Phacility, Ops
epriestley added a revision to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields: Unknown Object (Differential Revision).
Feb 3 2020, 1:05 PM · Projects, Owners, Herald
epriestley added a comment to T13480: Implement "Author's packages", "Added project tags", and "Removed project tags" Herald fields.

See https://discourse.phabricator-community.org/t/herald-rule-not-adding-auditors-to-commits-following-upgrade/3505 for one bug with this.

Feb 3 2020, 1:04 PM · Projects, Owners, Herald

Jan 30 2020

epriestley edited the content of Changelog.
Jan 30 2020, 9:39 PM
epriestley created an object: 2020 Week 5 (Very Late January).
Jan 30 2020, 9:35 PM
epriestley closed T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Resolved.

Sounds good. It felt slightly odd to me at first, too, but I think I also got used to it.

Jan 30 2020, 8:16 PM · Diffusion, Differential, Maniphest
swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

It wasn't a major UI issue to start with and yes, you get used to it. I would ignore.

Jan 30 2020, 7:37 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Jan 30 2020, 6:45 PM · Differential
epriestley closed T13434: Support Perforce/Git in "arc land" as Resolved.

This appears to be working. T13481 fixed one straggling issue with changes to remote handling in very old versions of Git but nothing else has cropped up.

Jan 30 2020, 6:44 PM · Arcanist
epriestley added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?

Jan 30 2020, 6:42 PM · Diffusion, Differential, Maniphest
epriestley closed T13450: Update "Renaming Instances" in Phacility documentation as Resolved by committing Restricted Diffusion Commit.
Jan 30 2020, 6:37 PM · Phacility
epriestley triaged T13483: (2020 Week 5) Restart AWS host db001 (i-3a9b99f2) as Normal priority.
Jan 30 2020, 6:36 PM · Phacility, Ops
epriestley added a revision to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": Unknown Object (Differential Revision).
Jan 30 2020, 6:32 PM · Maniphest, Differential, Diffusion